Your message dated Mon, 29 Oct 2018 00:09:15 +0000
with message-id <[email protected]>
and subject line Bug#912141: fixed in libsdl-sge 030809dfsg-9
has caused the Debian Bug report #912141,
regarding libsdl-sge FTCBFS: multiple reasons
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
912141: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=912141
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: libsdl-sge
Version: 030809dfsg-8
Tags: patch
User: [email protected]
Usertags: rebootstrap
libsdl-sge fails to cross build from source for multiple distinct
reasons.
* debian/rules does not pass any cross tools to make. Using
dh_auto_build fixes that.
* The (modified) upstream Makefile hard codes the build architecture
pkg-config.
* The upstream Makefile dependencies are messed up. For instance, the
config target does not actually create the file "config". Thus it is
rebuilt every time. This causes a rebuild in dh_auto_install for
which debhelper does not pass cross tools.
The attached patch fixes all of that and makes libsdl-sge cross
buildable. Please consider applying it.
Helmut
diff --minimal -Nru libsdl-sge-030809dfsg/debian/changelog
libsdl-sge-030809dfsg/debian/changelog
--- libsdl-sge-030809dfsg/debian/changelog 2018-10-19 22:26:15.000000000
+0200
+++ libsdl-sge-030809dfsg/debian/changelog 2018-10-28 14:40:16.000000000
+0100
@@ -1,3 +1,14 @@
+libsdl-sge (030809dfsg-8.1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Fix FTCBFS: (Closes: #-1)
+ + Let dh_auto_build pass cross tools to make.
+ + cross.patch: Make pkg-config substitutable.
+ + cross.patch: Fix makefile dependencies to avoid excessive
+ rebuilds during make install.
+
+ -- Helmut Grohne <[email protected]> Sun, 28 Oct 2018 14:40:16 +0100
+
libsdl-sge (030809dfsg-8) unstable; urgency=medium
* Bump Policy Standars-Version to 4.2.1 (no changes needed)
diff --minimal -Nru libsdl-sge-030809dfsg/debian/patches/cross.patch
libsdl-sge-030809dfsg/debian/patches/cross.patch
--- libsdl-sge-030809dfsg/debian/patches/cross.patch 1970-01-01
01:00:00.000000000 +0100
+++ libsdl-sge-030809dfsg/debian/patches/cross.patch 2018-10-28
14:40:16.000000000 +0100
@@ -0,0 +1,66 @@
+--- libsdl-sge-030809dfsg.orig/Makefile.conf
++++ libsdl-sge-030809dfsg/Makefile.conf
+@@ -11,6 +11,7 @@
+ # Compilers (C and C++)
+ CC=gcc
+ CXX=g++
++PKG_CONFIG?=pkg-config
+
+ # Make sure sdl-config is available
+ HAVE_SDL =$(shell if (sdl-config --version) < /dev/null > /dev/null 2>&1;
then echo "y"; else echo "n"; fi;)
+@@ -36,15 +37,15 @@
+
+
+ # Is freetype-config available?
+-HAVE_FT =$(shell if (pkg-config --modversion freetype2) < /dev/null >
/dev/null 2>&1; then echo "y"; else echo "n"; fi;)
++HAVE_FT =$(shell if ($(PKG_CONFIG) --modversion freetype2) < /dev/null >
/dev/null 2>&1; then echo "y"; else echo "n"; fi;)
+ ifeq ($(HAVE_FT),n)
+ USE_FT = n
+ endif
+
+ ifneq ($(USE_FT),n)
+ USE_FT = y
+- SGE_LIBS +=$(shell pkg-config freetype2 --libs)
+- FT_CFLAGS =$(shell pkg-config freetype2 --cflags)
++ SGE_LIBS +=$(shell $(PKG_CONFIG) freetype2 --libs)
++ FT_CFLAGS =$(shell $(PKG_CONFIG) freetype2 --cflags)
+ endif
+
+
+--- libsdl-sge-030809dfsg.orig/Makefile
++++ libsdl-sge-030809dfsg/Makefile
+@@ -11,20 +11,21 @@
+
+ OBJECTS=sge_surface.o sge_primitives.o sge_tt_text.o sge_bm_text.o sge_misc.o
sge_textpp.o sge_blib.o sge_rotation.o sge_collision.o sge_shape.o
+
+-all: config $(OBJECTS)
++all: sge_config.h $(OBJECTS)
+ ar rsc libSGE.a $(OBJECTS)
+
+ $(OBJECTS): %.o:%.cpp %.h #Each object depends on thier .cpp and .h file
+ $(CXX) $(CFLAGS) -c $<
+
+-shared: all
++shared: libSGE.so
++libSGE.so: sge_config.h $(OBJECTS)
+ $(CXX) $(CFLAGS) $(LDFLAGS) -Wl,-soname,libSGE.so.$(API_VER) -fpic
-fPIC -shared -o libSGE.so $(OBJECTS) $(LIBS)
+
+ shared-strip: shared
+ @strip libSGE.so
+
+ # Building a dll... I have no idea how to do this, but it should be something
like below.
+-dll: config $(OBJECTS)
++dll: sge_config.h $(OBJECTS)
+ dlltool --output-def SGE.def $(OBJECTS)
+ dllwrap --driver-name $(CXX) -o SGE.dll --def SGE.def --output-lib
libSGE.a --dllname SGE.dll $(OBJECTS) $(LIBS)
+
+@@ -34,7 +35,8 @@
+ clean:
+ rm -f *.o *.so *.so.* *.a *.dll *.def
+
+-config:
++config:sge_config.h
++sge_config.h:
+ @echo "/* SGE Config header (generated automatically) */" >sge_config.h
+ @echo "#define SGE_VER $(SGE_VER)" >>sge_config.h
+ ifeq ($(C_COMP),y)
diff --minimal -Nru libsdl-sge-030809dfsg/debian/patches/series
libsdl-sge-030809dfsg/debian/patches/series
--- libsdl-sge-030809dfsg/debian/patches/series 2018-10-19 22:17:58.000000000
+0200
+++ libsdl-sge-030809dfsg/debian/patches/series 2018-10-28 14:40:16.000000000
+0100
@@ -6,3 +6,4 @@
010_examples.diff
015_overflow.diff
100_font.diff
+cross.patch
diff --minimal -Nru libsdl-sge-030809dfsg/debian/rules
libsdl-sge-030809dfsg/debian/rules
--- libsdl-sge-030809dfsg/debian/rules 2017-06-19 23:36:29.000000000 +0200
+++ libsdl-sge-030809dfsg/debian/rules 2018-10-28 14:40:15.000000000 +0100
@@ -21,13 +21,13 @@
override_dh_auto_build:
# Build the static library and make a backup
rm -f libSGE.a
- $(MAKE) all CUSTOM_CFLAGS="$(ALL_CUSTOM_CFLAGS)"
CUSTOM_LDFLAGS="$(ALL_CUSTOM_LDFLAGS)"
+ dh_auto_build -- all CUSTOM_CFLAGS="$(ALL_CUSTOM_CFLAGS)"
CUSTOM_LDFLAGS="$(ALL_CUSTOM_LDFLAGS)"
rm -f libSGE.bak
mv libSGE.a libSGE.bak
# Build the shared library and restore the static backup
$(MAKE) clean
- $(MAKE) shared CUSTOM_CFLAGS="$(ALL_CUSTOM_CFLAGS)"
CUSTOM_LDFLAGS="$(ALL_CUSTOM_LDFLAGS)"
+ dh_auto_build -- shared CUSTOM_CFLAGS="$(ALL_CUSTOM_CFLAGS)"
CUSTOM_LDFLAGS="$(ALL_CUSTOM_LDFLAGS)"
rm -f libSGE.a
mv libSGE.bak libSGE.a
--- End Message ---
--- Begin Message ---
Source: libsdl-sge
Source-Version: 030809dfsg-9
We believe that the bug you reported is fixed in the latest version of
libsdl-sge, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Manuel A. Fernandez Montecelo <[email protected]> (supplier of updated libsdl-sge
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sun, 28 Oct 2018 23:20:06 +0100
Source: libsdl-sge
Binary: libsdl-sge libsdl-sge-dev
Architecture: source amd64
Version: 030809dfsg-9
Distribution: unstable
Urgency: medium
Maintainer: Debian SDL packages maintainers
<[email protected]>
Changed-By: Manuel A. Fernandez Montecelo <[email protected]>
Description:
libsdl-sge - extension of graphic functions for SDL multimedia libraries
libsdl-sge-dev - extension of graphic functions for the SDL multimedia,
developmen
Closes: 912141
Changes:
libsdl-sge (030809dfsg-9) unstable; urgency=medium
.
[ Helmut Grohne ]
* Fix FTCBFS: (Closes: #912141)
+ Let dh_auto_build pass cross tools to make.
+ cross.patch: Make pkg-config substitutable.
+ cross.patch: Fix makefile dependencies to avoid excessive
rebuilds during make install.
.
[ Manuel A. Fernandez Montecelo ]
* Apply and upload fix from Helmut Grohne
Checksums-Sha1:
41fcbd432d03372806506b083f5eed2de5f4e1fd 2235 libsdl-sge_030809dfsg-9.dsc
8f75018fae7e8ae66c756e43c8e7ef6a20df30b8 8392
libsdl-sge_030809dfsg-9.debian.tar.xz
8e6eb92d88a0cb3d4c536bc1c41e5ce7c062f571 325632
libsdl-sge-dbgsym_030809dfsg-9_amd64.deb
5e5732ab40566426925899e1ab563dad40eba247 162084
libsdl-sge-dev_030809dfsg-9_amd64.deb
4168ab159022cb1dfbe836b6145470842c2bf978 10438
libsdl-sge_030809dfsg-9_amd64.buildinfo
e0b09a5cffd300cc9514c178de4fcc7ea546f6a5 73436
libsdl-sge_030809dfsg-9_amd64.deb
Checksums-Sha256:
fa54cf2486fd0147df33133faf2d53c61163722cc0a950e776870eba55ee0023 2235
libsdl-sge_030809dfsg-9.dsc
09b4fd03d7c0c28ab8c78d53c4a8fb96b7a4c149d418a6b9dd1ee28055e58c7d 8392
libsdl-sge_030809dfsg-9.debian.tar.xz
ef20fe806128c8395d23b921dbf550a4f62855a2413785369c792196ac711bd3 325632
libsdl-sge-dbgsym_030809dfsg-9_amd64.deb
eff32665239f242103240f28f75b64171e3146cfe6adddeb29ff61233a2d4b69 162084
libsdl-sge-dev_030809dfsg-9_amd64.deb
7193fef9e92c755e995162aa69e667a35912995289d8a090f5174dbca28b2858 10438
libsdl-sge_030809dfsg-9_amd64.buildinfo
8560c0366c925b22436b5178bcc9efefc102f2a0d7ea83b256eeddd28219d6bb 73436
libsdl-sge_030809dfsg-9_amd64.deb
Files:
1a1ef7de750a6f52f8a338922512be70 2235 libs optional libsdl-sge_030809dfsg-9.dsc
38610e97833b5fc38f4e81be93b45e56 8392 libs optional
libsdl-sge_030809dfsg-9.debian.tar.xz
a0d6965f8d43c721fff383ccd2f2296a 325632 debug optional
libsdl-sge-dbgsym_030809dfsg-9_amd64.deb
0d8496021d41e4760327619ec8b3a43e 162084 libdevel optional
libsdl-sge-dev_030809dfsg-9_amd64.deb
6fd9ea85c9d62636836ff8e41be13024 10438 libs optional
libsdl-sge_030809dfsg-9_amd64.buildinfo
5fc031f83a465e3f5988f7b9ecae1303 73436 libs optional
libsdl-sge_030809dfsg-9_amd64.deb
-----BEGIN PGP SIGNATURE-----
iQJEBAEBCgAuFiEEKo6AUFxIYphDDdCTf3YGpEXcqA4FAlvWN4cQHG1hZm1AZGVi
aWFuLm9yZwAKCRB/dgakRdyoDihlD/44CwupfqdZwbqGqBgLW4sCJa8/AAn9Yfd0
7dwWQ+XBT/R939KIkB9RSj6wcXPGS8sXJpMBiJ8cx7rpBK1yfc2PE/hPDTfVw8zZ
spocn78PnKs3e/cTMuH0ASOHzC4bihQpKB/dlG6YBjnf21lqe3TamgB5K3V9IqpN
FRmpm0ARgliHPKTL4zyM8Miak2gMAn2C/udUalqaynukLDuSs6qZPMb+ZSGUIbfA
5yY4h5NAXWHU3tJtI1wGj9fkhlvWLQ9VeaNpm2LqreNDYmEeP6meA5WQMZqXIeF3
fD2S0bY0mRMGqEK0OWyJ0bpD1zR0YBMoY0U0yw/iFAxALlk9dLumvIo08BqiZkh1
OIGbJEi+W/HaIiI2yisPWIO4NSPkWP+SQoIa7+qdwGblZkbbRsm54J3WsTk1o2cG
Uyi4+XwEHrBpcZxPXMz84uF0hMFzNc1I3pwN35blEzSIzIEox8ooHWzLtQET8W57
5FTMTbQ8rFG9XW9twY2S3znuM0mhVGWH6P73hv4T1FAKuUDaf8tqRH8/6SG5qDs7
yftInv1gCBLXDC1BQzcKImudMZgulIMZLQV0CtP6O1Z90GlWdyjZxspO1GcmjyMI
/up/qzxAKfcMrDnGo/bWx/AvSS+TREgFaD6gddIYPaFP6qHxzoRmzVZoutaB0XU/
5xlVC4O26Q==
=DN4R
-----END PGP SIGNATURE-----
--- End Message ---
