Your message dated Wed, 31 Oct 2018 05:33:23 +0000
with message-id <[email protected]>
and subject line Bug#911546: Removed package(s) from unstable
has caused the Debian Bug report #818315,
regarding letodms: please don't use "if ! dbc_go" in your maintainer scripts
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
818315: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=818315
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: letodms
Version: 3.3.11+dfsg.1-2
Severity: wishlist

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Dear maintainer,

According to codesearch¹ you are using the following construction in one or
more of your maintainer scripts:
if ! dbc_go <package_name> $@ ; then
    echo 'Automatic configuration using dbconfig-common failed!'
fi

I feel that I must explain to you why this is most likely not working as you
intended and additionally caused me quite some debugging time a while ago.

The main point is that maintainer scripts are strongly recommended to "set -e"
at the beginning of the scripts by the Debian Policy². However, if you use
constructions like "if" or "||" than the "set -e" don't propagate to the called
scripts or functions, errors in the scripts or functions are ignored and the
script continues. In the past (before version 2.0.0) dbconfig-common error
handling used to rely on the behavior of "set -e" (which of course can be
questioned, because it may not be set). Ironically that means that before
version 2.0.0 you never observed the text that you included in the echo
statement in your script.

Now, in case of errors, the error handling of dbconfig-common asks the
administrator how to proceed after the error with the
installation/configuration/removal/purging of the package. One of the options
is to abort, which is described as follows:

  * abort - Causes the operation to fail; you will need to downgrade,
    reinstall, reconfigure this package, or otherwise manually intervene
    to continue using it. This will usually also impact your ability to
    install other packages until the installation failure is resolved.

By using the "if !dbc_go" statement you are ignoring the wish of the
administrator, albeit it being the default answer. I kindly request to not use
the construction anymore. If you must, I suggest you change the answer to the
error questions to "ignore" (but please don't set the question as "seen").

Because the dbconfig-common files are sourced, I currently believe it is
incorrect to "set -e" in the dbconfig-common files.

Paul
Current maintainer of dbconfig-common

¹ https://codesearch.debian.net/perpackage-results/!%20dbc_go/2/page_0
² https://www.debian.org/doc/debian-policy/ch-maintainerscripts.html#s6.1

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBCAAGBQJW6GkcAAoJEJxcmesFvXUKH7QH/ij/S7r/5C+Kelu+HIJdeQS2
yC5Ipn/Q8EHOcjES3UayZlPZH80pSt+oRWDgVqPaDu34MVcmqWekKg8Ile0+VkfN
0kUMEKAKKDT+HPi5Ys3w2FQ5ArC74Ud5LPPxl39MWem4fL7Mo837uCOLx+9crjS7
O04ErhlOTlOswnI4triIyCa3zTXZQIhoRt+fSDdghxSVESOKgjhWzAUA2tvNsHye
njYzcJVvHwUY/3Qny54w/gSTe8yWtH+L/hfesLVEOChBlNjMfFHyPdKviGtol8mP
/jJF5BSUOdqiDPmmEGAD9F3MLRs6Mfado7nxLkqJGHXGs4LoyigCf0qB7Nzxst4=
=caJY
-----END PGP SIGNATURE-----

--- End Message ---
--- Begin Message ---
Version: 3.4.2+dfsg-3+rm

Dear submitter,

as the package letodms has just been removed from the Debian archive
unstable we hereby close the associated bug reports.  We are sorry
that we couldn't deal with your issue properly.

For details on the removal, please see https://bugs.debian.org/911546

The version of this package that was in Debian prior to this removal
can still be found using http://snapshot.debian.org/.

This message was generated automatically; if you believe that there is
a problem with it please contact the archive administrators by mailing
[email protected].

Debian distribution maintenance software
pp.
Scott Kitterman (the ftpmaster behind the curtain)

--- End Message ---

Reply via email to