Your message dated Wed, 07 Nov 2018 06:03:50 +0000
with message-id <[email protected]>
and subject line Bug#913108: fixed in ocsinventory-agent 2:2.4.2-2
has caused the Debian Bug report #913108,
regarding ocsinventory-agent: autopkgtest failures with perl 5.28: useless use 
of concatenation
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
913108: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=913108
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: ocsinventory-agent
Version: 2:2.4.2-1
Severity: important
Tags: patch
User: [email protected]
Usertags: origin-ubuntu disco ubuntu-patch

Hi Xavier,

With the upload of perl 5.28, the ocsinventory-agent autopkgtests are now 
failing:

[...]
autopkgtest [11:17:40]: test command2: /usr/share/pkg-perl-autopkgtest/runner 
runtime-deps
autopkgtest [11:17:40]: test command2: [-----------------------
#   Failed test ' /usr/bin/perl -w -M"Ocsinventory::Agent" -e 1 2>&1 produced 
no (non-whitelisted) output'
#   at /usr/share/pkg-perl-autopkgtest/runtime-deps.d/use.t line 108.
#   Failed test 'env PERL_DL_NONLAZY=1  /usr/bin/perl -w 
-M"Ocsinventory::Agent" -e 1 2>&1 produced no (non-whitelisted) output'
#   at /usr/share/pkg-perl-autopkgtest/runtime-deps.d/use.t line 108.
# Looks like you failed 2 tests of 4.
[...]

  (https://ci.debian.net/packages/o/ocsinventory-agent/unstable/amd64/)

Applying the attached patch to remove the useless lines of code fixes the
autopkgtest failure in Ubuntu, and should do so for Debian as well.

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                   https://www.debian.org/
[email protected]                                     [email protected]
diff -Nru ocsinventory-agent-2.4.2/debian/patches/no-useless-concat.patch 
ocsinventory-agent-2.4.2/debian/patches/no-useless-concat.patch
--- ocsinventory-agent-2.4.2/debian/patches/no-useless-concat.patch     
1969-12-31 16:00:00.000000000 -0800
+++ ocsinventory-agent-2.4.2/debian/patches/no-useless-concat.patch     
2018-11-06 16:59:26.000000000 -0800
@@ -0,0 +1,19 @@
+Description: drop pointless statements that generate a perl warning
+ Perl 5.28 warns of:
+ # Useless use of concatenation (.) or string in void context at 
/usr/share/perl5/Ocsinventory/Agent/Network.pm line 53.
+ This generates autopkgtests failures, so just remove the useless lines.
+Author: Steve Langasek <[email protected]>
+
+Index: ocsinventory-agent-2.4.2/lib/Ocsinventory/Agent/Network.pm
+===================================================================
+--- ocsinventory-agent-2.4.2.orig/lib/Ocsinventory/Agent/Network.pm
++++ ocsinventory-agent-2.4.2/lib/Ocsinventory/Agent/Network.pm
+@@ -49,8 +49,6 @@
+     my $version = 'OCS-NG_unified_unix_agent_v';
+     $version .= exists 
($self->{config}->{VERSION})?$self->{config}->{VERSION}:'';
+     $self->{ua}->agent($version);
+-    $self->{config}->{user}.",".
+-    $self->{config}->{password}."";
+     $self->{ua}->credentials(
+         $uaserver, # server:port, port is needed 
+         $self->{config}->{realm},
diff -Nru ocsinventory-agent-2.4.2/debian/patches/series 
ocsinventory-agent-2.4.2/debian/patches/series
--- ocsinventory-agent-2.4.2/debian/patches/series      2018-08-01 
02:49:49.000000000 -0700
+++ ocsinventory-agent-2.4.2/debian/patches/series      2018-11-06 
16:57:18.000000000 -0800
@@ -1,2 +1,3 @@
 no_postinst_questions.patch
 propagate-ccflags.patch
+no-useless-concat.patch

--- End Message ---
--- Begin Message ---
Source: ocsinventory-agent
Source-Version: 2:2.4.2-2

We believe that the bug you reported is fixed in the latest version of
ocsinventory-agent, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Xavier Guimard <[email protected]> (supplier of updated ocsinventory-agent 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 07 Nov 2018 06:30:43 +0100
Source: ocsinventory-agent
Binary: ocsinventory-agent
Architecture: source
Version: 2:2.4.2-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Perl Group <[email protected]>
Changed-By: Xavier Guimard <[email protected]>
Closes: 913108
Description: 
 ocsinventory-agent - Hardware and software inventory tool (client)
Changes:
 ocsinventory-agent (2:2.4.2-2) unstable; urgency=medium
 .
   * Email change: Xavier Guimard -> [email protected]
   * Add no-useless-concat.patch (reported) (Closes: #913108)
   * Declare compliance with policy 4.2.1
Checksums-Sha1: 
 9465d56f75ade03b391761f96c29314469574eba 2203 ocsinventory-agent_2.4.2-2.dsc
 8ab9a10c490a48cffdd575072dc20cfe113c1aa5 19212 
ocsinventory-agent_2.4.2-2.debian.tar.xz
Checksums-Sha256: 
 4c46be8b37976658e1818331604dbb114d8cf2c07287e808966f67fdfb40d805 2203 
ocsinventory-agent_2.4.2-2.dsc
 68f2187575153b2459f0e86921276a0904107e47a68b08affc9c3830df3fa01a 19212 
ocsinventory-agent_2.4.2-2.debian.tar.xz
Files: 
 ddb942e67316db7f3aab776fefbe0735 2203 net optional 
ocsinventory-agent_2.4.2-2.dsc
 dd277fdc457eb9d16cd1f6096e11cc2b 19212 net optional 
ocsinventory-agent_2.4.2-2.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQJEBAEBCgAuFiEEAN/li4tVV3nRAF7J9tdMp8mZ7ukFAlvie6UQHHlhZGRAZGVi
aWFuLm9yZwAKCRD210ynyZnu6T3LD/9+2CpFQBZhbYL+scYqcnhTAkbs0/750PUQ
k+LQl3R49qUdrF1deWAzTh/AjWOvFhwdyqv4inEddJFZC7sW+G31kXlUTbTdp8Fy
SucDMDbA81eXmgptABqSKNHIv/QWlKhu1z20lU1wbJtZMFpC5Rxzpssjn7agWmmK
i2xxZh5+2i5MDxEFFxK/+s2sVfX0N3pcTJ1if67GqIa6k+v+SpcSIiFhH7QIeTr9
WiMS63TyBBc2yuk+hGYmb08c3wZkxrfA57DrlJTEtX8mXul0ZNEn3qLg5PhSreum
G9Vl9RezNS2FLS39Ny7rqKOAkm7MQ6jPjmxeO/sHUHdtgVe/VsRt9623Sn2XlhYy
Bpkbzr+5KVsRlT9wwrIY3PfGxneXwuxb8a+Z89+zmjf6FtjO9YiuvXhEAcjZYIcV
TEb620BvXu7/DgnoGmbpSryTbngsMZTHB6/VNlysLVajPaAzt74rtZzxUajmKWgs
kSjUe8fNRzVG4PLZU40c+8IzI4qOySCaRMTbSvo+qTvA8eMf2oN1GH07JTPWpmx6
iDmaJDrHb9iVA1BkYfPSYlD44Kf05CzLYaqQnraXKmVOLpaDaXvvyxKlTkq9r0BX
yqwrxHmJNxUjl6g/LI0w9j2BGzUTlghxfn0cbBDDviyVGNI8xDOtmRVpSgBrVnv3
+P/FtU2LYg==
=hkK4
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to