Your message dated Thu, 22 Nov 2018 23:49:13 +0000
with message-id <[email protected]>
and subject line Bug#913668: fixed in collectd 5.8.1-1
has caused the Debian Bug report #913668,
regarding collectd confuses build/host
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
913668: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=913668
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: collectd
Version: 5.8.0-5.2
Tags: patch
User: [email protected]
Usertags: rebootstrap
I looked into cross building collectd and that turns out to be
difficult. However one thing became apparent quite quickly to me:
debian/rules confuses build and host. These terms are defined in man
dpkg-architecture. Furthermore, debian/rules tries to match everything
against the Debian architecture name, but there are better ways to match
e.g. the kernel. The attached patch fixes that. Please consider applying
it. Please also consider going beyond. For instance, a comment says
"These plugins are Intel-hardware specific.". If that is really the
case, then maybe use "ifeq (,$(filter amd64 i386,$(DEB_HOST_ARCH_CPU)))".
Doing so would additionally match kfreebsd-amd64, hurd-i386 and x32. I'm
not sure whether that's appropriate.
Before looking further into cross building collectd, I'll need to file a
patch for libvirt.
Helmut
diff --minimal -Nru collectd-5.8.0/debian/rules collectd-5.8.0/debian/rules
--- collectd-5.8.0/debian/rules 2018-08-06 20:36:32.000000000 +0200
+++ collectd-5.8.0/debian/rules 2018-11-13 06:09:53.000000000 +0100
@@ -8,9 +8,7 @@
# These are used for cross-compiling and for saving the configure script
# from having to guess our platform (since we know it already)
-DEB_HOST_GNU_TYPE ?= $(shell dpkg-architecture -qDEB_HOST_GNU_TYPE)
-DEB_BUILD_ARCH ?= $(shell dpkg-architecture -qDEB_BUILD_ARCH)
-DEB_BUILD_GNU_TYPE ?= $(shell dpkg-architecture -qDEB_BUILD_GNU_TYPE)
+include /usr/share/dpkg/architecture.mk
export DEB_BUILD_MAINT_OPTIONS=hardening=+all
@@ -28,7 +26,7 @@
# A PostgreSQL header redefines CACHE_LINE_SIZE on FreeBSD.
# Cf. https://bugs.debian.org/760719 and https://bugs.debian.org/763098
-ifneq (,$(filter kfreebsd-i386 kfreebsd-amd64, $(DEB_BUILD_ARCH)))
+ifeq ($(DEB_HOST_ARCH_OS),kfreebsd)
CPPFLAGS += -Wp,-w
endif
@@ -95,7 +93,7 @@
confflags += --disable-varnish
# These plugins are Linux-specific.
-ifneq (,$(filter kfreebsd-i386 kfreebsd-amd64, $(DEB_BUILD_ARCH)))
+ifeq ($(DEB_HOST_ARCH_OS),kfreebsd)
confflags += \
--disable-barometer \
--disable-cgroups \
@@ -117,7 +115,7 @@
endif
# This plugin is FreeBSD-specific.
-ifeq (,$(filter kfreebsd-i386 kfreebsd-amd64, $(DEB_BUILD_ARCH)))
+ifneq ($(DEB_HOST_ARCH_OS),kfreebsd)
confflags += \
--disable-pf
endif
@@ -127,7 +125,7 @@
--disable-zone
# These plugins have not been ported to FreeBSD yet.
-ifneq (,$(filter kfreebsd-i386 kfreebsd-amd64, $(DEB_BUILD_ARCH)))
+ifeq ($(DEB_HOST_ARCH_OS),kfreebsd)
# Work-around an incomplete check for kvm functionality
CPPFLAGS += -DHAVE_STRUCT_KINFO_PROC_FREEBSD
confflags += --enable-processes=force
@@ -150,7 +148,7 @@
endif
# Build-dependencies of these plugins are (not yet) available for kfreebsd.
-ifneq (,$(filter kfreebsd-i386 kfreebsd-amd64, $(DEB_BUILD_ARCH)))
+ifeq ($(DEB_HOST_ARCH_OS),kfreebsd)
confflags += \
--disable-gmond \
--disable-virt \
@@ -159,7 +157,7 @@
endif
# These plugins are Intel-hardware specific.
-ifeq (,$(filter amd64 i386, $(DEB_BUILD_ARCH)))
+ifeq (,$(filter amd64 i386, $(DEB_HOST_ARCH)))
confflags += \
--disable-dpdkevents \
--disable-dpdkstat \
@@ -171,25 +169,25 @@
endif
# This plugin is x86 and arm specific.
-ifeq (,$(filter amd64 arm64 armhf i386, $(DEB_BUILD_ARCH)))
+ifeq (,$(filter amd64 arm64 armhf i386, $(DEB_HOST_ARCH)))
confflags += \
--disable-xencpu
endif
# libatasmart isn't available on these platforms.
-ifneq (,$(filter hurd-i386 kfreebsd-i386 kfreebsd-amd64, $(DEB_BUILD_ARCH)))
+ifneq (,$(filter hurd kfreebsd,$(DEB_HOST_ARCH_OS)))
confflags += --disable-smart
endif
# The hppa buildds currently do not keep up with Java related stuff, thus
# prevending testing transitions. sparc is also having trouble building the
# java plugin.
-ifneq (,$(filter hppa sparc, $(DEB_BUILD_ARCH)))
+ifneq (,$(filter hppa sparc, $(DEB_HOST_ARCH)))
confflags += --disable-java
endif
# gRPC is only available on x86, arm, ppc.
-ifeq (,$(filter amd64 arm64 armel armhf i386 ppc64el powerpc, $(DEB_BUILD_ARCH)))
+ifeq (,$(filter amd64 arm64 armel armhf i386 ppc64el powerpc, $(DEB_HOST_ARCH)))
confflags += --disable-grpc
endif
--- End Message ---
--- Begin Message ---
Source: collectd
Source-Version: 5.8.1-1
We believe that the bug you reported is fixed in the latest version of
collectd, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Sebastian Harl <[email protected]> (supplier of updated collectd package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Fri, 23 Nov 2018 00:01:43 +0100
Source: collectd
Binary: collectd-core collectd collectd-utils collectd-dbg collectd-dev
libcollectdclient-dev libcollectdclient1
Architecture: source
Version: 5.8.1-1
Distribution: unstable
Urgency: medium
Maintainer: Sebastian Harl <[email protected]>
Changed-By: Sebastian Harl <[email protected]>
Description:
collectd - statistics collection and monitoring daemon
collectd-core - statistics collection and monitoring daemon (core system)
collectd-dbg - statistics collection and monitoring daemon (debugging symbols)
collectd-dev - statistics collection and monitoring daemon (development files)
collectd-utils - statistics collection and monitoring daemon (utilities)
libcollectdclient-dev - client library for collectd's control interface
(development file
libcollectdclient1 - client library for collectd's control interface
Closes: 913668
Changes:
collectd (5.8.1-1) unstable; urgency=medium
.
* New upstream release.
* debian/patches:
- Remove rd_kafka_last_error.patch; applied upstream.
* debian/control:
- Bump standards version to 4.2.1; no changes.
* debian/rules:
- Fix cross building: de-confuse build/host; thanks to Helmut Grohne for
reporting this and providing a patch (Closes: #913668).
- Disable mqtt plugin until #911265, #911266 get fixed.
Checksums-Sha1:
81e6946d2ba93d6b78c1d8faa3c5c757495fb46a 4098 collectd_5.8.1-1.dsc
ae02cf7474cf72b79be901b6f75e645330446198 1789228 collectd_5.8.1.orig.tar.bz2
4fb8b0503812998aca84c4e194f55f61099864e7 76656 collectd_5.8.1-1.debian.tar.xz
89071fbaaef291d92d8b20fdfc18c2510e1ac7f7 25212
collectd_5.8.1-1_source.buildinfo
Checksums-Sha256:
8a28071675ecf6a2cd5624f33b91d783c0525e9845d715f38ce5f2b718b2d654 4098
collectd_5.8.1-1.dsc
e796fda27ce06377f491ad91aa286962a68c2b54076aa77a29673d53204453da 1789228
collectd_5.8.1.orig.tar.bz2
5cb7800b7137d37b35839848259030143645d341fdaf4ac9fb8f1791ecf74029 76656
collectd_5.8.1-1.debian.tar.xz
c919b92ee41ce7860b85f447a4dd28e650ff8938dc46495750e9887905f9c840 25212
collectd_5.8.1-1_source.buildinfo
Files:
21a5963755ac5cbcb11de537cf9d04a9 4098 utils optional collectd_5.8.1-1.dsc
bfce96c42cede5243028510bcc57c1e6 1789228 utils optional
collectd_5.8.1.orig.tar.bz2
886414ab8d75106a721102c7108b115b 76656 utils optional
collectd_5.8.1-1.debian.tar.xz
b1028674abe1e831b18ead0c6aa4e84a 25212 utils optional
collectd_5.8.1-1_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEE0SB09zJN4Zng3RwbzAV+ci8f/McFAlv3N2oACgkQzAV+ci8f
/MeIlQ//UadITGBtY9L1CfYR8WGt39grUdPQVdS0zTkYWfEdDVmO/NLP3n/AvsOE
jeV9zGv8w1trvfZVb3MBAcJMH9H9M5fSxeLDqPBOtHYTMjUH9XTJ1h+T/okGrl+L
/ZSN3so6qyaF7eNtgtK7KDojz4my13wOsyPd/+9DTNcwtT1naW74uDV6HlmX5Dih
jpKMGdmfZuIu4unzTbrjqNKmbq0rIhreAWnl0Z3TeMwZ5sSBJ4Nl8WHbZDidWoJ2
m7MxGQmBabaH1090noi2KvrL48a8Mg8p9u2sY42b1JwGtZ7i8BzBT09Ep2zWP08c
TsMQXy33BdzhbHWS2IhGeskS/xvLfg5aReIOhW4HMlO6vBRO9vFrSx7pErHTEdZn
Q7mcv0SWrhrS3LgWG0WdbJaompupCXFxeDTtilY6YSyx340H6tk1WDHariTO8XrZ
N2o+iPcqcx5ZoZWsvmoRXAVp+vJSnM+WsF4h8xCreIcVLrDTVSi6AnR0jvXlyCp7
yp1lLp3qUq/CXK7/kUkQ01YoPNSNQ72onuPYmv9d0QUVNTIRzrMB1OPb6tdUlIWP
oaA4hXHj1hfqKQEKjtAn0XBM53Akd6T7SwM7C/ahsrnJELWpShwc5rxd62rCsqja
Cj/Emrmc1dGPaCi8V7GSGQvZo4djlfcU+rnlUjqEQhzJMUhk6Vc=
=EVMv
-----END PGP SIGNATURE-----
--- End Message ---
