Your message dated Sun, 02 Dec 2018 19:04:06 +0000
with message-id <[email protected]>
and subject line Bug#915222: fixed in backupninja 1.1.0-2.1
has caused the Debian Bug report #915222,
regarding backupninja: reproducible build (usrmerge): embeds path of
bash,mktemp,sed found via PATH
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
915222: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=915222
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: backupninja
Version: 1.1.0-2
Severity: normal
Tags: patch
User: [email protected]
Usertags: usrmerge
Dear Maintainer,
The package fails to build reproducibly on a merged-usr vs non-merged
system. This is caused by embedding the full paths of a few tools.
This can easily be fixed by passing in variables with explicit paths
to configure, rather than relying on finding them via PATH.
See attached debdiff that fixes this issue.
Regards,
Andreas Henriksson
diff -Nru backupninja-1.1.0/debian/changelog backupninja-1.1.0/debian/changelog
--- backupninja-1.1.0/debian/changelog 2018-08-12 03:45:35.000000000 +0200
+++ backupninja-1.1.0/debian/changelog 2018-12-01 21:39:53.000000000 +0100
@@ -1,3 +1,12 @@
+backupninja (1.1.0-2.1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Add debian/patches/unbreak-AC_PATH_PROG-bash.patch
+ * Pass BASH,SED,MKTEMP to configure specifying correct paths
+ - fixes reproducible build on merged-usr vs non-merged systems
+
+ -- Andreas Henriksson <[email protected]> Sat, 01 Dec 2018 21:39:53 +0100
+
backupninja (1.1.0-2) unstable; urgency=medium
* Fix FTBFS (Closes: #903168)
diff -Nru backupninja-1.1.0/debian/patches/series
backupninja-1.1.0/debian/patches/series
--- backupninja-1.1.0/debian/patches/series 1970-01-01 01:00:00.000000000
+0100
+++ backupninja-1.1.0/debian/patches/series 2018-12-01 21:39:53.000000000
+0100
@@ -0,0 +1 @@
+unbreak-AC_PATH_PROG-bash.patch
diff -Nru backupninja-1.1.0/debian/patches/unbreak-AC_PATH_PROG-bash.patch
backupninja-1.1.0/debian/patches/unbreak-AC_PATH_PROG-bash.patch
--- backupninja-1.1.0/debian/patches/unbreak-AC_PATH_PROG-bash.patch
1970-01-01 01:00:00.000000000 +0100
+++ backupninja-1.1.0/debian/patches/unbreak-AC_PATH_PROG-bash.patch
2018-12-01 21:39:53.000000000 +0100
@@ -0,0 +1,25 @@
+From: Andreas Henriksson <[email protected]>
+Subject: unbreak AC_PATH_PROG bash
+
+Being able to set the variable name in the environment before
+running configure is a documented feature of AC_PATH_PROG.
+Explicitly unsetting the variable ofcourse breaks that feature.
+
+If someone thinks BASH is not a good variable name because it
+might be used for something else already, then either sanitize
+your build environment or use a different variable name!
+
+The hypothetical case in the comment isn't relevant in our build
+environment, so unbreak things here by commenting out the unset....
+
+--- backupninja-1.1.0.orig/configure.ac
++++ backupninja-1.1.0/configure.ac
+@@ -11,7 +11,7 @@ AM_INIT_AUTOMAKE([foreign])
+
+ # BASH may already be set in the shell, if the admin then changes the
+ # the /bin/sh symlink to a non-bash shell, all hell will break lose.
+-unset BASH
++#unset BASH
+ AC_PATH_PROGS(BASH, bash, "no", [$PATH:/bin:/usr/bin:/usr/sbin])
+ if test x$BASH = "xno"; then
+ AC_MSG_ERROR([bash is required])
diff -Nru backupninja-1.1.0/debian/rules backupninja-1.1.0/debian/rules
--- backupninja-1.1.0/debian/rules 2018-08-12 03:44:14.000000000 +0200
+++ backupninja-1.1.0/debian/rules 2018-12-01 21:39:45.000000000 +0100
@@ -9,6 +9,8 @@
override_dh_auto_configure:
dh_auto_configure -- \
+ MKTEMP=/bin/mktemp BASH=/bin/bash SED=/bin/sed \
+ AWK=/usr/bin/awk STAT=/usr/bin/stat \
--libdir=\$${prefix}/lib \
--libexecdir=\$${prefix}/lib
--- End Message ---
--- Begin Message ---
Source: backupninja
Source-Version: 1.1.0-2.1
We believe that the bug you reported is fixed in the latest version of
backupninja, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Andreas Henriksson <[email protected]> (supplier of updated backupninja package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sat, 01 Dec 2018 21:39:53 +0100
Source: backupninja
Binary: backupninja
Architecture: source all
Version: 1.1.0-2.1
Distribution: unstable
Urgency: medium
Maintainer: Debian backupninja maintainers <[email protected]>
Changed-By: Andreas Henriksson <[email protected]>
Description:
backupninja - lightweight, extensible meta-backup system
Closes: 915222
Changes:
backupninja (1.1.0-2.1) unstable; urgency=medium
.
* Non-maintainer upload.
* Add debian/patches/unbreak-AC_PATH_PROG-bash.patch
* Pass BASH,SED,MKTEMP to configure specifying correct paths
- fixes reproducible build on merged-usr vs non-merged system
(Closes: #915222)
Checksums-Sha1:
560aa9e5dc67c1d78ba57998add1e14385cb6408 2053 backupninja_1.1.0-2.1.dsc
0fc9f03f6c2500228ba8b8e7807ab436497e2c56 14200
backupninja_1.1.0-2.1.debian.tar.xz
f3934c86eeeeb0ed8e8d4b8ca1209eb8239099f9 97248 backupninja_1.1.0-2.1_all.deb
8392c96845341a2647eaa6a65ee850308e3487a7 5519
backupninja_1.1.0-2.1_amd64.buildinfo
Checksums-Sha256:
502ec08b3bffeaee4ef325531cc6bc2f35ebf14119cb681d8acb0066413ca9d8 2053
backupninja_1.1.0-2.1.dsc
c76eacc1d09d763266f745512248b3e971ddf04c07386b87bd44e72f14cd0014 14200
backupninja_1.1.0-2.1.debian.tar.xz
b1b8c80c776a8376d3c9aee5ebf509790908de82b1da2e7017f20dc7a58dcbce 97248
backupninja_1.1.0-2.1_all.deb
a3fdd154c7bf6948e3c0aa535818a6cef519b7368f06ab5667934c38e24deecf 5519
backupninja_1.1.0-2.1_amd64.buildinfo
Files:
35b4c697b4d687df221e7c48e7b65c95 2053 admin optional backupninja_1.1.0-2.1.dsc
f779d9048f01be8d343b13f762d35efc 14200 admin optional
backupninja_1.1.0-2.1.debian.tar.xz
6a7189a3f49564717e040c59e1fa4a42 97248 admin optional
backupninja_1.1.0-2.1_all.deb
9cc9680b022fe69ad2c922df2ab36368 5519 admin optional
backupninja_1.1.0-2.1_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEC1ozuKJtYBCcUJxsg+M719TdTKEFAlwEHs4ACgkQg+M719Td
TKHYHg/8D3vhaUWrPOLdCzHWXqgh2fYm7O5Jp/EletsLFj/i7J0p8nDV9/BFy5oj
0QVMzSZ1YlAfOIKXs9okWa35F0+BxLiPJLrQ5tGgzn7lBROZ3FBqOJKJoFJFpGg1
aGO3vtf7SA6ORnuz7twVJ9EryOBkf+rCeKAqxBtuNJmhGNdwHUc4vJm2c+dFOr74
FMuiDzdJsk/9llhANdSnbH7djt29Ry0OXk2+DAfaFClla0ItPv6Mf5u50ZXGVS7h
0ocYPml1dPxMQ+3Lyo5NA+gCKL6gQgGVmh+YvLxtHz8ZdJXqlBtZKcY5z+5oazPp
nAaLJ+YHSRaIv3TbZKxEOZvFd5k2w/jwY/wVIXNmdU17ma3C6muODYTP2+6ahumr
YWs4WDkqV40FCRMe0ZcvoGvQigojYAX8zGW09xAf+bZLhAObdspEWjGYYFrip55u
2fqDwuqlkHMIgWAL2eKxmzMnjORe7Nbe3y6NM7THz1uHeQeiUboUSbQcpJZKYd2k
5r4FwJFtnKGjiQ3/zxoV/bzrybvGS/KWDYcuZx1YPbG2wFIeQTYnbzM0pEcDVDo5
yF+YmgfxKJIQYdQbZe3XyyLqhCqW8ajseaXRSJbsYcgTYgm0sl9G9VcO96ueEPQ8
9iXAOYG4NH8u+fX85x2coi9UN2KRY3HS6P1AEAsHZ85UNA7KDwc=
=iQq3
-----END PGP SIGNATURE-----
--- End Message ---
