Your message dated Mon, 03 Dec 2018 15:38:11 +0000
with message-id <[email protected]>
and subject line Bug#912807: fixed in xiphos 4.1.0.1+dfsg1-1
has caused the Debian Bug report #912807,
regarding xiphos: Depends on gconf
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
912807: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=912807
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: xiphos
Version: 4.0.7.1-5
Severity: important
User: [email protected]
Usertags: oldlibs gconf
Tags: sid buster patch
Your package depends and build-depends on gconf, but gconf will be
removed from Debian soon (most probably right after the Buster
release).
Furthermore, it seems that the dependency is completely unnecessary --
xiphos installs URL handlers but these keys are never read by GNOME as
this functionality has been deprecated long time ago. The right way
to achieve this is through .desktop/mime/aplication-registry files;
that would make them work under any XDG-compliant environment.
>From e5100b025039b2b850260eef832c67b5f6cae396 Mon Sep 17 00:00:00 2001
From: Yavor Doganov <[email protected]>
Date: Sat, 3 Nov 2018 23:56:19 +0200
Subject: [PATCH] Remove gconf dependency
---
debian/control | 1 -
debian/patches/0016-no-gconf.patch | 114 +++++++++++++++++++++++++++++
debian/patches/series | 1 +
3 files changed, 115 insertions(+), 1 deletion(-)
create mode 100644 debian/patches/0016-no-gconf.patch
diff --git a/debian/control b/debian/control
index fd65ca5..fd3d78b 100644
--- a/debian/control
+++ b/debian/control
@@ -14,7 +14,6 @@ Build-Depends: debhelper (>= 10),
intltool,
libbiblesync-dev,
libdbus-glib-1-dev,
- libgconf2-dev,
libgsf-1-dev,
libgtk-3-dev,
libsword-dev (>= 1.7.3),
diff --git a/debian/patches/0016-no-gconf.patch
b/debian/patches/0016-no-gconf.patch
new file mode 100644
index 0000000..79fa33a
--- /dev/null
+++ b/debian/patches/0016-no-gconf.patch
@@ -0,0 +1,114 @@
+Description: Remove gconf dependency.
+Author: Yavor Doganov <[email protected]>
+Forwarded: no
+Last-Update: 2018-11-03
+---
+
+--- xiphos.orig/wscript
++++ xiphos/wscript
+@@ -303,7 +303,6 @@
+
+ common_libs = string.join(
+ '''
+- "gconf-2.0"
+ "gmodule-2.0"
+ "glib-2.0"
+ "libgsf-1 >= 1.14"
+--- xiphos.orig/src/gui/gui.h
++++ xiphos/src/gui/gui.h
+@@ -4,13 +4,6 @@
+ void gui_init(int argc, char *argv[]);
+ void gui_main(void);
+
+-#ifndef WIN32
+-#include <gconf/gconf-client.h>
+-void gconf_setup(void);
+-#endif
+-
+-#define GS_GCONF_MAX 6
+-
+ #ifdef DEBUG
+
+ gchar *XI_g_strdup_printf(const char *filename,
+--- xiphos.orig/src/gnome2/gui.c
++++ xiphos/src/gnome2/gui.c
+@@ -68,9 +68,6 @@
+ if (!gtk_init_with_args(&argc, &argv, NULL, NULL, NULL, NULL)) {
+ exit(1);
+ };
+-#ifndef WIN32
+- gconf_setup();
+-#endif
+ #ifdef HAVE_DBUS
+ ipc = ipc_init_dbus_connection(ipc);
+ #endif
+@@ -81,69 +78,6 @@
+ gtk_main();
+ }
+
+-/******************************************************************************
+- * Name
+- * gconf_setup
+- *
+- * Synopsis
+- * #include "main/settings.h"
+- *
+- * void gconf_setup()
+- *
+- * Description
+- * verifies and initializes the GConf subsystem, so that "sword://" and
+- * similar can be handled by url-comprehending programs such as browsers.
+- * dialogs for permission/success/failure => conditional on debug build.
+- *
+- * Return value
+- * void
+- */
+-
+-/* NOTE: removed query for user permission to install handlers around -r4528.
*/
+-/* we don't ask any more, because there's no good reason not to take over.
*/
+-
+-char *gconf_keys[GS_GCONF_MAX][2] = {
+- {"/desktop/gnome/url-handlers/bible/command", "xiphos-nav \"%s\""},
+- {"/desktop/gnome/url-handlers/bible/enabled", (char *)1},
+- {"/desktop/gnome/url-handlers/bible/needs_terminal", (char *)0},
+- {"/desktop/gnome/url-handlers/sword/command", "xiphos-nav \"%s\""},
+- {"/desktop/gnome/url-handlers/sword/enabled", (char *)1},
+- {"/desktop/gnome/url-handlers/sword/needs_terminal", (char *)0}};
+-
+-#ifndef WIN32
+-void gconf_setup()
+-{
+- gchar *str;
+- GConfClient *client = gconf_client_get_default();
+-
+- if (client == NULL)
+- return; /* we're not running under GConf */
+-
+- /*
+- * This is deliberately somewhat simple-minded, at least for now.
+- * We care about one thing: Is anything set to handle "bible://"?
+- *
+- * Unfortunate consequence of changing xiphos2 => xiphos:
+- * We must fix broken keys.
+- */
+- if ((((str = gconf_client_get_string(client, gconf_keys[0][0],
+- NULL)) == NULL) ||
+- (strncmp(str, "xiphos ", 7) == 0))) {
+- /*
+- * Mechanical as can be, one after another.
+- */
+- int i;
+- for (i = 0; i < GS_GCONF_MAX; ++i) {
+- (((i % 3) == 0) /* contrived hack */
+- ? gconf_client_set_string(client,
gconf_keys[i][0], gconf_keys[i][1], NULL)
+- : gconf_client_set_bool(client,
+- gconf_keys[i][0],
+- (gconf_keys[i][1] ? TRUE :
FALSE), NULL));
+- }
+- }
+-}
+-#endif /* WIN32 */
+-
+ #ifdef DEBUG
+
+ /* NOTE: these routines are here only and exactly because there is no other */
diff --git a/debian/patches/series b/debian/patches/series
index bfc8b13..fbe2dd6 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -13,3 +13,4 @@ build-without-scrollkeeper.patch
0014-patch-source-for-webkit2.patch
0015-patch-source-for-webkit2.patch
0015-change-webkitgtk-3.0-to-webkit2gtk-4.0-in-configure.patch
+0016-no-gconf.patch
--
2.19.1
--- End Message ---
--- Begin Message ---
Source: xiphos
Source-Version: 4.1.0.1+dfsg1-1
We believe that the bug you reported is fixed in the latest version of
xiphos, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Teus Benschop <[email protected]> (supplier of updated xiphos package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Mon, 03 Dec 2018 15:43:40 +0100
Source: xiphos
Binary: xiphos xiphos-data
Architecture: source
Version: 4.1.0.1+dfsg1-1
Distribution: unstable
Urgency: medium
Maintainer: CrossWire Packaging Team
<[email protected]>
Changed-By: Teus Benschop <[email protected]>
Description:
xiphos - environment for Bible reading, study, and research
xiphos-data - data files for Xiphos Bible study software
Closes: 912807
Changes:
xiphos (4.1.0.1+dfsg1-1) unstable; urgency=medium
.
* fix hash size mismatch on upload
* thanks to Yavor Doganov for the gconf patch: Closes: #912807
Checksums-Sha1:
fc244f881c86914a32ad7144fd453053c1b69f09 2407 xiphos_4.1.0.1+dfsg1-1.dsc
bde3e871bca7ff45f313956100a51856b0076e88 8370988
xiphos_4.1.0.1+dfsg1.orig.tar.gz
84d6e1fc88ffda8ac4bf81dec90dd6e2d141248c 38868
xiphos_4.1.0.1+dfsg1-1.debian.tar.xz
386174972ca504863b9842ea89a3ee28fce83b9e 16667
xiphos_4.1.0.1+dfsg1-1_source.buildinfo
Checksums-Sha256:
565109678f949a5dfaad8f6b9c1de096b7d2eaeb0046acbca3c02c410c6bb388 2407
xiphos_4.1.0.1+dfsg1-1.dsc
4fd7af075b16051f53757aba28c6dd011748f47baf5d75c09f2c5157909bae52 8370988
xiphos_4.1.0.1+dfsg1.orig.tar.gz
f0cd9a894dce646dcd3de81e5020cfa2c931f3341a3eaf4f5990d79b0618fa8b 38868
xiphos_4.1.0.1+dfsg1-1.debian.tar.xz
810f04fbe66ea2958b5641c77cea2f53d6787ec4f19827c930f3ea7dcdd5de5e 16667
xiphos_4.1.0.1+dfsg1-1_source.buildinfo
Files:
0d4c07e01db5d0c0e1296b9b484354f0 2407 gnome optional xiphos_4.1.0.1+dfsg1-1.dsc
2a85024ba233087bcdcca94b1416b493 8370988 gnome optional
xiphos_4.1.0.1+dfsg1.orig.tar.gz
fd27db1034a4037ef611cb3955fb3b69 38868 gnome optional
xiphos_4.1.0.1+dfsg1-1.debian.tar.xz
e009da6f1f802543f9e8951c2ce033fd 16667 gnome optional
xiphos_4.1.0.1+dfsg1-1_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJLBAEBCgA1FiEEher+5c8s1QBza9jekwIrrQVjpR0FAlwFQd0XHHRldXNqYW5u
ZXR0ZUBnbWFpbC5jb20ACgkQkwIrrQVjpR3vaA/7BrYZXKmK+30PSMef56dGFRSw
xTzpbjMbus2qT3OH3DwZQ8kJcfurIjqIZEkxLJshXccsgkZt70W2oTgm+J16zuGi
dXxhKGwQaM4hH/5bNjqqup/467QkpsFkGPvuPdPoAMsp5ioZUIs0DtAczV6lAqm3
PoT3xGYMtnNVqts0vyQjrCCJrbcK8xi5Don2iLkhGAGEj6sISwbDwUrFzdlms8qo
5q86eTaa9Pd7gnjqvQs2Gos90H3xoRsuTabKBgfiuQvOeri+HSBWuI6oHmqDEkS8
tFyco3nv2UfZ1ehgISliBa+MMejFcxH6S85Xo/P91/woiecZ9TJk3/FjtAknzcNq
VlSvhZ/N/Iop6zL7nXyCgECd0338PUyGjiR/0dOQfvqtjwLGJQHNymQ09cl9ANde
3YPPzErydo5htV6x6TnSNYwBGTp8yvg/fVi2i90huO4YsG8DMRd6Zv5ZwKurtB1k
9lLQZz3/WM6NoAshqqHUtnHxYPVdbiVwvliN6WHGMTgsK0sccEqLhdn6NyPO4ILL
kEH9UFQ29u2kaAE8Ff56AigrjQ+BDE9On7eUkkw4uvDGX+x/LsiptyHyRQFfeQY0
UF/cBaWzne+lO385KpfreHANftgK/U4Z+A4dGh0SKuiKpQpichXE4KrAOKOPDzAf
oRQgia1mf0LSkSFDCTU=
=3M3Y
-----END PGP SIGNATURE-----
--- End Message ---
