Your message dated Wed, 12 Dec 2018 21:50:37 +0000
with message-id <[email protected]>
and subject line Bug#915263: fixed in montage 6.0+dfsg-4
has caused the Debian Bug report #915263,
regarding montage FTCBFS: insane build system
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
915263: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=915263
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: montage
Version: 6.0+dfsg-2
Tags: patch upstream
User: [email protected]
Usertags: rebootstrap
montage fails to cross build from source, because its build system is
insane. Part of that is already reported as #915163, but there are two
other aspects that stick:
* It tends to stuff compiler flags into the CC variable. When
dh_auto_build supplies CC, those flags get lost. It is much better to
store them in CFLAGS.
* While it uses $(CC) most of the time, it hard codes gcc in a few
places, so dh_auto_build has now way of substituting the compiler.
The attached patch fixes these aspects while still leaving the failure
propagation (#915163) as is. The patch makes montage cross build
successfully. In the presence of #915163, I cannot quite tell whether
that's enough. Please consider applying it.
Helmut
--- montage-6.0+dfsg.orig/lib/src/svc/Makefile
+++ montage-6.0+dfsg/lib/src/svc/Makefile
@@ -1,4 +1,4 @@
-CC = gcc -g -I. -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64
+CFLAGS = -g -I. -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64
libsvc.a: svclib.o structlib.o
ar rv libsvc.a svclib.o structlib.o
--- montage-6.0+dfsg.orig/lib/src/json/Makefile
+++ montage-6.0+dfsg/lib/src/json/Makefile
@@ -1,4 +1,4 @@
-CC = gcc -g -fPIC -I. -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64
+CFLAGS = -g -fPIC -I. -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64
libjson.a: jsonlib.o
ar rv libjson.a jsonlib.o
--- montage-6.0+dfsg.orig/MontageLib/Viewer/Makefile.LINUX
+++ montage-6.0+dfsg/MontageLib/Viewer/Makefile.LINUX
@@ -9,9 +9,9 @@
DATA_DIR = $(shell cd ../../data; pwd)
-CC = gcc -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -std=c99 -fPIC \
- -DFONT_DIR='"$(DATA_DIR)/fonts/"'
-CFLAGS += -I. -I.. -I../../lib/include -I../../lib/freetype/include \
+CFLAGS += -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -std=c99 -fPIC \
+ -DFONT_DIR='"$(DATA_DIR)/fonts/"' \
+ -I. -I.. -I../../lib/include -I../../lib/freetype/include \
-I../../lib/freetype/include/freetype2 -I../../Montage
LIBS = -L../../lib -lwcstools -lcoord -lcfitsio -ljpeg -llodepng -lmtbl -ljson -lcmd \
-L../../lib/freetype/lib -lfreetype -lm
@@ -20,7 +20,7 @@
$(CC) $(CFLAGS) $(CPPFLAGS) -c $*.c
mViewer: mViewer.o montageViewer.o mViewer_graphics.o mViewer_grid.o
- $(CC) -o mViewer mViewer.o montageViewer.o mViewer_graphics.o mViewer_grid.o \
+ $(CC) $(CFLAGS) -o mViewer mViewer.o montageViewer.o mViewer_graphics.o mViewer_grid.o \
../util/checkHdr.o \
../util/checkWCS.o \
$(LIBS)
--- montage-6.0+dfsg.orig/MontageLib/Makefile
+++ montage-6.0+dfsg/MontageLib/Makefile
@@ -93,7 +93,7 @@
FitExec/montageFitExec.o \
DiffFitExec/montageDiffFitExec.o \
ProjExec/montageProjExec.o
- -gcc -shared $(SO_FLAG) -o libmontage.so \
+ -$(CC) -shared $(SO_FLAG) -o libmontage.so \
util/checkFile.o util/checkHdr.o util/checkWCS.o \
util/debugCheck.o util/filePath.o \
Add/montageAdd.o \
--- montage-6.0+dfsg.orig/ancillary/Makefile
+++ montage-6.0+dfsg/ancillary/Makefile
@@ -1,8 +1,8 @@
HPXcvt: HPXcvt.o
- gcc -std=gnu99 -o HPXcvt HPXcvt.o -L../lib -lcfitsio -lm
+ $(CC) -std=gnu99 -o HPXcvt HPXcvt.o -L../lib -lcfitsio -lm
HPXcvt.o: HPXcvt.c
- gcc -std=gnu99 -g -O2 -I../lib/include -c -o HPXcvt.o HPXcvt.c
+ $(CC) -std=gnu99 -g -O2 -I../lib/include -c -o HPXcvt.o HPXcvt.c
install:
cp HPXcvt ../bin
--- End Message ---
--- Begin Message ---
Source: montage
Source-Version: 6.0+dfsg-4
We believe that the bug you reported is fixed in the latest version of
montage, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Ole Streicher <[email protected]> (supplier of updated montage package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Wed, 12 Dec 2018 22:22:52 +0100
Source: montage
Binary: montage montage-gridtools
Architecture: source
Version: 6.0+dfsg-4
Distribution: unstable
Urgency: medium
Maintainer: Debian Astro Team <[email protected]>
Changed-By: Ole Streicher <[email protected]>
Description:
montage - Toolkit for assembling FITS images into mosaics
montage-gridtools - Create files to run montage on the grid
Closes: 915263
Changes:
montage (6.0+dfsg-4) unstable; urgency=medium
.
* Drop outdated closefitsfile patch
* Fix more CC/CFLAGS propagation issues, provided by Helmut Grone
(Closes: #915263)
* Initialize mxcntr in montageBgExec. Should fix CI failures of
montage-wrapper.
Checksums-Sha1:
20c04de8571c02aa194ac50684fbc0245a3eadc1 2113 montage_6.0+dfsg-4.dsc
6f99bcb5c3d2be048c7941aea658c9975d0efbe8 52484 montage_6.0+dfsg-4.debian.tar.xz
Checksums-Sha256:
0dee2706e82ba0fa9eb9ec254b700589804a4c517b608270c8e930792e774460 2113
montage_6.0+dfsg-4.dsc
8248c4dd9b324a119c4e97b11a30f019fdcb04a1c1edfe0b54ee219a9d0f2582 52484
montage_6.0+dfsg-4.debian.tar.xz
Files:
fe70be970573382fb3ff4c38f51c0a0a 2113 science optional montage_6.0+dfsg-4.dsc
a40706cf8fb6a4c45107d43137864503 52484 science optional
montage_6.0+dfsg-4.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEuvxshffLFD/utvsVcRWv0HcQ3PcFAlwRfScACgkQcRWv0HcQ
3PfZSRAApCuBCaiCj1UuHecUhyvk1vW//BnhidcR8PnKAP4kFcXqY/bkNXd2q28j
7xri1g607Fd3c2TbI44WPM5VWEX9vmijCpo7JG7Kxjh2XHWwl15rZ4ETxsjarC8m
jL1YV3LcMMgu/2t0t6VKB44RB8jr98XN9B4h19VMgl1ZS7B1KTPdQo4xW4B0yELk
Tn/9wfPrvO2dsYvtD+qj01sFRIxImoL7mEzdCbj2xhMAjsF3VsU+Ys9bKC43ufF4
U++xXJv7lDwA/e+jl6MS+hJa4hXzxJzUR/+KTXPbVjjMUBeMhdJsVlUsHAwat8lQ
bReUr7Dx3hjexRLDyvqhqYvb/W8hoqkKSFe+D8RrlXADTi+pAuf5+6tkWjPgRabq
ZOCg6jDPQV8Oq0CmfBN4ozZHN6O4TKvjEyRP5JKmt+YbGRZLbBPL9B7w7mZbdPCH
p9qzdtkshthkDo8Dge/XiaR/kpZ9idhuHf/BXEFjNG2rqU2IGATUem9c9wcuP5yI
FZBVjknB51D4x2RQ4jfJ0Tgsp3wYSSfv1R8r4+ljeoHjBYSDNxg8tyffv6bHAfTP
4qS1x631tAm/qZr2swNus53qvghSte0pAzWIt2Bam3qtt3Fq3J/oy7yTg5WfGTyZ
9HekCc1vRBZ/r4VLvdNfeoxwnZFB3AO7z6Al7NofdywqUH6jw/A=
=SLd2
-----END PGP SIGNATURE-----
--- End Message ---
