Your message dated Thu, 20 Dec 2018 15:56:08 +0100
with message-id <[email protected]>
and subject line buildbot: bashism in /bin/sh script
has caused the Debian Bug report #690624,
regarding buildbot: bashism in /bin/sh script
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
690624: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=690624
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: buildbot
Version: 0.8.6p1-1
Severity: important
User: [email protected]
Usertags: goal-dash
Hello maintainer,
While performing an archive wide checkbashisms (from the 'devscripts'
package) check I've found your package containing a /bin/sh script making
use of a bashism.
checkbashisms' output:
>possible bashism in ./etc/default/buildmaster line 7 (bash arrays, H[0]):
>MASTER_ENABLED[1]=0 # 1-enabled, 0-disabled
>possible bashism in ./etc/default/buildmaster line 8 (bash arrays, H[0]):
>MASTER_NAME[1]="buildmaster #1" # short name printed on start/stop
>possible bashism in ./etc/default/buildmaster line 9 (bash arrays, H[0]):
>MASTER_USER[1]="buildbot" # user to run master as
>possible bashism in ./etc/default/buildmaster line 10 (bash arrays, H[0]):
>MASTER_BASEDIR[1]="" # basedir to master (absolute path)
>possible bashism in ./etc/default/buildmaster line 11 (bash arrays, H[0]):
>MASTER_OPTIONS[1]="" # buildbot options
>possible bashism in ./etc/default/buildmaster line 12 (bash arrays, H[0]):
>MASTER_PREFIXCMD[1]="" # prefix command, i.e. nice, linux32,
dchroot
Not using bash (or a Debian Policy conformant shell interpreter which
doesn't provide such an extra feature) as /bin/sh is likely to lead to
errors or unexpected behaviours.
You can find hints about how to fix bashisms at:
https://wiki.ubuntu.com/DashAsBinSh
Thank you,
Raphael Geissert
--- End Message ---
--- Begin Message ---
Package: buildbot
Version: 1.1.1-3
Hi,
I added the correct #!/bin/bash shebang into /etc/init.d/buildmaster and
/etc/init.d/buildbot-worker.
I know depending on bash is not ideal but I don't feel like re-writing
these scripts. Now that the default init system of Debian is systemd, I
was hoping for people to transition to the new services which I added
into 1.1.1-3 as well.
I might need to write some docs on how to use them however. For now, the
only use is in the smoke tests:
https://salsa.debian.org/python-team/applications/buildbot/blob/debian/master/debian/tests/smoke
This may be a good starting point.
--
Robin
--- End Message ---
