Your message dated Tue, 25 Dec 2018 17:10:02 +0100
with message-id <[email protected]>
and subject line Re: [debian-mysql] Bug#915046: mariadb-10.3: Please build with 
-latomic where necessary
has caused the Debian Bug report #915046,
regarding mariadb-10.3: Please build with -latomic where necessary
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
915046: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=915046
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: mariadb-10.3
Version: 1:10.1.37-1
Severity: normal
User: [email protected]
Usertags: powerpc

Hello!

On some 32-bit targets like mips or powerpc, the mariabdb-10.3 build fails
with:

 error: #error atomic ops for this platform are not implemented

This is because the test for C++11 atomics in configure.cmake fails:

CHECK_CXX_SOURCE_COMPILES("
 int main()
 {
  long long int var= 1;
  long long int *ptr= &var;
  return (int)__atomic_load_n(ptr, __ATOMIC_SEQ_CST);
 }"
HAVE_GCC_C11_ATOMICS)

Trying to build this code on ppc64 works fine:

glaubitz@redpanda:~/mariadb$ g++ cpp11test.cpp -o cpp11test
glaubitz@redpanda:~/mariadb$ ./cpp11test

On powerpc, we need -latomic otherwise the compilation fails
and HAVE_GCC_C11_ATOMICS is set to false:

root@kapitsa:~# g++ cpp11test.cpp -o cpp11test
/usr/bin/ld: /tmp/ccyivhlO.o: in function `main':
cpp11test.cpp:(.text+0x48): undefined reference to `__atomic_load_8'
collect2: error: ld returned 1 exit status
root@kapitsa:~#

root@kapitsa:~# g++ cpp11test.cpp -o cpp11test -latomic
root@kapitsa:~#

I have no idea, however, how to tell cmake here to pass -latomic, I'm
not a cmake expert.

Adrian

--
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - [email protected]
`. `'   Freie Universitaet Berlin - [email protected]
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

--- End Message ---
--- Begin Message ---
Hi!

On 12/23/18 12:51 PM, John Paul Adrian Glaubitz wrote:
> Tomorrow or the day after tomorrow. I need to rest a bit today
> and take care of the chores. It shouldn't take long to rebase
> the patch.

I just saw that upstream has reworked and simplified my patch and you
already cherry-picked that patch which fixes the problem.

Less work for me :-). Closing this bug as the issue has been fixed now.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - [email protected]
`. `'   Freie Universitaet Berlin - [email protected]
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

--- End Message ---

Reply via email to