Your message dated Mon, 31 Dec 2018 00:12:07 +0100 with message-id <[email protected]> and subject line Re: Bug#917828: Enable `issue_discards` per default has caused the Debian Bug report #917828, regarding Enable `issue_discards` per default to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 917828: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=917828 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: lvm2 Version: 2.03.02-1 Severity: normal Hello, in order to have TRIM (discard) support enabled per default for SSD devices, the `issue_discards` setting in `/etc/lvm/lvm.conf` should be active (`1`) per default. To give some context: since recently, the debian-installer adds the `discard` option per default for luks-encrypted dm-crypt devices[1]. We'll adopt documentation in the cryptsetup package accordingly. With this change, the `issue_discards` option in lvm2 is the last missing piece to enable TRIM for SSD/flash devices per default in Debian. Since enabling discard doesn't have any impact for non-SSD devices, it should be safe to change the default. Or do I oversee any potential downsides? I think it would be great to have Debian Buster released with TRIM (discard) support enabled per default. Cheers, jonas [1] https://salsa.debian.org/installer-team/partman-crypto/merge_requests/2
--- End Message ---
--- Begin Message ---On Sun, Dec 30, 2018 at 08:19:49PM +0100, Jonas Meurer wrote: > in order to have TRIM (discard) support enabled per default for SSD > devices, the `issue_discards` setting in `/etc/lvm/lvm.conf` should > be active (`1`) per default. No, issue_discards only affects what the lvm tools do. This is stated clearly in the documentation: # Issue discards to PVs that are no longer used by an LV. # Discards are sent to an LV's underlying physical volumes when the LV # is no longer using the physical volumes' space, e.g. lvremove, # lvreduce. Discards inform the storage that a region is no longer # used. Storage that supports discards advertise the protocol-specific # way discards should be issued by the kernel (TRIM, UNMAP, or # WRITE SAME with UNMAP bit set). Not all storage will support or # benefit from discards, but SSDs and thinly provisioned LUNs # generally do. If enabled, discards will only be issued if both the # storage and kernel provide support. It however does _not_ take any effects on what the kernel does on a file system. Bastian -- Lots of people drink from the wrong bottle sometimes. -- Edith Keeler, "The City on the Edge of Forever", stardate unknown
--- End Message ---
