Your message dated Fri, 4 Jan 2019 00:37:32 +0100
with message-id <[email protected]>
and subject line Re: Bug#918168: http_loadtime autoconf checks for time(1) 
incorrectly
has caused the Debian Bug report #918168,
regarding http_loadtime autoconf checks for time(1) incorrectly
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
918168: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=918168
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: munin-plugins-core
Version: 2.0.25-1+deb8u3, 2.0.33-1

Hi,

The http_loadtime plugin does:

time_bin=`which time`

    command -v $time_bin 2>&1 >/dev/null || result=1

But if you don't have the time package installed, $time_bin is nothing, and
command -v with no argument returns 0.

It has to be quoted for command -v to return 1.

Obviously some sort of a package dependency on the time package would be
appreciated, too.

Without this, it is enabled and it crashes with a syntax error.

Please fix it. TIA.

-- 
     2. That which causes joy or happiness.

--- End Message ---
--- Begin Message ---
Control: fixed -1 2.0.37-1


Hello Josip,


thank you for your report!


Am Thu, 3 Jan 2019 23:15:21 +0100
schrieb Josip Rodin <[email protected]>:

> The http_loadtime plugin does:
> 
> time_bin=`which time`
> 
>     command -v $time_bin 2>&1 >/dev/null || result=1
> 
> But if you don't have the time package installed, $time_bin is nothing, and
> command -v with no argument returns 0.

Indeed, this is a problem.
It is fixed upstream in munin v2.0.35.


> Obviously some sort of a package dependency on the time package would be
> appreciated, too.

Yes, indeed.
Since the upstream fix removes the usage of "time", this dependency is not
necessary anymore.

Thank you!

Cheers,
Lars

--- End Message ---

Reply via email to