Your message dated Sat, 05 Jan 2019 11:34:34 +0000 with message-id <[email protected]> and subject line Bug#822674: fixed in sysvinit 2.93-3 has caused the Debian Bug report #822674, regarding sysvinit-utils: /lib/init/init-d-script do_status() probably needs to specify -p $PIDFILE to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 822674: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=822674 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: sysvinit-utils Version: 2.88dsf-59.3 Severity: normal I am troubleshooting a problem with the courier package suite (courier-imap as example). I found that in /lib/init/init-d-script, the do_status() function calls status_of_proc() without the -p argument, leaving the PIDFILE to be assumed by pidofproc. This, despite the case that init-d-script makes it's own assumption and declaration about what the daemon PIDFILE should be. In any case where the PIDFILE declared in the init script is different from what pidofproc assumes it to be, failure occurs because the assumed PIDFILE does not exist. I would suggest altering the do_status() func from: status_of_proc "$DAEMON" "$NAME" && return 0 || return $? To: status_of_proc "$DAEMON" "$NAME" -p "$PIDFILE" && return 0 || return $? While I'm at it, I don't understand the functionality of "&& return 0 || return $?". This could be removed and there would be no change in behavior. Is this an artifact of history? In that case: status_of_proc "$DAEMON" "$NAME" -p "$PIDFILE" My one concern is regarding the possibility of PIDFILE=none being set in the init script. If it's necessary (I can't think of a reason why) to maintain the current behavior of not feeding the -p argument to status_of_proc, we could do: status_of_proc "$DAEMON" "$NAME" ${PIDFILE:="-p $PIDFILE"} && return 0 || return $? However, if there is no PIDFILE set, a more rational thing to do would seem to be to never run status_of_proc in the first place since you can't get status on something that isn't running (or didn't leave a PID file behind). -- System Information: Debian Release: stretch/sid APT prefers unstable APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable') Architecture: amd64 (x86_64) Kernel: Linux 4.3.0-1-amd64 (SMP w/2 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: sysvinit (via /sbin/init) Versions of packages sysvinit-utils depends on: ii init-system-helpers 1.29 ii libc6 2.22-7 ii startpar 0.59-3 sysvinit-utils recommends no packages. Versions of packages sysvinit-utils suggests: pn bootlogd <none> pn sash <none> -- no debconf information
--- End Message ---
--- Begin Message ---Source: sysvinit Source-Version: 2.93-3 We believe that the bug you reported is fixed in the latest version of sysvinit, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Dmitry Bogatov <[email protected]> (supplier of updated sysvinit package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Sat, 05 Jan 2019 11:21:53 +0000 Source: sysvinit Binary: sysvinit-core sysvinit-utils sysv-rc initscripts bootlogd Architecture: source Version: 2.93-3 Distribution: unstable Urgency: medium Maintainer: Debian sysvinit maintainers <[email protected]> Changed-By: Dmitry Bogatov <[email protected]> Description: bootlogd - daemon to log boot messages initscripts - scripts for initializing and shutting down the system sysv-rc - System-V-like runlevel change mechanism sysvinit-core - System-V-like init utilities sysvinit-utils - System-V-like utilities Closes: 132542 504748 686895 743743 746221 814735 822674 825975 910289 915051 917139 917419 Changes: sysvinit (2.93-3) unstable; urgency=medium . * Make initscripts gracefully handle missing logsave(8) (Closes: #910289) * Correctly umount block devices, mounted under /run (Closes: #917139) * Remove obsolete `/etc/init.d/motd' (Closes: #915051) * Update path to `nologin' file in `bootmisc.sh' script (Closes: #743743) * Fix mounting of /proc on Hurd (Closes: #814735) * Fix /sbin/poweroff alternative on Hurd (Closes: #825975) * Use forced fsck in mountroot.sh only if it is supported (Closes: #686895) * Simplify call to ischroot(1) in `sysvinit-core.postinst' * Update Dutch translation of debconf templates (Closes: #917419) + Thanks: Frans Spiesschaert <[email protected]> * Move /etc/init.d/{rc,rcS} scripts out of /etc, retaining symbolic link for compatibility (Closes: #132542) * Do not mount gfs, ocfs2 and gfs2 in mountall.sh script (Closes: #504748) * Specify pidfile option to `status_of_proc' function in `init-d-script' (Closes: #822674) * Add initscript to save and restore backlight brightness (Closes: #746221) Checksums-Sha1: f4a004a79f610deb4b80dac6bd83bc59dec1a2b9 2769 sysvinit_2.93-3.dsc 2e53040b3dc573b23810ca4fc127f99f93d4f786 129992 sysvinit_2.93-3.debian.tar.xz Checksums-Sha256: 543ae74847cf20cb49b33e28bf0e98b7cc2a79dc83f3242d28d4e4eabb42767c 2769 sysvinit_2.93-3.dsc 06f07af8bd30f5d157de04134c18ade917b391f36b4051a98bb45f887c0da719 129992 sysvinit_2.93-3.debian.tar.xz Files: b89801154b51e5ebba7352e913d86515 2769 admin optional sysvinit_2.93-3.dsc 482486bb9e410f3d3a689b2f2430c001 129992 admin optional sysvinit_2.93-3.debian.tar.xz -----BEGIN PGP SIGNATURE----- iQJHBAEBCgAxFiEEhnHVzDbtdH7ktKj4SBLY3qgmEeYFAlwwk6oTHGthY3Rpb25A ZGViaWFuLm9yZwAKCRBIEtjeqCYR5syTD/0UF8ViYXeHTlkS/K0kgxjgCpo47V7I zc9aBg1VaLxJ2wEhriqf/805OI+OuEG+jyxTrqfoUWrjnu9s8NtrHOR2whpmFbbM fNHWUE96WQJgQ9tiDUkb484JfFv5Ud66WGmL3JOXMgXker3FOuB9+Eh2r5gyMJU9 uAI70FxSWzhz4PSrJuO6A1GItQoOqwbsm5StZW1BKUcodgP1uzpmozjrrN9o7d07 K3yscDV29EeDKv+MFLiKU36hom0NDrfeg41DcZwQIjLbNew5002jotX1ag00jO0S 2uIer4yFgFkdsRfGQnrn5G2mqcabH+W+PFX0Q1m9JMtgN+wzBTkQFWs1ELATpEwQ SEYcH7Cr0q77tZ5HJ+ubUaqKE7uf+IkEkhZPWZ2Bb8u7viOnaTiKTkSxAkDXBT2j RKMrMkDpKeemN9ybDdaJ7R5Okrq+i0uM/8/1quMzdzBOZ08jF1o1AflUksnOtc4m 0wqapCsrzZA3puARh9JP8I632RoPE+pkEVUEJtLJXu+xEXBOOGi34W/uEMXkXI6N 97YaXx57vZbpphsfBMba/9lyr52KB5k3/VXeVgp2OGcATzBiQ+3uDIUexaUkUQz+ lFRIYrADXN9O4Jaq0V/9ATys6LluEGDIWyMzeklVra04wn2vI5HHBbFN10FpCbQz /8TXAAlcndXFnw== =xa6w -----END PGP SIGNATURE-----
--- End Message ---
