Your message dated Sun, 10 Feb 2019 20:45:55 +0000 with message-id <[email protected]> and subject line Bug#919853: fixed in debhelper 12.1 has caused the Debian Bug report #919853, regarding debhelper: should strip lead/trail white space when parsing a list of filenames to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 919853: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=919853 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: debhelper Version: 12 Severity: normal Tags: patch When parsing a list of filenames from a config file, Debhelper should strip leading/trailing white space from each input line before deciding whether to skip that line. The current function ‘Debian::Debhelper::Dh_Lib::filedoublearray’ begins processing each input line with this code fragment:: # … while (<DH_FARRAY_IN>) { chomp; if (not $x) { next if /^#/ || /^$/; } # … That fails when there is leading/trailing white space on the input line (such as a separator line containing only the white space character U+000C; or a comment line with leading white space). The resulting input line is not empty (it still contains leading and/or trailing white space), so it matches neither of the regex patterns in the conditional. So the function attempts to parse meaningful content from it; but the line is semantically empty, so that fails. The return value does not contain a filename, which leads to hard-to-understand errors later in execution:: Use of uninitialized value $fn in substitution (s///) at /usr/share/perl5/Debian/Debhelper/Dh_Lib.pm line 780. Use of uninitialized value $fn in substitution (s///) at /usr/share/perl5/Debian/Debhelper/Dh_Lib.pm line 781. Use of uninitialized value in concatenation (.) or string at /usr/bin/dh_bash-completion line 67. Use of uninitialized value $name in concatenation (.) or string at /usr/bin/dh_bash-completion line 67. Instead, the ‘Debian::Debhelper::Dh_Lib::filedoublearray’ function should strip leading/trailing white space from each input line, and only then decude whether to skip the input line:: # … while (<DH_FARRAY_IN>) { chomp; s/^\s+|\s+$//g; if (not $x) { next if /^#/ || /^$/; } # … -- \ “Kissing a smoker is like licking an ashtray.” —anonymous | `\ | _o__) | Ben Finney
--- End Message ---
--- Begin Message ---Source: debhelper Source-Version: 12.1 We believe that the bug you reported is fixed in the latest version of debhelper, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Niels Thykier <[email protected]> (supplier of updated debhelper package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Sun, 10 Feb 2019 20:33:53 +0000 Source: debhelper Architecture: source Version: 12.1 Distribution: unstable Urgency: medium Maintainer: Debhelper Maintainers <[email protected]> Changed-By: Niels Thykier <[email protected]> Closes: 917362 918066 919853 921254 Changes: debhelper (12.1) unstable; urgency=medium . [ Xavier Guimard ] * dh_fixperms: add .node in mode_0644_patterns. . [ Sylvestre Ledru ] * dh_strip: Print a warning when an ELF binary does not have a build-id (or when dh_strip cannot find it). . [ Niels Thykier ] * Dh_Lib.pm: Strip leading and trailing whitespace from lines in regular debhelper config files. Whitespace-only lines from executable config files are now explicitly detected and triggers a human readable error message early rather than warnings/errors about uninitialized variables. Thanks to Ben Finney for the suggestion and the initial patch. (Closes: #919853) * meson.pm: Dump "meson-logs/testlog.txt" if testing fails with an error. Thanks to Jeremy Bicha for the suggestion. (Closes: #918066) * dh_missing: Clarify the documentation about when -X with other helpers can may dh_missing ignore paths that are not installed. Thanks to Hilko Bengen for reporting the original documentation was unsufficient. (Closes: #917362) * d/control: Bump Standards-Version to 4.3.0 - no changes required. . [ Baptiste Jammet ] * fr.po: Update French translation. (Closes: #921254) Checksums-Sha1: 7575cab473a56568770ac07f811cb3230e3ed21a 1681 debhelper_12.1.dsc aa2eee5772eb0d82cf8a5ea6e64de51084c5b5ad 483568 debhelper_12.1.tar.xz 6cd000bdb36194b786f81657d37b24841bc42829 4417 debhelper_12.1_source.buildinfo Checksums-Sha256: a8e5e9363206ad92d0e5d5bc77ca2bbf790d99f7d3a6324a10cfbbe1131adb24 1681 debhelper_12.1.dsc 3384699a0fa54c46a7f063fa6c649656e2891981057931dfe470bee555762527 483568 debhelper_12.1.tar.xz 8a7c64b27cac8bfc90637724683f491980e5a16a0a046bfa2030949aed655415 4417 debhelper_12.1_source.buildinfo Files: 0efae277b5d6a7db5a05fc1bcf0e70fd 1681 devel optional debhelper_12.1.dsc 216b1ec2f1c2552c54ed8f52f53931dc 483568 devel optional debhelper_12.1.tar.xz c3a2c8359ff3e2727a28c70a0db8be82 4417 devel optional debhelper_12.1_source.buildinfo -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE8f9dDX4ALfD+VfsMplt42+Z8eqwFAlxgi2wACgkQplt42+Z8 eqxxCg/9G5Yh5lIT7zQiHf+TSVtx7lPOZKhziINkL5rNEw3jzsNnGKhi37DrjMPH MUozlTym9MclToKaTQGOemoaCEHkF39Lhixx7S6PhgtTkU81CghNJWgH4/nDno+c +LXwNRbiymfo1Sknat7pmZEJaHS10kEpzWQ8n/A6qhtF+TppWyb70s+2pQ/H76Jt 8MDgV1vdiFfLyoYT/LpqaO0hdbgPmY3ULEyhLjU/BvFZxOAYPyVpZZnDOuuBavHt IPRFqmSNKhKkZwzgyaqghVm8Y8nfieidf/jLIAnfaZAe3qbIUJooV9M2JniZnQIE t/wMIrKICu5D52KNd5FLjlqWgipq9xTtU6heyCzSM2NaUSOdOqYrAmY7NrS6wpgP bJzQfJjC6Wb9jbVwHWlDzwgQiU+zbX+OsGNSCO+IuJ38FqA/t16gguRU2/4GsY8d NriMyxq3OKDBeT8nae9igtR1sBisXfmkKZ3h8J7Qjx/cXKWnFtz8flpQGVpaPUng R8+QI6fAMzJpqIvbJpHZ2bF1inNnSEUB+wxiebwHXXINv20Iy1UJzLULJ/Op3GOl pOk6PrR1bn9n/1HDWSXBT6JRUyMKktQanPlmEz0i7OV9NQpAEIN/0I78I9ra24+H 13TFfkQxyVN3BlzAWOBjsXc5nuvglw8W6ZdHidhg7VfkaWvX+v8= =aUNn -----END PGP SIGNATURE-----
--- End Message ---
