Your message dated Thu, 14 Feb 2019 10:49:39 +0000
with message-id <[email protected]>
and subject line Bug#920468: fixed in node-libnpx 10.2.0+repack-1
has caused the Debian Bug report #920468,
regarding node-libnpx accesses the network at build-time
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
920468: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=920468
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: node-libnpx
Version: 10.2.0-2
Severity: important
Tags: patch
User: [email protected]
Usertags: origin-ubuntu disco ubuntu-patch
Dear Pirate,
In Ubuntu, the node-libnpx has failed to build because it tries to access
the network in order to download test dependencies:
[...]
# Subtest: test/index.js
# Subtest: npx --always-spawn
not ok 1 - Command failed: node /<<PKGBUILDDIR>>/test/util/npx-bin.js
--always-spawn echo-cli hewwo
---
stack: |
ChildProcess.child.on.code (child.js:41:21)
at:
line: 41
column: 21
file: child.js
function: ChildProcess.child.on.code
isOperational: true
stderr: >
npm ERR! code ENOTFOUND
npm ERR! errno ENOTFOUND
npm ERR! network request to https://registry.npmjs.org/echo-cli
failed,
reason: getaddrinfo ENOTFOUND registry.npmjs.org
registry.npmjs.org:443
npm ERR! network This is a problem related to network connectivity.
[...]
# Subtest: npx with custom installer stdio
not ok 1 - Command failed: node
/<<PKGBUILDDIR>>/test/util/npx-bin-inherit-stdio.js [email protected]
---
stack: |
ChildProcess.child.on.code (child.js:41:21)
at:
line: 41
column: 21
file: child.js
function: ChildProcess.child.on.code
isOperational: true
stderr: >
npm ERR! code ENOTFOUND
npm ERR! errno ENOTFOUND
npm ERR! network request to https://registry.npmjs.org/say-shalom
failed,
reason: getaddrinfo ENOTFOUND registry.npmjs.org
registry.npmjs.org:443
npm ERR! network This is a problem related to network connectivity.
[...]
(https://launchpad.net/ubuntu/+source/node-libnpx/10.2.0-2/+build/15638838)
Packages should not be accessing sites on the Internet at build time. Since
I can't find either echo-cli or say-shalom as a package in Debian, I think
the right solution here is to disable these tests.
Please find attached a patch which does this. I have uploaded this patch to
Ubuntu.
Regards,
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer https://www.debian.org/
[email protected] [email protected]
diff -Nru node-libnpx-10.2.0/debian/patches/disable-network-test.patch
node-libnpx-10.2.0/debian/patches/disable-network-test.patch
--- node-libnpx-10.2.0/debian/patches/disable-network-test.patch
1969-12-31 16:00:00.000000000 -0800
+++ node-libnpx-10.2.0/debian/patches/disable-network-test.patch
2019-01-25 14:26:43.000000000 -0800
@@ -0,0 +1,73 @@
+Description: Disable tests that require network access
+ Tests in this package require access to https://registry.npmjs.org/echo-cli
+ and https://registry.npmjs.org/say-shalom at build time. Disable these
+ tests, since NPM is inaccessible at build time per policy.
+Author: Steve Langasek <[email protected]>
+Last-Modified: 2018-01-25
+
+Index: node-libnpx-10.2.0/test/index.js
+===================================================================
+--- node-libnpx-10.2.0.orig/test/index.js
++++ node-libnpx-10.2.0/test/index.js
+@@ -16,39 +16,6 @@
+
+ const NPX_ESC = isWindows ? child.escapeArg(NPX_PATH) : NPX_PATH
+
+-test('npx --always-spawn', t => {
+- return child.spawn('node', [
+- NPX_ESC, '--always-spawn', 'echo-cli', 'hewwo'
+- ], {stdio: 'pipe'}).then(res => {
+- t.equal(res.stdout.trim(), 'hewwo')
+- })
+-})
+-
+-test('npx --always-spawn resolves promise after command is executed', t => {
+- const _runCommand = child.runCommand
+- const parsed = main.parseArgs([
+- process.argv[0],
+- '[fake arg]',
+- '--always-spawn',
+- 'echo-cli',
+- 'hewwo'
+- ], NPM_PATH)
+- child.runCommand = (command, opts) => {
+- child.runCommand = _runCommand
+- return Promise.resolve([command, opts])
+- }
+- return main(parsed)
+- .then(args => {
+- const command = args[0]
+- const opts = args[1]
+- t.ok(command.includes('node'), 'node executes the command')
+- t.equal(opts.alwaysSpawn, true, 'set opts.alwaysSpawn')
+- t.equal(opts.command, 'echo-cli', 'set opts.command')
+- t.ok(opts.cmdOpts[0].includes('echo-cli'), 'set opts.cmdOpts[0]')
+- t.equal(opts.cmdOpts[1], 'hewwo', 'set opts.cmdOpts[1]')
+- })
+-})
+-
+ test('npx --shell-auto-fallback', t => {
+ return child.spawn('node', [
+ NPX_ESC, '--shell-auto-fallback', 'zsh'
+@@ -293,21 +260,6 @@
+ })
+ })
+
+-test('npx with custom installer stdio', t => {
+- const NPX_PATH = path.resolve(__dirname, 'util', 'npx-bin-inherit-stdio.js')
+- const NPX_ESC = isWindows ? child.escapeArg(NPX_PATH) : NPX_PATH
+-
+- return child.spawn('node', [
+- NPX_ESC, '[email protected]'
+- ], {stdio: 'pipe'}).then(res => {
+- t.equal(res.code, 0, 'command succeeded')
+- t.match(
+- res.stdout.toString(), /"added":/, 'installer output printed directly
to console'
+- )
+- t.end()
+- })
+-})
+-
+ test('noisy npx with --quiet arg on windows', {
+ skip: !isWindows && 'Only on Windows does the path to the downloaded module
get printed'
+ }, t => {
diff -Nru node-libnpx-10.2.0/debian/patches/series
node-libnpx-10.2.0/debian/patches/series
--- node-libnpx-10.2.0/debian/patches/series 2018-10-16 06:40:45.000000000
-0700
+++ node-libnpx-10.2.0/debian/patches/series 2019-01-25 14:26:53.000000000
-0800
@@ -1,2 +1,3 @@
disable-which-test.patch
disable-dotenv-test.patch
+disable-network-test.patch
--- End Message ---
--- Begin Message ---
Source: node-libnpx
Source-Version: 10.2.0+repack-1
We believe that the bug you reported is fixed in the latest version of
node-libnpx, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Xavier Guimard <[email protected]> (supplier of updated node-libnpx package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Thu, 14 Feb 2019 11:13:16 +0100
Source: node-libnpx
Binary: node-libnpx
Architecture: source
Version: 10.2.0+repack-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Javascript Maintainers
<[email protected]>
Changed-By: Xavier Guimard <[email protected]>
Closes: 920468 921796
Description:
node-libnpx - support library for npx
Changes:
node-libnpx (10.2.0+repack-1) unstable; urgency=medium
.
* Team upload
* Repack to embed components
* Add upstream/metadata
* Add debianutils in build dependencies
* Switch test to pkg-js-autopkgtest
* Fix install
* Fix tests (Closes: #921796)
* Add patch desc
* Remove unneeded dependency versions
* Fix copyrights
* Disable network access during build. Thanks to Steve Langasek
(Closes: #920468)
Checksums-Sha1:
dea013babc2e1b1830b6591900719eb154771c0e 2914 node-libnpx_10.2.0+repack-1.dsc
a5317459bd3d79ab88cff6e44057a6a3fbb1fcef 7306
node-libnpx_10.2.0+repack.orig-dotenv.tar.gz
d0744593e13f161e406acb1d9408b72cad08aff6 5599
node-libnpx_10.2.0+repack.orig-update-notifier.tar.gz
b5136122e6c99389126a55209278ac79241b09ae 107118
node-libnpx_10.2.0+repack.orig.tar.gz
acf0f876acd767b4810f81f069f7ad5be2e76422 5940
node-libnpx_10.2.0+repack-1.debian.tar.xz
Checksums-Sha256:
d515d8d9927ce90fdafc5b84264f8b64e9c7f24519ff9ebd18f5c171f8683863 2914
node-libnpx_10.2.0+repack-1.dsc
fd77c9411a4d52efb09c50a5aeccba4ecc07434331476cbb979bcac13bce8607 7306
node-libnpx_10.2.0+repack.orig-dotenv.tar.gz
d706e4219e90468cdb42e3cde25399b4fe320fec74c874040c2fe83950c1da51 5599
node-libnpx_10.2.0+repack.orig-update-notifier.tar.gz
8d07934213b6545d14ca3312a7c20da40a25dc8c97ee8b7c44759d82c074e051 107118
node-libnpx_10.2.0+repack.orig.tar.gz
df7bc9e4b0ebf88cc68e5bf32589e639c2f96b01696612b6895e80c5e48e4835 5940
node-libnpx_10.2.0+repack-1.debian.tar.xz
Files:
26382d689b6b3e26102c26d1e63f233d 2914 javascript optional
node-libnpx_10.2.0+repack-1.dsc
394c905f6b848278e569cdbf26ce927d 7306 javascript optional
node-libnpx_10.2.0+repack.orig-dotenv.tar.gz
c805feee28c69e8b0ac88ffc189ef515 5599 javascript optional
node-libnpx_10.2.0+repack.orig-update-notifier.tar.gz
94a9d4e6fd420332b003b67d778112aa 107118 javascript optional
node-libnpx_10.2.0+repack.orig.tar.gz
33450736a862d28b6c1a616aab41c2f3 5940 javascript optional
node-libnpx_10.2.0+repack-1.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEAN/li4tVV3nRAF7J9tdMp8mZ7ukFAlxlP9UACgkQ9tdMp8mZ
7ukJbhAAhBOhNkVXPiUPrjOTRGacvr5LNuyzbg3kXhzodLq8ou1+fmkxxvVKpWyH
xrOIcmuJKwfjtX+ITe3G2CPp7cgDasyA10c38AcDAAHLT1GkqVHrUGlRyB6vENfz
h7R45lE9JdCNB36/0T6NcygTx+aKwRwLX4KKGaMLg4BtOkS+UMp3tua6y4a37oak
+rF9xeR0ztBlXHr9YXCsnekhC/JJ3+utlI7+DAoMWz5D2TDXRu8Gc/MegCAEMJr3
t3QcC146hasZDUS3NPNqMbCM/HDM06O64CGdvN8f7u7SicRn8A4KZh5BIZS6MiHj
qJcsuDNkrNs+JMC0L8+zLTrylkZ4PvXC4XxVKQBdMKZZsuw/964u4H3FM9F/vcVC
Yg/uOCVgOdJ7upY5TfoXOts4H+KB31b+CtEfH117ZnXzP+LvgZ/MBwPtoQ/rISRm
dxWhFiBh/fSq7phTDX0PtQq4DBpJi1kEaxxkOfhBKbFA1kqV7STT31KNl5GkgiRv
c0wWO17oqJ/0xulIbXAwzlwR7fpP+e04Ev9cbZxLKMOtRFMz+e3eqejsYF8aLh6Q
UTgUQoOm7KtevLKbRESjW3j0gh7SBFrKN7HavS/H41PAa73/d44ex4HkL3QK/+7+
4/bEVxFWKTOTQPPg60meoyfT8crrE7+HZSSwdBYBA1/g3i3+Vj4=
=0VO6
-----END PGP SIGNATURE-----
--- End Message ---
