Your message dated Mon, 08 Apr 2019 20:34:22 +0000
with message-id <[email protected]>
and subject line Bug#926674: fixed in links2 2.18-2
has caused the Debian Bug report #926674,
regarding links2: Crash on invalid IDN URL
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
926674: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=926674
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: links2
Version: 2.18
Severity: important
Tags: fixed-upstream upstream patch
Control: submitter -1 Mikulas Patocka <[email protected]>
I just received the attached mail from upstream with a patch that
fixes a crash on an invalid IDN URL.
I intent to fix this in Debian Sid/Buster with applying the functional
part of the patch (but probably not the changelog part) against 2.18-1
and uploading 2.19 to Debian Experimental until Buster is released.
Regards, Axel
--
,''`. | Axel Beckert <[email protected]>, https://people.debian.org/~abe/
: :' : | Debian Developer, ftp.ch.debian.org Admin
`. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5
`- | 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE
--- Begin Message ---
Hi
I submit this patch for links-2.18 in Debian Buster. It fixes a crash on
invalid IDN URL.
For Debian Sid, you can upgrade to links-2.19.
Mikulas
commit 9dc711da9b61431f83f863920583d4c9d3bea26d
Author: Mikulas Patocka <[email protected]>
Date: Sat Mar 30 22:36:43 2019 +0100
fix a crash on invalid idn url
diff --git a/ChangeLog b/ChangeLog
index 92736b50..4ea09306 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+Sat Mar 30 21:56:02 CET 2019 mikulas:
+
+ Fixed a crash on invalid IDN URL, such as http://test,ï.com/
+ (found by [email protected])
+
Tue Mar 12 23:02:33 CET 2019 mikulas:
Make it possible to select other fonts, using fontconfig and freetype
diff --git a/url.c b/url.c
index e6252d70..8dc34d47 100644
--- a/url.c
+++ b/url.c
@@ -1153,6 +1153,8 @@ static unsigned char *display_url_or_host(struct terminal
*term, unsigned char *
url_enc = idn_encode_url(url_conv2, 0);
else
url_enc = idn_encode_host(url_conv2,
(int)strlen(cast_const_char url_conv2), separator, 0);
+ if (!url_enc)
+ url_enc = stracpy(url_conv2), is_idn = 1;
mem_free(url_conv2);
if (!strcmp(cast_const_char url_enc, cast_const_char url)) {
if (is_idn && warn_idn) {
--- End Message ---
signature.asc
Description: Digital signature
--- End Message ---
--- Begin Message ---
Source: links2
Source-Version: 2.18-2
We believe that the bug you reported is fixed in the latest version of
links2, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Axel Beckert <[email protected]> (supplier of updated links2 package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Mon, 08 Apr 2019 21:28:08 +0200
Source: links2
Binary: links links-dbgsym links2 links2-dbgsym
Architecture: source amd64
Version: 2.18-2
Distribution: unstable
Urgency: low
Maintainer: Axel Beckert <[email protected]>
Changed-By: Axel Beckert <[email protected]>
Description:
links - Web browser running in text mode
links2 - Web browser running in both graphics and text mode
Closes: 926674
Changes:
links2 (2.18-2) unstable; urgency=low
.
* Cherry-pick patch from upstream to fix crash on invalid IDN
URL. (Closes: #926674)
Checksums-Sha1:
3f21a29860f87d08a65ef62f56d3ee39d0500683 2086 links2_2.18-2.dsc
5f00b5f7f8a6e8ca8f511debde103274a2d25a13 15460 links2_2.18-2.debian.tar.xz
b6ebd9acbc991e7226b0ac86b1a60ba039d06c93 756080 links-dbgsym_2.18-2_amd64.deb
b0e01a82638f59993cc0dfaf76692d87dc97315d 1206228 links2-dbgsym_2.18-2_amd64.deb
c27f733f4f4e4097fff0e635e0223b05a69b9e8a 12472 links2_2.18-2_amd64.buildinfo
70b60776ab33334692916473e80224033965a24f 3168456 links2_2.18-2_amd64.deb
1c53c51c7514cdbb6925b9c21b0d0344abe1ee22 683596 links_2.18-2_amd64.deb
Checksums-Sha256:
0a6cd76e3f4d43cb95eab6bdab64aead004201493446709b074e919aa2a59d66 2086
links2_2.18-2.dsc
c977ef0f4f10be1eb7d5aff5cc203ad0f836468ee80b8a858e4df828a88bf0c2 15460
links2_2.18-2.debian.tar.xz
5070f9195e085ee3a7d185874af098c8a0ed9f3dec8579cb68685b998f0137e7 756080
links-dbgsym_2.18-2_amd64.deb
252a6937b29f9dc2f8e6d28bf5830f346d6053e5ea27cebf8b1e17e336625fc5 1206228
links2-dbgsym_2.18-2_amd64.deb
bcd5ea2128a77e3297a9ffe3e7e92db393457e9f35926382a75c40bab6e57345 12472
links2_2.18-2_amd64.buildinfo
5bc2b1c35395ec6b0ec71e1a4d4399ec8c299d9b8d709a2d6c1c512972433099 3168456
links2_2.18-2_amd64.deb
fdacb5320c0fa36af606e7c0f8e428c3a08b2632c986918fcd1a265fc3389e84 683596
links_2.18-2_amd64.deb
Files:
af62ba25417942f3647adcccb04967b5 2086 web optional links2_2.18-2.dsc
7c3a5de3cbe0007357f9fb102745e835 15460 web optional links2_2.18-2.debian.tar.xz
53765d5e98dfffd708f5f58ac0a21f9c 756080 debug optional
links-dbgsym_2.18-2_amd64.deb
180944d7df06a916df297aea38190278 1206228 debug optional
links2-dbgsym_2.18-2_amd64.deb
5e5ac4f2470934204fef1c70c9e35fd8 12472 web optional
links2_2.18-2_amd64.buildinfo
5b7322064e337807dad13b7403379fbd 3168456 web optional links2_2.18-2_amd64.deb
ac706b63c4bac291754e3bc26731527a 683596 web optional links_2.18-2_amd64.deb
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEERoyJeTtCmBnp12Ema+Zjx1o1yXUFAlyrptMACgkQa+Zjx1o1
yXXhihAAu7L4eSYcbAvJUA4MezwaYsu3Uag42mGKjAmWHsLPujguxhZ/2CZnARol
VcymbEeUKLceXu6C7wUbUq/KMy19ZBT8YwgiPfauzG5CClXfCD3rlqROm083Of+n
Qt7O+/aUpO9mMH2kNVMRcnUD1jkDSapeOQ43aBqD2g9aOsIupZ6k7j58Ur66Ne0+
yuBmVHi5uIb4j/FTyj5xdw0ukohNJ0Vby6bnvrjQ16/7Wyj3I6K1TO24jfO9TGuO
aqLDrRNIOMHIkvxzOiR7xAobs0p5caQwdJX2WfT52VjvPXxfyADn4r8FyozD9IjK
LO+ypiOEAAzJpKxu+y+cOiaQVz9o4oVT79iS7rnqHjEVNomqcbOlEwPDWC0J1hJe
VyAwokon0kjKMYflkO8bUzOZu9/TkPsaSvLOFkXkLvl+YUKjGBTNHY+te7SJzThy
3sln59JLrYwoZeYGS0i1bJgdk7c4RyCB9VP1Z2HAwQfCWRLAQiwmZm/IW8MlnaOs
Gss5b9Rl8UTMxnL85NIzDzBuedcOJJQYWdaRKHkQvcJfRj13HBW1ueojbPv/scN2
x5FtYxuzMZRxJeC888hvWk7U04Y7chsfF/cMjXdtKOiygykK8ADaJp9tsDSiKWgw
pv1pg1xxuu48w2OU2S7lpvkxXRgDkJD+vd2yEDxstI2Cg2iD5C0=
=0Eu5
-----END PGP SIGNATURE-----
--- End Message ---
