Your message dated Wed, 15 May 2019 23:49:46 +0000
with message-id <[email protected]>
and subject line Bug#924366: fixed in munin 2.0.49-1
has caused the Debian Bug report #924366,
regarding natural sort output on cpuspeed plugin
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
924366: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=924366
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: munin-plugins-core
Version: 2.0.47-1
Control: severity -1 wishlist

The output of several plugins (including cpusped) is not sorted at all, and a
simple numeric iteration (e.g. of cpu cores or network interfaces) results in
incorrect sorting (1, 10, 11, 12, ..., 2, 20, 21, etc).

I fixed this on my system by replacing the /etc/munin/plugins/cpuspeed symlink
(to /usr/share/munin/plugins/cpuspeed) with a copy of the plugin and making
the following one line change to use sort's -V version-sort aka natural sort
option:


# diff -u /usr/share/munin/plugins/cpuspeed /etc/munin/plugins/cpuspeed
--- /usr/share/munin/plugins/cpuspeed   2019-03-01 02:06:07.000000000 +1100
+++ /etc/munin/plugins/cpuspeed 2019-03-12 12:25:17.239713453 +1100
@@ -141,7 +141,7 @@
         print_warning "cpu$N"
         print_critical "cpu$N"
 
-    done
+    done | sort -V
     if [ "${MUNIN_CAP_DIRTYCONFIG:-0}" != 1 ]; then exit 0; fi
 fi
 


There are probably several other plugins that would benefit from adding "sort
-V" - anything likely to have 10 or more similar values (e.g. there's a 9 year
old ticket http://munin-monitoring.org/ticket/919 reporting the same issue
with network interfaces).  Please forward this upstream.

e.g. on my 1950x threadripper (16 core/32 thread) system, i was getting:

# munin-run cpuspeed
cpu0.value 284378906000
cpu1.value 284676376000
cpu10.value 286158358000
cpu11.value 285770772000
cpu12.value 286035834000
cpu13.value 286069598000
cpu14.value 286123850000
cpu15.value 286026202000
cpu16.value 284606020000
cpu17.value 284633320000
cpu18.value 284625240000
cpu19.value 284638744000
cpu2.value 284703898000
cpu20.value 285276808000
cpu21.value 285240678000
cpu22.value 284850692000
cpu23.value 285244496000
cpu24.value 286126160000
cpu25.value 286147946000
cpu26.value 286171272000
cpu27.value 286062250000
cpu28.value 286091928000
cpu29.value 286104400000
cpu3.value 284666958000
cpu30.value 286057878000
cpu31.value 286207444000
cpu4.value 286922096000
cpu5.value 286545698000
cpu6.value 286363752000
cpu7.value 286276020000
cpu8.value 286119812000
cpu9.value 286037900000


Now I'm getting this, so the graphs on my munin web page are properly sorted:

cpu0.value 284391408000
cpu1.value 284688894000
cpu2.value 284716416000
cpu3.value 284679476000
cpu4.value 286934664000
cpu5.value 286558216000
cpu6.value 286376270000
cpu7.value 286288580000
cpu8.value 286132378000
cpu9.value 286050418000
cpu10.value 286170884000
cpu11.value 285783268000
cpu12.value 286048376000
cpu13.value 286082230000
cpu14.value 286136368000
cpu15.value 286038780000
cpu16.value 284618538000
cpu17.value 284645838000
cpu18.value 284637736000
cpu19.value 284651262000
cpu20.value 285289428000
cpu21.value 285253196000
cpu22.value 284863188000
cpu23.value 285257014000
cpu24.value 286138678000
cpu25.value 286160610000
cpu26.value 286183790000
cpu27.value 286074776000
cpu28.value 286104446000
cpu29.value 286116918000
cpu30.value 286070438000
cpu31.value 286219946000



thanks,

craig

--
craig sanders <[email protected]>

--- End Message ---
--- Begin Message ---
Source: munin
Source-Version: 2.0.49-1

We believe that the bug you reported is fixed in the latest version of
munin, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Holger Levsen <[email protected]> (supplier of updated munin package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 16 May 2019 01:21:08 +0200
Source: munin
Architecture: source
Version: 2.0.49-1
Distribution: unstable
Urgency: medium
Maintainer: Munin Debian Maintainers <[email protected]>
Changed-By: Holger Levsen <[email protected]>
Closes: 483617 924366 924424 926146 927692 928211
Changes:
 munin (2.0.49-1) unstable; urgency=medium
 .
   [ Lars Kruse ]
   * New upstream version 2.0.49, fixing the upstream issue #1187
     (https://github.com/munin-monitoring/munin/issues/1187) which breaks the
     visualization of comparison pages and the "problems" overview for munin's
     default settings ("html_strategy" and "graph_strategy" being "cron").
   * New upstream version 2.0.48, fixing various issues, including bugs in:
     - Accept DNS names in "allow" (Closes: #483617)
     - Natural sort output on cpuspeed plugin (Closes: #924366)
     - postgres_connections_ "Query failed!" (Closes: #924424)
     - diskstat_ plugin fails with 4.19 kernels (Closes: #926146)
     - open_files max is 18 quintillion, obscuring graph (Closes: #928211)
     - upstream issues:
       * https://github.com/munin-monitoring/munin/issues/579:
         A connection issue with a node leads to the premature removal of all
         its graphs from the master visualization, if any plugin (from any
         node) returned an invalid output.
       * https://github.com/munin-monitoring/munin/issues/951:
         munin-async failed to handle plugins with names containing special
         characters. Such valid plugins worked only locally, but not via
         munin-async.
       * https://github.com/munin-monitoring/munin/issues/460:
         In an fcgid-based setup (recommended when using nginx) every but the
         first request for a "comparison" page returned invalid graphs due to
         a mistaken permanent internal state change. This long-standing issue
         plagued munin since wheezy.
   * Re-export upstream signing key without extra signatures.
   * Ensure that /var/cache/munin/www exists.
     Thanks to Marvin Gülker (Closes: #927692)
   * Keep permission of /run/munin in sync for systemd and sysvinit
Checksums-Sha1:
 6da90bff885cfc21abba4b38f543b9f9d9b55195 3083 munin_2.0.49-1.dsc
 48531b84c4382983cf4fe64a7c3ad22a86cbdc2e 2252353 munin_2.0.49.orig.tar.gz
 4c43e146cc92a4373deafac671bfccac55f59210 833 munin_2.0.49.orig.tar.gz.asc
 2eee676b1812a7e3d206b6cef49fc7942f1003ef 60928 munin_2.0.49-1.debian.tar.xz
 cfe29fb80895dcf5f60fc906a33dc12affada5d2 5131 munin_2.0.49-1_source.buildinfo
Checksums-Sha256:
 6baabc307991d39de79b36a689180a56e340f60af44cc14ecca122d11602769e 3083 
munin_2.0.49-1.dsc
 e270ac3f6e669a19124ee5ab5cdd196d94be726bc93abfba94d5644d5f0badc3 2252353 
munin_2.0.49.orig.tar.gz
 ad7654fd698e9ae12f320dfd24d31374be69f1626bd4c54e3cfc709dc92b1b32 833 
munin_2.0.49.orig.tar.gz.asc
 fea5b84fd835f15eff9a30ab9f767f263236971a30de8abf2dc1271bcc2642d5 60928 
munin_2.0.49-1.debian.tar.xz
 23c5da0fbdde79860061c8f7600b596d29b1c18e02733f7904da1d32f420bf00 5131 
munin_2.0.49-1_source.buildinfo
Files:
 e81dd2b13b4da22161b066dbd3669bfb 3083 net optional munin_2.0.49-1.dsc
 8d3486cf01faa837eeb03415cc1513ac 2252353 net optional munin_2.0.49.orig.tar.gz
 ad1f7647de07c32236f9a444bbf03fcf 833 net optional munin_2.0.49.orig.tar.gz.asc
 688d93b3ab0ed5dd42166a89a55b18a1 60928 net optional 
munin_2.0.49-1.debian.tar.xz
 735bac7ae9f54df47877413fb41c7041 5131 net optional 
munin_2.0.49-1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEuL9UE3sJ01zwJv6dCRq4VgaaqhwFAlzco9cACgkQCRq4Vgaa
qhxAcw/9FRFhZqukqKxBcUCsEp0o38sWGSKK5YVXb3+89CVsto3xuEi4pTExRbiW
DiGf6+RleAlVmKTk/SyIKnXIJwTRErSbvmxwVN+A5W8/OejmB9WWMnhyMU3BH9Yn
bsTqTzE1CNvKAXxj4wegvEHHjDRiq5Or7i+utsLi2boggeW/fNIXauEqTMUhq9ZG
bSurwhdjZvtyh1nSfZh2NxjeDeuO3fRPytrME0edtmaFvJqchJF78MnyBGhujAz9
KTnbJXGylnfKQ5arTWGbxKr+bjTV9VOAV6ce9S+TF/8wNi3henlWEgDgPBYmT47O
OV0lgx+AUcErBtGkzWAGnC8bKYQzjrxgAvWhlzSt6Pqw3zGzxKzbfEcjlFEI/H7E
AsZ91iZwLu/dIGgduPQOmDGG0W9fFUPwL6FJy/UFLmLRa2Fpz2NKkxBjgOETgxJn
2D5j3V3G7pIkYEhPMRaFE4g+wWnC6w8dg3Q+ePlpdp+vzH0fmDBshT8f76p4XnX7
NP996Ci0llDCpTB+o5SgYmGvb2keW2khLtEPLTJhgnON6VEojJS3FmdPGmPH05Ij
JF64uh5ZPLY5z0JyenO6UNQPd4gAdPLhPDlsaM6zppwJidO4wEzHpqt5Ykk5ShDQ
v5wWk7OuVI/QbkEIGquApgYmf+iAfv81D/NigPKwmFN7xqTWm/M=
=fk2s
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to