Your message dated Sun, 09 Jun 2019 22:03:44 +0000
with message-id <[email protected]>
and subject line Bug#913704: fixed in ola 0.10.7.nojsmin-2
has caused the Debian Bug report #913704,
regarding ola: test compatibility with -Wl,--as-needed
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
913704: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=913704
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: ola
Version: 0.10.7.nojsmin-1
Severity: minor
Tags: patch
User: [email protected]
Usertags: origin-ubuntu disco ubuntu-patch
Dear maintainers,
The ola package is failing its c++ compile-and-run autopkgtest in Ubuntu,
because the test passes libraries on the g++ commandline before the source
file that references them, causing undefined references:
autopkgtest [05:31:12]: test command5: set -e; g++ -o linktest $(pkg-config --cf
lags --libs libola) debian/tests/hw.cc; ./linktest
autopkgtest [05:31:12]: test command5: [-----------------------
/usr/bin/ld: /tmp/cce3slFM.o: in function `main':
hw.cc:(.text+0x30): undefined reference to
`ola::io::LoopbackDescriptor::LoopbackDescriptor()'
/usr/bin/ld: hw.cc:(.text+0x4a): undefined reference to
`ola::client::OlaClient::OlaClient(ola::io::ConnectedDescriptor*)'
/usr/bin/ld: hw.cc:(.text+0x5a): undefined reference to
`ola::client::OlaClient::Setup()'
/usr/bin/ld: hw.cc:(.text+0xfa): undefined reference to
`ola::client::OlaClient::~OlaClient()'
/usr/bin/ld: hw.cc:(.text+0x142): undefined reference to
`ola::client::OlaClient::~OlaClient()'
/usr/bin/ld: /tmp/cce3slFM.o: in function
`ola::io::BidirectionalFileDescriptor::~BidirectionalFileDescriptor()':
hw.cc:(.text._ZN3ola2io27BidirectionalFileDescriptorD2Ev[_ZN3ola2io27BidirectionalFileDescriptorD5Ev]+0x18):
undefined reference to `vtable for ola::io::BidirectionalFileDescriptor'
/usr/bin/ld:
hw.cc:(.text._ZN3ola2io27BidirectionalFileDescriptorD2Ev[_ZN3ola2io27BidirectionalFileDescriptorD5Ev]+0x32):
undefined reference to `vtable for ola::io::BidirectionalFileDescriptor'
[...]
(http://autopkgtest.ubuntu.com/packages/o/ola/disco/s390x)
Per <https://wiki.ubuntu.com/ToolChain/CompilerFlags#A-Wl.2C--as-needed>,
libraries must be passed on the commandline after the objects which
reference them, otherwise they will be discarded by the linker, resulting in
errors such as the above.
I have uploaded the attached patch to ola in Ubuntu. Please consider
applying it in Debian as well.
This is only a minor issue in Debian, but in Ubuntu it is a failing test
that is treated as a release blocker for this package.
Thanks,
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer https://www.debian.org/
[email protected] [email protected]
diff -Nru ola-0.10.7.nojsmin/debian/tests/control
ola-0.10.7.nojsmin/debian/tests/control
--- ola-0.10.7.nojsmin/debian/tests/control 2018-09-07 11:27:03.000000000
-0700
+++ ola-0.10.7.nojsmin/debian/tests/control 2018-11-13 23:27:32.000000000
-0800
@@ -10,6 +10,6 @@
Test-Command: pkg-config --cflags --libs libola
Depends: libola-dev, pkg-config
-Test-Command: set -e; g++ -o linktest $(pkg-config --cflags --libs libola)
debian/tests/hw.cc; ./linktest
+Test-Command: set -e; g++ -o linktest debian/tests/hw.cc $(pkg-config --cflags
--libs libola); ./linktest
Depends: libola-dev, g++, pkg-config
Restrictions: rw-build-tree
--- End Message ---
--- Begin Message ---
Source: ola
Source-Version: 0.10.7.nojsmin-2
We believe that the bug you reported is fixed in the latest version of
ola, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Wouter Verhelst <[email protected]> (supplier of updated ola package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sun, 09 Jun 2019 16:38:40 +0200
Source: ola
Binary: libola-dev libola1 libola1-dbgsym ola ola-dbgsym ola-python
ola-rdm-tests
Architecture: source amd64 all
Version: 0.10.7.nojsmin-2
Distribution: unstable
Urgency: medium
Maintainer: Wouter Verhelst <[email protected]>
Changed-By: Wouter Verhelst <[email protected]>
Description:
libola-dev - Open Lighting Architecture - development libraries
libola1 - Open Lighting Architecture - shared libraries
ola - Open Lighting Architecture
ola-python - Open Lighting Architecture - Python Classes
ola-rdm-tests - Open Lighting Architecture - RDM Responder Tests
Closes: 913704
Changes:
ola (0.10.7.nojsmin-2) unstable; urgency=medium
.
* Reorder build command line in autopkgtest; Closes: #913704.
Checksums-Sha1:
8f8d93fb4fac3be538da00cbc7b0e177820388d5 2456 ola_0.10.7.nojsmin-2.dsc
6e4acd80aa207e4a678a8c474bd3f8ef2c21edc2 28468
ola_0.10.7.nojsmin-2.debian.tar.xz
caab147b95e78934440b3b54e6dd8ee4a9b34c74 3230616
libola-dev_0.10.7.nojsmin-2_amd64.deb
f6374a4fa6aef1fd97bec30bda725446b5bf7f6f 753480
libola1-dbgsym_0.10.7.nojsmin-2_amd64.deb
badcd139710254b0f88fdaa1e340dcb08cf6a6b8 2107444
libola1_0.10.7.nojsmin-2_amd64.deb
2180b14e9ced493fd4809380c9096f47264382e9 78668
ola-dbgsym_0.10.7.nojsmin-2_amd64.deb
ca3c3311e6e8bc16f7ed754e0ab77d90a3ef955f 44176
ola-python_0.10.7.nojsmin-2_all.deb
ea6ebbaacfb0709f9174e7fe40a5390c06caf8d8 97300
ola-rdm-tests_0.10.7.nojsmin-2_all.deb
650e34adbc6749f4411796e3d0b1def1dc98143b 10314
ola_0.10.7.nojsmin-2_amd64.buildinfo
f14b01bbc377ec174ac37319842055f66c7f3445 438588 ola_0.10.7.nojsmin-2_amd64.deb
Checksums-Sha256:
56e0ff2c08c72f5f9f055664667d3930ec3651b03b6cf345683930e73131b320 2456
ola_0.10.7.nojsmin-2.dsc
8f8011f2339e811ff65c0d88d9a9162a93e0ed108a470905df7433bde3d98f6d 28468
ola_0.10.7.nojsmin-2.debian.tar.xz
9083458933eee20352c08b8c57c7af8ecc31672eb2447edcc478c63677021863 3230616
libola-dev_0.10.7.nojsmin-2_amd64.deb
87f41453d31f9bdd9f55856abeb17371d47eaf427c3564240ad2a5b02103e56e 753480
libola1-dbgsym_0.10.7.nojsmin-2_amd64.deb
471ad149a3a4723111d550ca1f144d7c939c4852e9dc93313fe15e303beb4ed5 2107444
libola1_0.10.7.nojsmin-2_amd64.deb
532bdfd30ad07cc8606a2fb4dc9d7bb1071816cedd4e4da53c3fee99e2709b15 78668
ola-dbgsym_0.10.7.nojsmin-2_amd64.deb
591e731bd673a6f79dbb5ef7f60c278f4ffd3b1e672a794ca4d874144038e7ad 44176
ola-python_0.10.7.nojsmin-2_all.deb
3f7d018f15e0a6ab81e215fe20b1db0cb5508840aa9436864f63ebfcc3ea9ed0 97300
ola-rdm-tests_0.10.7.nojsmin-2_all.deb
a5abed4ef013148e97c297686063cfbf665e8c5f79f5bfb883dd0d8b1bf2da13 10314
ola_0.10.7.nojsmin-2_amd64.buildinfo
1096a825e4559279c1cb6ff030e0c034220af1f798ffbc978ba787a3a373a0cb 438588
ola_0.10.7.nojsmin-2_amd64.deb
Files:
d9f367418d8b8f11618bafa06a80ae97 2456 libs optional ola_0.10.7.nojsmin-2.dsc
175839297d0a40298744d8dc35c0ac60 28468 libs optional
ola_0.10.7.nojsmin-2.debian.tar.xz
575f90c3d284135cc7ea070cdb060e74 3230616 libdevel optional
libola-dev_0.10.7.nojsmin-2_amd64.deb
91196dfedaf40ca5b7d19b87ce939f1a 753480 debug optional
libola1-dbgsym_0.10.7.nojsmin-2_amd64.deb
738682486fa8912ebd78d6d7b5edc18e 2107444 libs optional
libola1_0.10.7.nojsmin-2_amd64.deb
736e140fb4a1d87ea817dd83294a3334 78668 debug optional
ola-dbgsym_0.10.7.nojsmin-2_amd64.deb
8752e45a6b0f9641d5bc9c08aad8a1d2 44176 libs optional
ola-python_0.10.7.nojsmin-2_all.deb
f9123996edf0845b4a5a1c3fad1300ba 97300 libs optional
ola-rdm-tests_0.10.7.nojsmin-2_all.deb
3b4521b57f65a1640b57e2cc029a1554 10314 libs optional
ola_0.10.7.nojsmin-2_amd64.buildinfo
181480a0b44e00b515045fb9592d410a 438588 electronics optional
ola_0.10.7.nojsmin-2_amd64.deb
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEm2n98/DaCUgGYSn3LfxRmVQYEpYFAlz9fZoACgkQLfxRmVQY
EpbKcg/+LHtJuchogGa1q/y9SkhtpNIwm+8Y0Dy3AD2U+968lQnFXzTa1cEDv+lc
zCqEcLHJxDW1zvoiudyOCcvxXhOyPwx1gc34YP0avp2KFaqzGJHGXRhyiMnhZ6n8
RiOItHacBbF2+OeYzdd9QVzUWTj6Y1UIVi4gkFvknxPqg8xpDxhqDGauFBOlOWBl
x4y24wGk0aC/J7tVW6FMl6OyM5CiCnt74nNW/C6XaUxNrONBsD1jKl1746z2fm3w
QY3qy3wyvMgODsUPrpJ7TpYJA9jaUjA9BWNFUJX74BtKmn9/aCmPTw/wTJmNlhLR
Y3puDZ/YqAfWuvACTWBfsv884GxLAl/8lgVpSkv3yeI5vw/QCAUhdA37otK7+FHf
BqjBHds1/GepvOMDHna38h5mps53ADcZoWRzucXp1dxVVlNIc/SaWbuSvswLN2iY
IirWnivoJana4LLFp7Hx+caKBNpSrZw4CMWGysSNd1NSD+f97/OFmMY7nVYDcvgv
rH3sLkIHfLCmSJ23eYUB91QkFlugBdQ0HI04Nw6xDhcbZQ/fxk4dpB1THpBWhWxS
/+G4QAj5cr5V03YQxJQwZbl5mPeAkCRqH/6OwIWpQGRcANWSmTHXI6f2x6lcXRTm
SZOqhb1A/T7BNBuS3Bu8oWP74Qt6Qp1fG3mCyhkg5fapk0kvovE=
=peOS
-----END PGP SIGNATURE-----
--- End Message ---
