Your message dated Fri, 14 Jun 2019 15:06:40 +0000
with message-id <[email protected]>
and subject line Bug#929810: fixed in grml-debootstrap 0.89
has caused the Debian Bug report #929810,
regarding grml-debootstrap: Unreliable configuration of predictable network 
interface names
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
929810: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=929810
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: grml-debootstrap
Version: 0.88
Severity: important

We noticed that the network configuration generated by
grml-debootstrap is unreliable for the predictable network naming
schema (when net.ifname=0 isn't set).

The underlying code in grml-debootstrap currently iterates over all
network devices via:

  for interface in $(udevadm info -e | sed -n -e 's/E: 
ID_NET_NAME_PATH=\([^$*]\)/\1/p'); do
  [...]

This means that we get something like the following for a (Proxmox)
VM with a virtio network device:

  # udevadm info -e | grep 'ID_NET_NAME_PATH'
  E: ID_NET_NAME_PATH=enp0s18

While on actual boot the device is named ens18 then. This results in
the VM having a broking network configuration.

I managed to track this down already. In systemd's link_config_apply
function (defined in src/udev/net/link-config.c) we have:

|         switch (policy) {
|         case NAMEPOLICY_KERNEL:
|                 if (name_type != NET_NAME_PREDICTABLE)
|                         continue;
|
|                 /* The kernel claims to have given a predictable name, keep 
it. */
|                 log_device_debug(device, "Policy *%s*: keeping predictable 
kernel name",
|                                  name_policy_to_string(policy));
|                 goto no_rename;
|         case NAMEPOLICY_KEEP:
|                 if (!IN_SET(name_type, NET_NAME_USER, NET_NAME_RENAMED))
|                         continue;
|
|                 log_device_debug(device, "Policy *%s*: keeping existing 
userspace name",
|                                  name_policy_to_string(policy));
|                 goto no_rename;
|         case NAMEPOLICY_DATABASE:
|                 (void) sd_device_get_property_value(device, 
"ID_NET_NAME_FROM_DATABASE", &new_name);
|                 break;
|         case NAMEPOLICY_ONBOARD:
|                 (void) sd_device_get_property_value(device, 
"ID_NET_NAME_ONBOARD", &new_name);
|                 break;
|         case NAMEPOLICY_SLOT:
|                 (void) sd_device_get_property_value(device, 
"ID_NET_NAME_SLOT", &new_name);
|                 break;
|         case NAMEPOLICY_PATH:
|                 (void) sd_device_get_property_value(device, 
"ID_NET_NAME_PATH", &new_name);
|                 break;
|         case NAMEPOLICY_MAC:
|                 (void) sd_device_get_property_value(device, 
"ID_NET_NAME_MAC", &new_name);
|                 break;
|         default:
|                 assert_not_reached("invalid policy");
|         }

So if a device has the propery ID_NET_NAME_PATH set (e.g. enp0s18),
but also ID_NET_NAME_SLOT (ens18), we can't just use the value from
ID_NET_NAME_PATH but have to follow the precedence.

I tend to call this a RC bug, so we should get this fixed for
Debian/buster.

regards
-mika-

Attachment: signature.asc
Description: Digital signature


--- End Message ---
--- Begin Message ---
Source: grml-debootstrap
Source-Version: 0.89

We believe that the bug you reported is fixed in the latest version of
grml-debootstrap, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Michael Prokop <[email protected]> (supplier of updated grml-debootstrap package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Fri, 14 Jun 2019 14:47:02 +0200
Source: grml-debootstrap
Binary: grml-debootstrap
Architecture: source all
Version: 0.89
Distribution: unstable
Urgency: medium
Maintainer: Grml Team <[email protected]>
Changed-By: Michael Prokop <[email protected]>
Description:
 grml-debootstrap - wrapper around debootstrap for installing pure Debian
Closes: 929810 930468
Changes:
 grml-debootstrap (0.89) unstable; urgency=medium
 .
   * [2860f13] Fix detection of predictable network interface names
     (Closes: #929810)
   * [7a11723] Ensure /etc/network exists before setting up
     /etc/network/interfaces (Closes: #930468)
Checksums-Sha1:
 88099852b9a8adc2b326a56d8dfebc45bb7c51c0 1803 grml-debootstrap_0.89.dsc
 3bea0924643576eb534bbc83cef1a84f62a484d2 160108 grml-debootstrap_0.89.tar.xz
 87c8a335748a55d3d4887b564ad924bceb25bbfd 165216 grml-debootstrap_0.89_all.deb
 5c4082d7e56ec953e69f1800cf078051a7ce5bbd 6131 
grml-debootstrap_0.89_amd64.buildinfo
Checksums-Sha256:
 cd12b1057861e07e9d29755b56fcd0ecc6116a3ebff226462b13de042e05c3cf 1803 
grml-debootstrap_0.89.dsc
 ccb37d86a7e68b02402a03c25c01277fb378c124b6ae9ace2e3cc98b3a536ecd 160108 
grml-debootstrap_0.89.tar.xz
 bb1b4180c41fa13e5fb598defa0d4c7841578a43ced6a090b20c91b7e6a407fe 165216 
grml-debootstrap_0.89_all.deb
 24fb61569a86dbde2d757a8bb070750d4eceff738fbc5c05c848e56f5a6ccc8e 6131 
grml-debootstrap_0.89_amd64.buildinfo
Files:
 1d10a6d60de21b5ccc4286c82bf91fa2 1803 admin optional grml-debootstrap_0.89.dsc
 cac0f3a44d66e8fca9dd48e52b77ffab 160108 admin optional 
grml-debootstrap_0.89.tar.xz
 f171ad08a80ca5c6cf3f42260a624df7 165216 admin optional 
grml-debootstrap_0.89_all.deb
 726af9801a9a37c8457bd455d81999f8 6131 admin optional 
grml-debootstrap_0.89_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEM8yxNkAa/shDo4djlqh4crfqNzcFAl0DmP8ACgkQlqh4crfq
Nzd4YQ//QDV1LlbQ3SFSECnKx6if35RsV2wD2NLJEVXqzpcb3bdXOe9OgS+tYYh4
/AZ9/DP8lGWGb7idLE56oFyJyNjaUAfcsHq9hsWg8MWwojv18k8mq53H53/3sdJR
IrwJ1NWELS77JdGqPjprtxwE5wsu4G32Z44/C4uPVVG7DkoraTDA/GMaNp+h4tmI
x/FhczEobYD39K5rf2KkwBr5hf0vpOQP8gWu8KOJAZH0OXnF0wLasl8DwZb3t+g+
XPh2beqQJ/xC2n2sCl9FZtP5VSdTogvWr3QfdOguVGgGOpn1BJsbicOI+7daRDi+
Sf7+ZBF+g6LU7ttcRVoswJHaJ4l1HrrtIb+8zY+ZIXhxhNi+pgwQj2h7k7m+CojV
Vt8Zs7flxeQW7SUrpbUM1/0R38MmGh4yYVrLolpBH4VGRTy7aq21k++GjSVBi+dM
V6EJ6CnpE6bxGUVOhbhpmQsd2Bcpq5AUN4jCzpx2sX55qRFVwa9Tb4esZoR1zLcf
BUHXYCFiOk5pNdTIVqeq9/kQ+nmM2sh6avChmvpeIY7Ykuezmh2Fws+OwBbHSO05
SONAwC5TjU2Ybt241X4bid2hRbMtDu2u507z8ANHSLb+RB73YfrCFWU4XUl7+vH4
ji8OISbQGdfMRPCm5qylYOgMvXpKnusso9oaz6kzdnOAAbR3WPg=
=mpft
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to