Your message dated Wed, 24 Jul 2019 22:36:02 +0000
with message-id <[email protected]>
and subject line Bug#932314: fixed in lintian-brush 0.17
has caused the Debian Bug report #932314,
regarding lintian-brush: add standards upgrade path 4.3.0 -> 4.4.0
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
932314: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=932314
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: lintian-brush
Version: 0.16
Severity: wishlist
First patch implements new upgrade path, second is just minor code
cleanup.
From d03695297777c1c972ca2422da145165e4e4250f Mon Sep 17 00:00:00 2001
From: Dmitry Bogatov <[email protected]>
Date: Tue, 16 Jul 2019 18:08:53 +0000
Subject: [PATCH 1/2] Add upgrade path for standards 4.3.0 -> 4.4.0
Policy 4.4.0 now recommends debhelper. If package uses debhelper,
it can safely upgrade from 4.3.0.
---
fixers/out-of-date-standards-version.py | 19 ++++++++++++++++++-
.../4.4.0-nodh/in/debian/control | 2 ++
.../4.4.0-nodh/message | 3 +++
.../4.4.0-nodh/out/debian/control | 2 ++
.../4.4.0/in/debian/control | 3 +++
.../4.4.0/message | 3 +++
.../4.4.0/out/debian/control | 3 +++
7 files changed, 34 insertions(+), 1 deletion(-)
create mode 100644
tests/out-of-date-standards-version/4.4.0-nodh/in/debian/control
create mode 100644 tests/out-of-date-standards-version/4.4.0-nodh/message
create mode 100644
tests/out-of-date-standards-version/4.4.0-nodh/out/debian/control
create mode 100644 tests/out-of-date-standards-version/4.4.0/in/debian/control
create mode 100644 tests/out-of-date-standards-version/4.4.0/message
create mode 100644 tests/out-of-date-standards-version/4.4.0/out/debian/control
diff --git a/fixers/out-of-date-standards-version.py
b/fixers/out-of-date-standards-version.py
index 5e8201d..7a0c822 100755
--- a/fixers/out-of-date-standards-version.py
+++ b/fixers/out-of-date-standards-version.py
@@ -1,13 +1,15 @@
#!/usr/bin/python3
import os
-from lintian_brush.control import update_control
+from lintian_brush.control import update_control, get_relation
+from debian.deb822 import Deb822
# Dictionary mapping source and target versions
upgrade_path = {
"4.1.0": "4.1.1",
"4.2.0": "4.2.1",
+ "4.3.0": "4.4.0",
}
@@ -15,8 +17,23 @@ def check_4_1_1():
return os.path.exists("debian/changelog")
+def check_4_4_0():
+ "Check that package uses debhelper."
+ if os.path.exists("debian/compat"):
+ return True
+ with open('debian/control') as f:
+ source = next(Deb822.iter_paragraphs(f))
+ build_deps = source.get('Build-Depends', '')
+ try:
+ get_relation(build_deps, 'debhelper-compat')
+ return True
+ except KeyError:
+ return False
+
+
check_requirements = {
"4.1.1": check_4_1_1,
+ "4.4.0": check_4_4_0,
}
diff --git a/tests/out-of-date-standards-version/4.4.0-nodh/in/debian/control
b/tests/out-of-date-standards-version/4.4.0-nodh/in/debian/control
new file mode 100644
index 0000000..5f54dd7
--- /dev/null
+++ b/tests/out-of-date-standards-version/4.4.0-nodh/in/debian/control
@@ -0,0 +1,2 @@
+Source: lintrian-brush
+Standards-version: 4.3.0
diff --git a/tests/out-of-date-standards-version/4.4.0-nodh/message
b/tests/out-of-date-standards-version/4.4.0-nodh/message
new file mode 100644
index 0000000..05ec0b1
--- /dev/null
+++ b/tests/out-of-date-standards-version/4.4.0-nodh/message
@@ -0,0 +1,3 @@
+Update standards version, no changes needed.
+Certainty: certain
+Fixed-Lintian-Tags: out-of-date-standards-version
diff --git a/tests/out-of-date-standards-version/4.4.0-nodh/out/debian/control
b/tests/out-of-date-standards-version/4.4.0-nodh/out/debian/control
new file mode 100644
index 0000000..5f54dd7
--- /dev/null
+++ b/tests/out-of-date-standards-version/4.4.0-nodh/out/debian/control
@@ -0,0 +1,2 @@
+Source: lintrian-brush
+Standards-version: 4.3.0
diff --git a/tests/out-of-date-standards-version/4.4.0/in/debian/control
b/tests/out-of-date-standards-version/4.4.0/in/debian/control
new file mode 100644
index 0000000..06deee4
--- /dev/null
+++ b/tests/out-of-date-standards-version/4.4.0/in/debian/control
@@ -0,0 +1,3 @@
+Source: lintrian-brush
+Standards-version: 4.3.0
+Build-Depends: debhelper-compat (= 11)
diff --git a/tests/out-of-date-standards-version/4.4.0/message
b/tests/out-of-date-standards-version/4.4.0/message
new file mode 100644
index 0000000..05ec0b1
--- /dev/null
+++ b/tests/out-of-date-standards-version/4.4.0/message
@@ -0,0 +1,3 @@
+Update standards version, no changes needed.
+Certainty: certain
+Fixed-Lintian-Tags: out-of-date-standards-version
diff --git a/tests/out-of-date-standards-version/4.4.0/out/debian/control
b/tests/out-of-date-standards-version/4.4.0/out/debian/control
new file mode 100644
index 0000000..50960a0
--- /dev/null
+++ b/tests/out-of-date-standards-version/4.4.0/out/debian/control
@@ -0,0 +1,3 @@
+Source: lintrian-brush
+Standards-version: 4.4.0
+Build-Depends: debhelper-compat (= 11)
From 03e069810b50919521b05afdd58910fe5d961b71 Mon Sep 17 00:00:00 2001
From: Dmitry Bogatov <[email protected]>
Date: Tue, 16 Jul 2019 18:14:43 +0000
Subject: [PATCH 2/2] Simplify bump_standards_version() function
---
fixers/out-of-date-standards-version.py | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/fixers/out-of-date-standards-version.py
b/fixers/out-of-date-standards-version.py
index 7a0c822..4740412 100755
--- a/fixers/out-of-date-standards-version.py
+++ b/fixers/out-of-date-standards-version.py
@@ -41,13 +41,9 @@ def bump_standards_version(control):
current_version = control["Standards-Version"]
while current_version in upgrade_path:
target_version = upgrade_path[current_version]
- try:
- check_fn = check_requirements[target_version]
- except KeyError:
- pass
- else:
- if not check_fn():
- break
+ check_fn = check_requirements.get(target_version, lambda: True)
+ if not check_fn():
+ break
current_version = target_version
control["Standards-Version"] = current_version
pgprGv5wu7zQQ.pgp
Description: PGP signature
--- End Message ---
--- Begin Message ---
Source: lintian-brush
Source-Version: 0.17
We believe that the bug you reported is fixed in the latest version of
lintian-brush, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Jelmer Vernooij <[email protected]> (supplier of updated lintian-brush package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Wed, 24 Jul 2019 22:12:00 +0000
Source: lintian-brush
Architecture: source
Version: 0.17
Distribution: unstable
Urgency: medium
Maintainer: Jelmer Vernooij <[email protected]>
Changed-By: Jelmer Vernooij <[email protected]>
Closes: 932314
Changes:
lintian-brush (0.17) unstable; urgency=medium
.
[ Dmitry Bogatov ]
* Support policy version bumps from 4.3.0 to 4.4.0. Closes: #932314
.
[ Jelmer Vernooij ]
* Guess (with low certainty) repositories from README.
* Add support for reading upstream metadata from META.json.
* Add support for reading upstream metadata from META.yml files.
* Add support for reading upstream metadata from DOAP files.
* Add (hidden) --allow-reformatting flag.
* Add support for Repository-Browse.
* upstream-metadata-file-is-missing: Derive Repository-Browse from
Repository when possible.
Checksums-Sha1:
16d20fab381e025bbee41fb8ed0ea68045408719 1886 lintian-brush_0.17.dsc
d53156ecffa7b553cc58f36f2d986de8acae7049 707144 lintian-brush_0.17.tar.xz
a5ead337bf6800a2cd9d9bc79a01328b3a0a6ff5 6878
lintian-brush_0.17_amd64.buildinfo
Checksums-Sha256:
fa5fbf728d5339f6fa6bad16fc6ab2b46b394d265c29166bb20aacd85b2e1034 1886
lintian-brush_0.17.dsc
c505c0092a7639bea7e12e1d3d902d061aa8ae85fcc0c5d25dfa29e3079faa66 707144
lintian-brush_0.17.tar.xz
55cda8db843d927ba48e5296119d327dbf5a290217438bbfb8875911bf13ff70 6878
lintian-brush_0.17_amd64.buildinfo
Files:
3599ceaf4855afdc27afeb57ce0daffb 1886 devel optional lintian-brush_0.17.dsc
07ea35d97b5f38e90c2e014075f2bbf8 707144 devel optional
lintian-brush_0.17.tar.xz
f59f079fb8d4471d92c581d8f82f50ad 6878 devel optional
lintian-brush_0.17_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEsjhixBXWVlpOhsvXV5wWDUyeI+gFAl042GwACgkQV5wWDUye
I+h4GRAAgAJVQp9ZjuyNoj3EMirWfNC3FZB9XMRrD8//NOm41B3Xv7Wz1xil4Br9
D+eY1GTQloo28mjakpKgj6thjCFbsGL2WJYsHrFmVYcFp/DapAfFc2WzGyibR26H
RB37cQSKule26+xsZiT/p9LMvAQ+nV5+hkvKHOHvODFjfVb7+QSprnV7ngO4Ybt8
oMIp+SMJrEQ6pya8DpGefzSLL4MyX4RwgU8ozVJDY7JVOXuVMWbbpKA7L33yNkiD
lBPA7H3FsGFOB9jphQTIV9dhROyS0Zz/+61g1jd8R+Hkr8FVtX2Qkcj4WHA2yyx1
/VxR/8ojbDgIyvasNZyE148nBWrNDKUqFl3fnFMUTrAgaiMiJqqxRnEXSY0ymd2T
+ELFIPMcgkbJ+nlggkpG3B1rawRq0d/tANN+w6pMKLsQMgwrUUSAwBXphHDEMSCn
hVaFn61DwV8zwzqZD+XTcZrblQ+WmzZCmYQT0HqPK4ONfjCH8CyHxa2xwxBP0GJf
MFYJqQ264Oa3kDH3u7i53Ajf7qafen7/wn6lmZnGyEWsMm9ywf9L5+rsf2q1IjzJ
KvgjOO+J/0c8T4YOx+maWUORpra0Q83u3ewdqayJNtYN0s3teJnNMsnPaRP/nAbb
Z2G9b2RHsTCTHlPV3aVPvNJcO1zizU4TqD0VQAg9ZxrtJMn0dwE=
=Yeq0
-----END PGP SIGNATURE-----
--- End Message ---
