Your message dated Fri, 11 Oct 2019 10:19:39 +0000
with message-id <[email protected]>
and subject line Bug#896171: fixed in parted 3.3-1
has caused the Debian Bug report #896171,
regarding parted wrongly identifies an msdos partition table as 'atari'
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
896171: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=896171
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: parted
Version: 3.2-17


I have a valid & pretty standard Windows 10 system on a hard disk with three NTFS partitions: a small boot partition, a 465 GB main partition and a small restore partition. The structure is created by fsdisk from a Clonezilla live distribution. After the partitions are created, parted identifies my partition table as "atari" with a single partition. Any other tool I throw at it correctly sees an msdos partition table and I can boot windows 10 from the disk, so it appears there is nothing wrong with the disk. Also, it reproduces on 7 different PC's (albeit with pretty identical hardware).

I don't have a complete Debian system so my options are limited (no inernet access / reportbug), but this is the test I ran to reproduce the problem:

1.Run parted; it says I have an atari disk (even though it is a functional Windows 10 system) 2.Instruct parted to create a new dos partition table 3.Run parted; it says I have an msdos disk with no partitions (as expected)
4.Run sfdisk with sda-pt.sf from the Clonezilla image as input
5.sfdisk creates three NTFS partitions on the disk (as expected)
6.Run parted; it says I have an atari disk with one partition

See the full log at the end of this mail.

My understanding of the problem is that the code that makes parted recognize atari disks in isolated cases falsely indentifies a disk as Atari if the first blocks incidentally contain data that make (some) sense when interpreted as an Atari partition table. The chance of this happening is not high but also not zero (and apparently I got unlucky). See the parted list (Bug #31111 http://lists.gnu.org/archive/html/bug-parted/2018-04/msg00003.html) for a more detailed analysis.

The chance of this happening should be zero because If I would use parted to change anything on this disk it would probably destroy all data on it (i.e., pretty critical).

FUN FACT: If I change the size of sda2 from 975028224 to (e.g.) 975028222, the disk is no longer recognized as Atari & the problem vanishes.

Some info about my system:

I used the Clonezilla-live distribution alternate stable (clonezilla-live-2.5.2-31-i686)

uname -a
Linux zesty 4.10.0-33-generic #37-Ubuntu SMP Fri Aug 11 10:53:59 UTC 2017 i686 i686 i686 GNU/Linux

dpkg --status parted
Package: parted
Status: install ok installed
Priority: optional
Section: admin
Installed-Size: 156
Maintainer: Ubuntu Developers <[email protected]>
Architecture: i386
Version: 3.2-17
Replaces: fsresize, parted1.6
Depends: libc6 (>= 2.11), libparted2 (= 3.2-17), libreadline7 (>= 6.0), libtinfo5 (>= 6)
Suggests: parted-doc
Conflicts: fsresize, parted1.6
Description: disk partition manipulator
[snip]
Original-Maintainer: Parted Maintainer Team <[email protected]>
Homepage: http://www.gnu.org/software/parted

sfdisk from util-linux 2.29

dpkg --list util-linux
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name           Version         Architecture Description
+++-==============-===============-============-=================================
ii util-linux 2.29-1ubuntu2.1 i386 miscellaneous system utilities

NOTE:
I ran the same test from the GParted live distribution (gparted-live-0.31.0-1-i686), with the same results. uname -a --> Linux Debian 4.15.0-1-686 #1 SMP Debian 4.15.4-1 (2018-02-18) i686 GNU/Linux
/etc/debian_version: buster/sid
dpkg -- status parted: version 3.2-20.drbl1


/// LOG OF TEST PROCEDURE OUTLINED ABOVE ///
sudo parted /dev/sda print

Model: ATA WDC WD5000AAKX-6 (scsi)
Disk /dev/sda: 500GB
Sector size (logical/physical): 512B/512B
Partition Table: atari
Disk Flags:

Number  Start   End     Size    Type     File system  Flags
 1      8323MB  14.8GB  6446MB  primary               boot

sudo parted -s /dev/sda mklabel msdos
sudo parted /dev/sda print

Model: ATA WDC WD5000AAKX-6 (scsi)
Disk /dev/sda: 500GB
Sector size (logical/physical): 512B/512B
Partition Table: msdos
Disk Flags:

Number  Start  End  Size  Type  File system  Flags

sudo sfdisk --force /dev/sda

label: dos
label-id: 0x22a777ed
device: /dev/sda
unit: sectors

/dev/sda1 : start=        2048, size=      716800, type=17, bootable
/dev/sda2 : start=      718848, size=   975028224, type=7
/dev/sda3 : start=   975747072, size=     1024000, type=27
Checking that no-one is using this disk right now ... OK

Disk /dev/sda: 465.8 GiB, 500107862016 bytes, 976773168 sectors
Units: sectors of 1 * 512 = 512 bytes
Sector size (logical/physical): 512 bytes / 512 bytes
I/O size (minimum/optimal): 512 bytes / 512 bytes
Disklabel type: dos
Disk identifier: 0xcb89b023

Old situation:

Script header accepted.
Script header accepted.
Script header accepted.
Script header accepted.
Created a new DOS disklabel with disk identifier 0x22a777ed.

/dev/sda1: Created a new partition 1 of type 'Hidden HPFS/NTFS' and of size 350 MiB. /dev/sda2: Created a new partition 2 of type 'HPFS/NTFS/exFAT' and of size 465 GiB. /dev/sda3: Created a new partition 3 of type 'Hidden NTFS WinRE' and of size 500 MiB. /dev/sda4: Done.

New situation:

Device     Boot     Start       End   Sectors  Size Id Type
/dev/sda1  *         2048    718847    716800  350M 17 Hidden HPFS/NTFS
/dev/sda2          718848 975747071 975028224  465G  7 HPFS/NTFS/exFAT
/dev/sda3       975747072 976771071   1024000  500M 27 Hidden NTFS WinRE

The partition table has been altered.
Calling ioctl() to re-read partition table.
Syncing disks.

sudo parted /dev/sda print

Model: ATA WDC WD5000AAKX-6 (scsi)
Disk /dev/sda: 500GB
Sector size (logical/physical): 512B/512B
Partition Table: atari
Disk Flags:

Number  Start   End     Size    Type     File system  Flags
 1      8323MB  14.8GB  6446MB  primary               boot

// end

--- End Message ---
--- Begin Message ---
Source: parted
Source-Version: 3.3-1

We believe that the bug you reported is fixed in the latest version of
parted, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Colin Watson <[email protected]> (supplier of updated parted package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Fri, 11 Oct 2019 10:59:03 +0100
Source: parted
Architecture: source
Version: 3.3-1
Distribution: unstable
Urgency: medium
Maintainer: Parted Maintainer Team <[email protected]>
Changed-By: Colin Watson <[email protected]>
Closes: 880035 896171 930742 942159
Changes:
 parted (3.3-1) unstable; urgency=medium
 .
   * New upstream release (closes: #942159):
     - mkpart: Allow negative start value when FS-TYPE is not given (closes:
       #880035).
     - Fix atari label false positives (closes: #896171).
     - libparted: Fix MacOS boot support (closes: #930742).
   * Add Brian C. Lane's GPG key to debian/upstream/signing-key.asc.
Checksums-Sha1:
 633608a9887d06e5d9c5334fe2be75dd508259ea 3145 parted_3.3-1.dsc
 e639500f9587cf6fa9b0dbc08e5e760244614595 1757432 parted_3.3.orig.tar.xz
 4905eb9d7f60b1f0d6a1f0cbc2f4fdd8dfe91c1f 508 parted_3.3.orig.tar.xz.asc
 b995e4b333ca214dea5ad8ef1b9a302560732cd9 55916 parted_3.3-1.debian.tar.xz
Checksums-Sha256:
 0a69a7290795561eb465fdd6beaebaec52d1bec382347de6bd54cb23231e4b7f 3145 
parted_3.3-1.dsc
 57e2b4bd87018625c515421d4524f6e3b55175b472302056391c5f7eccb83d44 1757432 
parted_3.3.orig.tar.xz
 528d2d7b73b78aef96fb1b5f09a405387408459c856a0106ed0d13da50ae1f01 508 
parted_3.3.orig.tar.xz.asc
 78a8bcb02f9d005ca34a32bab2175bc5560d4f54fcb92dfd85fcc9bddff1c7a0 55916 
parted_3.3-1.debian.tar.xz
Files:
 e6e4d3a9259d0e467348e759e5ad05ce 3145 admin optional parted_3.3-1.dsc
 090655d05f3c471aa8e15a27536889ec 1757432 admin optional parted_3.3.orig.tar.xz
 f9522da55ad1a4e361724f12ab5decc1 508 admin optional parted_3.3.orig.tar.xz.asc
 8206ff8d14b07f52b3d78fb12c667bc1 55916 admin optional 
parted_3.3-1.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEErApP8SYRtvzPAcEROTWH2X2GUAsFAl2gUtMACgkQOTWH2X2G
UAtn4g/6A6dFykbrkmCn6SnhioIkfpvjPR5tzknMjbZVV23gePs3PJ/3HpU6xVJt
bGK8diEscvp84vW2olHA5qEoJ3DB+5oqqr+SRoqhlsfAuLw78r6tVbGC7YDvCk8B
H3k9b1/HDzw63v2RLLm2nHigz9ZoP+1pySJpV6tYWAw52KLXM6uLN9FLmn6OU3mh
HPaTrf/YOhYzawB4sSO899ss+0hSoLAok04W+/LxiA1da6174yLZSZobCsyisa4Z
7lJp+w4ac0wqQzKJSPymMQ+hH/YlswrUkN+Z23BSHnmnW07kX1DO8I0MDfveWt4L
pDdXECqFVw0brnWem7zflrZjN8JR3oHMFwsw9sQjVw15Qsg4jb94FidRG2xNEs7G
RksMhOb8j7X+tdXyk8CD31hBwWCW2dzO9FnAKTbJ4PExbfYcSKs2jLaBtIzwO/XL
yztRaHWQKADdKXaar5XjZUYBuHcDWxpmsRdg2elWlIsfACw3EdtGzJX2zCzuIPSE
5O+sQMUNcUr7wTgt92CnWG9RMI2HOv2TQ0bjRZng8WV84ARNEB9KNGhhr6G1eVf5
BHfJjdXsd2tKTN5gPp0AGJxt884aybMyfKJ2Z926XrOSpxYLqSapRQj1gRT5rqzZ
JenbAx8EZvGNk/mmj2Ximy45Cqo34P3+G0818e1gb3EIbagtLAw=
=sQM5
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to