Your message dated Thu, 24 Oct 2019 14:22:21 +0200
with message-id <[email protected]>
and subject line Re: Bug#731983: runtime warnings: in:imuxsock: unaligned
access to 0x0000000043765a09
has caused the Debian Bug report #731983,
regarding runtime warnings: in:imuxsock: unaligned access to 0x0000000043765a09
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
731983: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=731983
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: rsyslog
Version: 7.4.4-1
Tags: patch
rsyslog emits lots of warnings when it runs on the hppa platform:
[30191.672000] handle_unaligned: 61 callbacks suppressed
[30191.672000] in:imuxsock(1963): unaligned access to 0x0000000043765a09 at
ip=0x000000004255bbcb
[30191.676000] in:imuxsock(1963): unaligned access to 0x0000000043765a0d at
ip=0x000000004255bbeb
Those warnings can be eliminated with the attached patch, which ensures that
the values are copied to an aligned struct before usage.
It would be nice if you could apply this patch.
Helge
diff -up rsyslog-7.4.4/plugins/imuxsock/imuxsock.c.org rsyslog-7.4.4/plugins/imuxsock/imuxsock.c
--- rsyslog-7.4.4/plugins/imuxsock/imuxsock.c.org 2013-12-11 15:21:07.956000000 -0700
+++ rsyslog-7.4.4/plugins/imuxsock/imuxsock.c 2013-12-11 15:21:15.396000000 -0700
@@ -949,8 +949,8 @@ static rsRetVal readSocket(lstn_t *pLstn
struct msghdr msgh;
struct iovec msgiov;
struct cmsghdr *cm;
- struct ucred *cred;
- struct timeval *ts;
+ struct ucred cred_vals, *cred;
+ struct timeval time_vals, *ts;
uchar bufRcv[4096+1];
uchar *pRcv = NULL; /* receive buffer */
# if HAVE_SCM_CREDENTIALS
@@ -997,13 +997,13 @@ static rsRetVal readSocket(lstn_t *pLstn
# if HAVE_SCM_CREDENTIALS
if( pLstn->bUseCreds
&& cm->cmsg_level == SOL_SOCKET && cm->cmsg_type == SCM_CREDENTIALS) {
- cred = (struct ucred*) CMSG_DATA(cm);
+ cred = memcpy(&cred_vals, &CMSG_DATA(cm), sizeof(struct ucred));
}
# endif /* HAVE_SCM_CREDENTIALS */
# if HAVE_SO_TIMESTAMP
if( pLstn->bUseSysTimeStamp
&& cm->cmsg_level == SOL_SOCKET && cm->cmsg_type == SO_TIMESTAMP) {
- ts = (struct timeval *)CMSG_DATA(cm);
+ ts = memcpy(&time_vals, &CMSG_DATA(cm), sizeof(struct timeval));
}
# endif /* HAVE_SO_TIMESTAMP */
}
--- End Message ---
--- Begin Message ---
Version: 8.34.0-1
On Wed, 11 Apr 2018 10:38:13 -0400 Jason Duerstock
<[email protected]> wrote:
> This appears to be fixed in 8.34.0-1, at least on ia64. Helge, can
> you check if it is fixed HPPA as well?
>
> On Thu, Apr 5, 2018 at 8:28 PM, Jason Duerstock
> <[email protected]> wrote:
> > Package: rsyslog
> > Version: 8.33.1-1
> > Followup-For: Bug #731983
> > User: [email protected]
> > Usertags: ia64
> >
> > Dear Maintainer,
> >
> > This bug has been fixed upstream in this commit:
> > https://github.com/rsyslog/rsyslog/commit/64b6f5f7b924aa62a800c2e02e68cb498ed50acc
> >
> > Please add this patch to the package until 8.34 is released.
Since we haven't heard back from Helge, I'll take Jason's last feedback
and will close this bug report for version 8.34.0.
--
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?
signature.asc
Description: OpenPGP digital signature
--- End Message ---
