Your message dated Sat, 14 Dec 2019 09:34:28 +0000
with message-id <[email protected]>
and subject line Bug#945868: fixed in ros-rospkg 1.2.2-1
has caused the Debian Bug report #945868,
regarding ros-rospkg: OS detection is wrong for Ubuntu, uses deprecated LSB
instead of os-release
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
945868: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=945868
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: ros-rospkg
Version: 1.2.0-2
Severity: minor
Tags: patch
User: [email protected]
Usertags: origin-ubuntu focal ubuntu-patch
Dear maintainers,
In Ubuntu, the latest version of ros-rosdep was failing to build due to test
failures related to ros-rospkg, which was not properly detecting the
platform as Ubuntu. Digging into this, I found that ros-rospkg was relying
on the lsb_release command to detect Debian and Ubuntu as platforms; but
lsb_release is not part of the base system, so this fails when the
additional lsb-release package is not installed.
The attached patch fixes ros-rospkg to use os-release on Ubuntu, which works
for all supported releases. I have not looked to confirm that
/etc/os-release is also guaranteed to be present on all supported Debian
releases, but it probably is.
Thanks,
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer https://www.debian.org/
[email protected] [email protected]
diff -Nru ros-rospkg-1.2.0/debian/patches/series
ros-rospkg-1.2.0/debian/patches/series
--- ros-rospkg-1.2.0/debian/patches/series 2019-11-24 01:47:43.000000000
-0800
+++ ros-rospkg-1.2.0/debian/patches/series 2019-11-29 17:05:19.000000000
-0800
@@ -3,3 +3,4 @@
0003-Set-rosversion-to-Debian.patch
0004-Use-Python-in-instead-of-string-find.patch
0005-Replace-deprecated-platform-functions-with-distro.patch
+ubuntu-uses-fdo-not-lsb.patch
diff -Nru ros-rospkg-1.2.0/debian/patches/ubuntu-uses-fdo-not-lsb.patch
ros-rospkg-1.2.0/debian/patches/ubuntu-uses-fdo-not-lsb.patch
--- ros-rospkg-1.2.0/debian/patches/ubuntu-uses-fdo-not-lsb.patch
1969-12-31 16:00:00.000000000 -0800
+++ ros-rospkg-1.2.0/debian/patches/ubuntu-uses-fdo-not-lsb.patch
2019-11-29 17:09:14.000000000 -0800
@@ -0,0 +1,20 @@
+Description: Don't rely on LSB-based OS detection for Ubuntu
+ All recent versions of Ubuntu ship /etc/os-release, and the lsb_release
+ command is only available if the optional lsb-release package is
+ installed.
+Author: Steve Langasek <[email protected]>
+Last-Updated: 2019-11-29
+
+Index: ros-rospkg-1.2.0/src/rospkg/os_detect.py
+===================================================================
+--- ros-rospkg-1.2.0.orig/src/rospkg/os_detect.py
++++ ros-rospkg-1.2.0/src/rospkg/os_detect.py
+@@ -756,7 +756,7 @@
+ OsDetect.register_default(OS_QNX, QNX())
+ OsDetect.register_default(OS_RHEL, Rhel())
+ OsDetect.register_default(OS_SLACKWARE, Slackware())
+-OsDetect.register_default(OS_UBUNTU, LsbDetect("Ubuntu"))
++OsDetect.register_default(OS_UBUNTU, FdoDetect("ubuntu"))
+ OsDetect.register_default(OS_CLEARLINUX, FdoDetect("clear-linux-os"))
+ OsDetect.register_default(OS_NIXOS, FdoDetect("nixos"))
+ OsDetect.register_default(OS_WINDOWS, Windows())
--- End Message ---
--- Begin Message ---
Source: ros-rospkg
Source-Version: 1.2.2-1
We believe that the bug you reported is fixed in the latest version of
ros-rospkg, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Jochen Sprickerhof <[email protected]> (supplier of updated ros-rospkg
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sat, 14 Dec 2019 10:13:20 +0100
Source: ros-rospkg
Architecture: source
Version: 1.2.2-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Science Maintainers
<[email protected]>
Changed-By: Jochen Sprickerhof <[email protected]>
Closes: 945868
Changes:
ros-rospkg (1.2.2-1) unstable; urgency=medium
.
* New upstream version 1.2.2 (Closes: #945868)
* Drop upstreamed patches
Checksums-Sha1:
4edf3eb75490a69bfc814b3ab6491767210a0c09 2148 ros-rospkg_1.2.2-1.dsc
f17ab3fa724af1695de29555e578f769e15ba11f 90701 ros-rospkg_1.2.2.orig.tar.gz
964b8ab5876dc5da8e250d2d982d71c415258be3 3960 ros-rospkg_1.2.2-1.debian.tar.xz
9da15f7411125247f86f2ceb8cefbccf31df8a9e 6336
ros-rospkg_1.2.2-1_source.buildinfo
Checksums-Sha256:
244dc09b8e5f2ab05152ef6d5ea85ffc48c210cb0e92654bf01910e2242f6869 2148
ros-rospkg_1.2.2-1.dsc
8aa932bf3d2698ef4a566b418e6ac72b1a8972eb108c3f5948a967683796b11f 90701
ros-rospkg_1.2.2.orig.tar.gz
789ec6f4e6b6a71717d132302da8578a24a654688ef8c939b85ed2988a3b642e 3960
ros-rospkg_1.2.2-1.debian.tar.xz
56d52989b1aadd5d053cbaa474de9ee62a98e2251f3c5b53b6cb0b903d6d8125 6336
ros-rospkg_1.2.2-1_source.buildinfo
Files:
476eb89f38fc1a521dc6295b920a1e79 2148 python optional ros-rospkg_1.2.2-1.dsc
fefc3a7b5107647ac5ffc25db836e1f8 90701 python optional
ros-rospkg_1.2.2.orig.tar.gz
011ca9d0718d66a441a8ad5a8e436f86 3960 python optional
ros-rospkg_1.2.2-1.debian.tar.xz
bb85baa42b990a7a028298166c8bdaa9 6336 python optional
ros-rospkg_1.2.2-1_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEc7KZy9TurdzAF+h6W//cwljmlDMFAl30p9YACgkQW//cwljm
lDNpLw/9Gz01smE//kXQQztT/C/3Utn7Rejg0VA7+c+k3MEfCz73+QenjCVqd0br
+eHp889DFjkSgUfgOvg9sLUnjGLGIMRBVHSc+MT6a4u1xcBMjQP387srvTCLGq8e
v12Nc1W6TN6bCm3Y6qOS6tnEin7r9cuNb+C/1izreSDSFQN8HagYEpvFJcp7Admy
x2rYTc5eO3ahy9LMlb5HwINyTPcutkzr6ceveXEW4msGTQa4sSDblBwSZ47Sv4C/
oHq7aIbIpIz7Ah3dEmoi0fPDgxotTMGqsrEV6t4v75VCIq3ZP72MxyvPV9JfyEgM
vKvOX70DMjZiM73QUx7AvtjTkN0axUlt1o67vQ2YSR3I3UdYAYGWj7sr4g9VU+fo
gVZydxTtEQVvLu52uRYW/k4C1/4+YFj88oKX0uH48aELjRtYnbs4xa0DZ8+rR7OD
kvGzGz8lEnjWH1rNpmO0N39cz1yADyWePLkKW1FUELJnsBq0QEDXRNC1GyPak28I
XD+uLzQm6K1WQMsBEXjOI12N24UR3977fjkhHIilCdO1ECAb7jn9Lm2+K1c93HA/
NaYFFX0L0sMfTt8YRpQO53avOuDFoPUNugkQtCSlUWQPvkbFmyH/D9RPEJB+2tk8
6/y5w+OCmojxrgBnqpMOiU/v4vww1uEujYUpR/f94NvaRhF3/Xg=
=wL4+
-----END PGP SIGNATURE-----
--- End Message ---
