Your message dated Thu, 26 Dec 2019 18:04:36 +0000
with message-id <[email protected]>
and subject line Bug#946374: fixed in gdk-pixbuf 2.40.0+dfsg-2
has caused the Debian Bug report #946374,
regarding gdk-pixbuf: Please make autopkgtests cross-test-friendly
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
946374: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=946374
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: gdk-pixbuf
Version: 2.40.0+dfsg-1
Severity: minor
Tags: patch
User: [email protected]
Usertags: origin-ubuntu focal ubuntu-patch
Dear maintainers,
In Ubuntu, we are in the process of moving the i386 architecture to a
compatibility-only layer on amd64, and therefore we are also moving our
autopkgtest infrastructure to test i386 binaries in a cross-environment.
This requires changes to some tests so that they are cross-aware and can do
the right thing.
The gdk-pixbuf tests currently fail in this environment, because they are
build tests that do not invoke the toolchain in a cross-aware manner. I've
verified that the attached patch lets the tests successfully build (and run)
i386 tests on an amd64 host.
Note that upstream autopkgtest doesn't currently set DEB_HOST_ARCH so this
is a complete no-op in Debian for the moment. Support for cross-testing in
autopkgtest is currently awaiting review at
https://salsa.debian.org/ci-team/autopkgtest/merge_requests/69 and once
landed, will still have no effect unless autopkgtest is invoked with a '-a'
option. So this change should be safe to land in your package despite this
not being upstream in autopkgtest.
Thanks for considering,
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer https://www.debian.org/
[email protected] [email protected]
diff -Nru gdk-pixbuf-2.40.0+dfsg/debian/tests/build
gdk-pixbuf-2.40.0+dfsg/debian/tests/build
--- gdk-pixbuf-2.40.0+dfsg/debian/tests/build 2019-10-10 08:40:15.000000000
-0700
+++ gdk-pixbuf-2.40.0+dfsg/debian/tests/build 2019-12-07 16:54:50.000000000
-0800
@@ -8,6 +8,13 @@
WORKDIR=$(mktemp -d)
trap "rm -rf $WORKDIR" 0 INT QUIT ABRT PIPE TERM
cd $WORKDIR
+
+if [ -n "${DEB_HOST_GNU_TYPE:-}" ]; then
+ CROSS_COMPILE="$DEB_HOST_GNU_TYPE-"
+else
+ CROSS_COMPILE=
+fi
+
cat <<EOF > build_test.c
#include <gdk-pixbuf/gdk-pixbuf.h>
@@ -22,7 +29,7 @@
}
EOF
-gcc -o build_test build_test.c -Wall -Werror `pkg-config --cflags --libs
gdk-pixbuf-2.0`
+${CROSS_COMPILE}gcc -o build_test build_test.c -Wall -Werror
`${CROSS_COMPILE}pkg-config --cflags --libs gdk-pixbuf-2.0`
echo "build: OK"
[ -x build_test ]
./build_test
--- End Message ---
--- Begin Message ---
Source: gdk-pixbuf
Source-Version: 2.40.0+dfsg-2
We believe that the bug you reported is fixed in the latest version of
gdk-pixbuf, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Simon McVittie <[email protected]> (supplier of updated gdk-pixbuf package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Thu, 26 Dec 2019 16:33:27 +0000
Source: gdk-pixbuf
Architecture: source
Version: 2.40.0+dfsg-2
Distribution: unstable
Urgency: medium
Maintainer: Debian GNOME Maintainers
<[email protected]>
Changed-By: Simon McVittie <[email protected]>
Closes: 946374
Changes:
gdk-pixbuf (2.40.0+dfsg-2) unstable; urgency=medium
.
* Team upload
* d/tests/build: Mark as superficial
* d/tests/build: Make autopkgtest cross-test-friendly.
Use an appropriate cross-compiler and cross-pkg-config when using
proposed autopkgtest cross-testing support.
Thanks to Steve Langasek. (Closes: #946374)
* d/tests/build: Fail on references to unset variables
* d/tests/build: Fix shellcheck warnings
* Bump Standards-Version to 4.4.1
Checksums-Sha1:
91950050e3c97c3705d6f85f6b6f57e800cd1ec1 3055 gdk-pixbuf_2.40.0+dfsg-2.dsc
dc7193348bd37314a2c6d250b401276aeb9be6b3 17236
gdk-pixbuf_2.40.0+dfsg-2.debian.tar.xz
1ab1485e7a669b54740464c8e292c9ad2b1e2c40 8122
gdk-pixbuf_2.40.0+dfsg-2_source.buildinfo
Checksums-Sha256:
0932d7d1f8cada563aeb1bb766d5de55286a34c09a4248f0fdd5202e2770035d 3055
gdk-pixbuf_2.40.0+dfsg-2.dsc
d21d7d6cf39c6a921a475e6038e9fba96a54890063c708dd5b0e46735bcbe3d4 17236
gdk-pixbuf_2.40.0+dfsg-2.debian.tar.xz
2e71993af0e50799b9ff30a6490132dd5ae17bbf6be6db067699fd6f828ced62 8122
gdk-pixbuf_2.40.0+dfsg-2_source.buildinfo
Files:
7801dfb1a231b26554742fbce43a916d 3055 libs optional
gdk-pixbuf_2.40.0+dfsg-2.dsc
4843c76fe05c35436dee61c1d1f3ae29 17236 libs optional
gdk-pixbuf_2.40.0+dfsg-2.debian.tar.xz
291098053273e7b6a75b225aecef3bb1 8122 libs optional
gdk-pixbuf_2.40.0+dfsg-2_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJEBAEBCAAuFiEENuxaZEik9e95vv6Y4FrhR4+BTE8FAl4E8PYQHHNtY3ZAZGVi
aWFuLm9yZwAKCRDgWuFHj4FMT33tD/9qtuGqIo+VJ3bkG4Sltj9ndMIiouG85wM4
JISh16SwWfnHu1mV3IWgS5cLxmW4gjQm4P89H4XOygWMPQRxPDPoiMsb8bD2DlrX
Eo9RmKblaTSKEJbT+RDQpEc5ko7pDS0IhkggEqC/7dOpgBev2B/qgGZo9BLrMMXb
C7Dh4ilW4d39ip/GAGYUS6Ki6GA8bMUCS15cDdY9BNdPBiF6XCdu6GzJvXU+iCZF
qvAeNizZA7bilnqAjVmPBW8zA9qQhhmUHuL+/KAAAO3JP2GUwHR3P+oVMT3rOpDc
wg0gpWcm/tWiUc7kjKz24OD8caxsJq3QIaBMMsexxIFSsPpxRaAeYUOUz9Ka8hQD
8yxG5ODqR6TjnEsAnqB4j+uXCGZqfZMNKDGvpfYuF6ptOL3dvrBysrN/sdkK+5Ni
KAet1Gn8G2xoi9JybItB+YAVZ6WVcdvuzGG1QrLIqe3QYPDwFyQ6u+F7sL65JLk7
tXNnxGpQku3er+tgeVSacCI85A6nMP0OfUgwr7JUPAHMvDsxoEyvRWNolPpJ0TQq
LmMn95dODMWH9pQEXitsTNy615YLJX7cPRTQ5tcgpCNVdfzkHwi000Sp8qDVobx0
8eTIQ/A2OyCexUiEMi5VzLnGmBffw9RanYRKaVLVBvTTpbyMs9B3eTTMBiyUk9Dh
BASRwWAcQA==
=aYOL
-----END PGP SIGNATURE-----
--- End Message ---
