Your message dated Mon, 30 Dec 2019 21:34:19 +0000
with message-id <[email protected]>
and subject line Bug#946600: fixed in acpi-support 0.143-4
has caused the Debian Bug report #946600,
regarding acpi-support >= 0.143-2 breaks igb NICs
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
946600: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=946600
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: acpi-support

Version: 0.143-2

X-Debbugs-CC: [email protected], [email protected]

We have a fleet of HP Z840s (2015/2016) that recently upgraded to the
0.1432-2 version of acpi-support.  After the package updates, if the
computer is rebooted then eth0 NIC (with igb drivers) isn’t active and
can’t be brought up. The secondary NIC that uses e1000e drivers is
unaffected.

In an older bug (http://bugs.debian.org/728692) this occurred because there
was a bug with checking on_ac_power, and igb drivers don’t handle power
saving well. The new /lib/systemd/system/acpi-support.service doesn’t check
for ac_power, where the old init.d service config did.

 /etc/init.d/acpi-support

...

    on_ac_power

    if [ $? -eq 1 ]; then

        /etc/acpi/power.sh true

    fi

...

After the change from init.d to systemd an acpi-support.service unit was
added, that controls how hardware is detected and powered, and executes
/etc/acpi/power.sh script. It doesn’t explicitly check for ACPower so it
automatically enters into power saving mode.

The original /lib/systemd/system/acpi-support.service looked like this:

[Unit]

Description=ACPI support daemon

[Service]

Type=simple

ExecStart=/etc/acpi/power.sh true

[Install]

WantedBy=multi-user.target

We managed to fix the problem by modifying
/lib/systemd/system/acpi-support.service to check for AC Power, and execute
the power saving script only if the device is not plugged into any sort of
AC Power. This allowed our NICs with igb drivers to correctly activate on
boot:

[Unit]

Description=ACPI support daemon

[Service]

ConditionACPower=false

Type=simple

ExecStart=/etc/acpi/power.sh true

[Install]

WantedBy=multi-user.target

When the 0.143-2 version of this software is installed (without modifying
acpi-support.service) it sets both the igb and e1000e ethernet devices to
auto. When this happens e1000e NIC ports have their interfaces started and
are active, but igb ports do not have their interfaces started and are
inactive. Additionally, trying to manually bring up the network interfaces
with igb (sudo ifconfig eth0 up) still shows the interface as not connected
to the network.

>From /var/log/pm-powersave.log

Running hook /usr/lib/pm-utils/power.d/pci_devices true:

Setting Host Bridge 0000:00:00.0 to auto

Setting card reader device 0000:00:05.0 to auto

Setting card reader device 0000:00:05.1 to auto

Setting card reader device 0000:00:05.2 to auto

Setting Ethernet device 0000:00:19.0 to auto

Setting Audio device 0000:00:1b.0 to auto

Setting Audio device 0000:04:00.1 to auto

Setting Ethernet device 0000:05:00.0 to auto

With the modified version of /lib/systemd/system/acpi-support.service
instead of setting both ethernet devices to auto it sets them to on. This
correctly activates both the igb and e1000e drivers on boot.

>From /var/log/pm-powersave.log

Running hook /usr/lib/pm-utils/power.d/pci_devices false:

Setting Host Bridge 0000:00:00.0 to on

Setting card reader device 0000:00:05.0 to on

Setting card reader device 0000:00:05.1 to on

Setting card reader device 0000:00:05.2 to on

Setting Ethernet device 0000:00:19.0 to on

Setting Audio device 0000:00:1b.0 to on

Setting Audio device 0000:04:00.1 to on

Setting Ethernet device 0000:05:00.0 to on

I’ve tested this with both the 4.19.67-2 and 5.2.17-1 kernels and version
2.28-10 libc6

Relevant Ethernet Hardware Info from lspci:

00:19.0 Ethernet controller: Intel Corporation Ethernet Connection (2)
I218-LM (rev 05)

05:00.0 Ethernet controller: Intel Corporation I210 Gigabit Network
Connection (rev 03)

BIOS Information:

Vendor: Hewlett-Packard

Version: M60 v01.58

Release Date: 06/09/2015

Address: 0xF0000

Runtime Size: 64 kB

ROM Size: 16 MB

Characteristics:

PCI is supported

PNP is supported

BIOS is upgradeable

BIOS shadowing is allowed

Boot from CD is supported

Selectable boot is supported

EDD is supported

Print screen service is supported (int 5h)

8042 keyboard services are supported (int 9h)

Serial services are supported (int 14h)

Printer services are supported (int 17h)

ACPI is supported

USB legacy is supported

BIOS boot specification is supported

Function key-initiated network boot is supported

Targeted content distribution is supported

UEFI is supported

BIOS Revision: 1.58

--- End Message ---
--- Begin Message ---
Source: acpi-support
Source-Version: 0.143-4

We believe that the bug you reported is fixed in the latest version of
acpi-support, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Josue Ortega <[email protected]> (supplier of updated acpi-support package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Mon, 30 Dec 2019 15:14:11 -0600
Source: acpi-support
Architecture: source
Version: 0.143-4
Distribution: unstable
Urgency: medium
Maintainer: Josue Ortega <[email protected]>
Changed-By: Josue Ortega <[email protected]>
Closes: 940158 946600
Changes:
 acpi-support (0.143-4) unstable; urgency=medium
 .
   * Add condicion to check for AC Power in acpi-support.serice. Thanks
     to Shannon Brady for the patch <[email protected]> Closes: #946600
   * Remove pm-powersave invocation from debian/addons/scripts/power.sh.
     pm-powersave is no longer a package dependency. Closes: #940158
   * Bump Standards-Version to 4.4.1. No changes required
   * debian/control: Add Rules-Requires-Root field
Checksums-Sha1:
 9b53915369d9601f9fdfe2283d22d2523c89de56 2034 acpi-support_0.143-4.dsc
 72920811d85a53a03da455f8421083468b47af4b 44096 
acpi-support_0.143-4.debian.tar.xz
 4c6d6809febf89dddb1e0c01de91c87aa5ffebce 6244 
acpi-support_0.143-4_amd64.buildinfo
Checksums-Sha256:
 8825a91968bd48a4dca362fcbbf0a15de05ec0f3e4b1bb0249aa8530cb2dc2ff 2034 
acpi-support_0.143-4.dsc
 32331cf2343b6766f983734fe888df4eb2279838d0611daa2ce092c6916cb605 44096 
acpi-support_0.143-4.debian.tar.xz
 8e118178e19b32e70a464ec9f92d9761e3bd413872f67fd8a1ee4504ad8c9dbc 6244 
acpi-support_0.143-4_amd64.buildinfo
Files:
 93c29ec2faea4e758512c47af0c429da 2034 admin optional acpi-support_0.143-4.dsc
 4d2da12b55b8da5f47130ab0a74fbae9 44096 admin optional 
acpi-support_0.143-4.debian.tar.xz
 bdf90d32683684a48c00682aba65e6c3 6244 admin optional 
acpi-support_0.143-4_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJFBAEBCgAvFiEEdzOzKNJ5X1viMlrdAVCdXKtK/T8FAl4KacYRHGpvc3VlQGRl
Ymlhbi5vcmcACgkQAVCdXKtK/T8MxxAAqNuRLKaflOT90yMJvgax9+w82E6exKBi
3OoZsao1UCy/8tyBrRybzwu/6TYfKR2/27MTVfETfAgc1QqPQUERxh3eTTJABhg6
NsSDFcSSMURZ9nNW9L9i8QYGHpiiLGMDtC9J4Kljq9q2QcmguJ3R7fgmAO2wS6ET
PlIJn2luLPn+YkFikWt7/YG9sIWeLa0ycOSpPl7wLyyJjItghPaGijZJEDIVI3/k
UAc4Hvp5hVHxoopUP3JHV7GE6K/Ku0qFl2RSR7ni8pGnktanllBb1g3DTKWJR6OJ
yIuZXOBS7B2pOSFvqe+8E9QN/JYfEf1RKZu5nbo/8RDgISETC+NJTJd8AdZASfrC
6mRX5oDmIwI71u4m8CoGds4oznqfNn7dB99RB9yRKTR+vAdXy8C4R76KFtoxp7TV
qwJm+eyXiRe7s32YIr2+mBbvZIqEcJ9t13VHIdHwNER5p9phF15mnZMujCa5U2Y8
d2Pnmu/MG1sHXB1Iq4ujovpv8xZw4fQCmoKD9NNFV2gHTIdswWd+8JOwMjLc5fnz
eLI5UYTDOpRAMkXnQcA2muf9dtLDVZ5O1AB66Qr0sKxTaIvu555+o/nh52o23lx3
oAh6ZTRGcPldBKuXPeRr4ZPUtjS1KnVmVhMddzfJos1gtd4GqNPhYUTi3HaPju6E
ep+GqGJWr2E=
=DJ99
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to