Your message dated Thu, 02 Jan 2020 16:53:33 +0000 with message-id <[email protected]> and subject line Bug#946397: fixed in opendkim 2.11.0~beta2-1 has caused the Debian Bug report #946397, regarding Undefined behaviour when using miltertest’s mt.eom_check with MT_SMTPREPLY to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 946397: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=946397 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: opendkim-tools Version: 2.11.0~alpha-12 The MT_SMTPREPLY case in mt_eom_check prints two possibly-NULL char pointers via format string %s. This triggers undefined behaviour. On my machine, these pointers are printed as the string ‘(null)’. In any case this distorts the test result. The attached patch fixes this by making sure the two char pointers ‘esc’ and ‘text’ are only passed to snprintf when they are not NULL. --- a/miltertest/miltertest.c 2014-03-20 05:36:13.000000000 +0100 +++ b/miltertest/miltertest.c 2019-12-08 14:17:53.539942468 +0100 @@ -3645,8 +3645,8 @@ snprintf(rbuf, sizeof rbuf, "%s%s%s%s%s", smtp, - esc == NULL ? "" : " ", esc, - text == NULL ? "" : " ", text); + esc == NULL ? "" : " ", esc == NULL ? "" : esc, + text == NULL ? "" : " ", text == NULL ? "" : text); if (strcmp(rbuf, (char *) r->eom_rdata) == 0) {
signature.asc
Description: PGP signature
--- End Message ---
--- Begin Message ---Source: opendkim Source-Version: 2.11.0~beta2-1 We believe that the bug you reported is fixed in the latest version of opendkim, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. David Bürgin <[email protected]> (supplier of updated opendkim package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Tue, 31 Dec 2019 15:16:22 +0100 Source: opendkim Architecture: source Version: 2.11.0~beta2-1 Distribution: unstable Urgency: medium Maintainer: David Bürgin <[email protected]> Changed-By: David Bürgin <[email protected]> Closes: 859706 859797 878058 946397 Changes: opendkim (2.11.0~beta2-1) unstable; urgency=medium . * New upstream release. - Refresh patches, delete patch "openssl_1.1.0_compat.patch" incorporated upstream - Update symbols files, add Build-Depends-Package metadata - Drop outdated --enable-poll and --with-test-socket configure options * debian/rules: Build with hardening flags (patch by Christian Göttsche <[email protected]>; closes: #878058) * opendkim.service.generate script: Fix permissions of generated override files (patch by Christophe Siraut <[email protected]>; closes: #859797) * miltertest: Add patch fixing undefined behaviour in mt.eom_check() (Closes: #946397) * libopendkim-dev: Install only HTML files as documentation, and do so directly in /usr/share/doc/<package> (no subdirectory) as does upstream * Install convert_keylist.sh script in its documented location at /usr/bin/opendkim-convert-keylist, but keep old name around as a symlink * Replace all uses of /var/run with /run (Closes: #859706) * Add VCS repository coordinates * Bump standards version to 4.4.1 without further change Checksums-Sha1: b9459be5e94cc8fa4fa45564dae020af476d4ca6 2449 opendkim_2.11.0~beta2-1.dsc eae7683576475b44bd2198bbcfb417ea3a4bd9e5 793042 opendkim_2.11.0~beta2.orig.tar.gz 3b89ad5727ed4747e9b5cc88281c5ab022620d61 25372 opendkim_2.11.0~beta2-1.debian.tar.xz deb1b3fd7127b6df588398b2b94a6ccd7a70bb0c 5952 opendkim_2.11.0~beta2-1_source.buildinfo Checksums-Sha256: 7447f3b4c4cd377b1fae1fac09aa87a91168898886ed83b157c90537b560a5cf 2449 opendkim_2.11.0~beta2-1.dsc b3052047279fe6f114cc36b0080bd3db185ed0cc98363327ac5c53d511850016 793042 opendkim_2.11.0~beta2.orig.tar.gz 3f1fd9322d4049a539a954a17be8c5c1fbb1323d0c6c6cdc1a7273223bc4e19a 25372 opendkim_2.11.0~beta2-1.debian.tar.xz a0d7a7c23e9ffa584afb6064dd2f1b3c848bddb783d81c4c00477c9872cabd17 5952 opendkim_2.11.0~beta2-1_source.buildinfo Files: e57cf4e9d75f094174c7370403e2398b 2449 mail optional opendkim_2.11.0~beta2-1.dsc 0be899116b3246fc8a1ed42671ba005b 793042 mail optional opendkim_2.11.0~beta2.orig.tar.gz 9d74002f7dd2423baeefb95fc8fc9536 25372 mail optional opendkim_2.11.0~beta2-1.debian.tar.xz 5caf269bb6b9e9ebf9502bbeda7ba17d 5952 mail optional opendkim_2.11.0~beta2-1_source.buildinfo -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEkjZVexcMh/iCHArDweDZLphvfH4FAl4OGXwACgkQweDZLphv fH5Q0xAAwwa56YakIQCa8W2Ubme9WGJG2sqnNZM/20rwH/+xhfh2SrQqhZtUPb/c LKInVytwHKLZpBTHoFDQASxtZx+ULJv87819LT065HpYQXivWstEsW57VQhsIctw eDRgF1MXtMGHMfMUYGlbv0D7X8TTuIhFtsSki74dQN6m8pl7gFcJbVeVwTGLrBqF kbSb+yBHcZ0cBtxDGCqTG73N2mDdkl0u/yYQbMsG1maAen9/Fb5BmDZMrhdrKn/3 MYyoQy4DHRJ5JFsRAa/azFJ7s5sELkkfTwrpGUbukbu8llwNAtsZPHCAzg6CkwkR V77ShpLRqe5CQJg/SijHnosJLGgwpi0kEN8fsK3LU6yUmPElY1Yz1EpQCzrorC2Y bVVn6pwxvYqrS1ge6NZIMGnZGV19aMbGpMRM0KNRIp+yh6cYIM7GMCn71Q+zNcVw xGG3XI3NCqyX40s3HwONlF9dSUvFSaCB8Qqa4MAEWCSkzisGTURDWcLMwckNbRx2 +lWIk1LRyBEVJfx1JBfthoi+fHpN4qxmPjhGAi+pFj0LXh9H0L/s9aO/UXb4PVLT B5Dh3bQR5mZEuj1P+QDD5pgrdb+lYuUv3N8lBXL0n4IiEA2UaeaYvoEKz/Pfn8WW CODlDJv0qm7NBd3H7Z9BatflzdDCSgLkQU1EHoEl4+jUR0Rm+H0= =VHcY -----END PGP SIGNATURE-----
--- End Message ---
