Your message dated Sun, 05 Jan 2020 20:51:50 +0000 with message-id <[email protected]> and subject line Bug#775868: fixed in keepalived 1:2.0.19-1 has caused the Debian Bug report #775868, regarding keepalived: reload leaks file descriptors to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 775868: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=775868 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: keepalived Version: 1:1.2.13-1 Severity: wishlist Tags: patch When keepalived is reloaded using service keepalived reload (on controller nodes) it leaks file descriptors. Steps to reproduce: 1. Locate the vrrp keepalived process $ ps -elf |grep -i keepalived 1 S root 15129 1 0 80 0 - 12884 poll_s 16:47 ? 00:00:00 /usr/sbin/keepalived 5 S root 15132 15129 0 80 0 - 12990 poll_s 16:47 ? 00:00:00 /usr/sbin/keepalived 5 S root 15133 15129 0 80 0 - 12990 poll_s 16:47 ? 00:00:00 /usr/sbin/keepalived The vrrp process is usually the second process above i.e. 15132. 2. Count how many files it has open: $ sudo lsof -p 15132 |wc -l 34 3. Reload keepalived $ sudo service keepalived reload [ ok ] Reloading keepalived configuration....... 4. Count again $ sudo lsof -p 15132 |wc -l 35 I have tested with 1.2.14 of keepalived the problem is still there. The healthcheck daemon does a kernel_netlink_init and the cmd socket isn't closed on reload but a new one is opened. I can fix with this diff, but don't know if this is the correct way to do this: — keepalived-1.2.14/keepalived/check/check_daemon.c 2014-05-12 08:11:27.000000000 +0100 +++ keepalived-1.2.14.patched/keepalived/check/check_daemon.c 2014-12-16 15:50:20.342064582 +0000 @@ -71,6 +71,7 @@ stop_check(void) free_check_data(check_data); #ifdef WITH_VRRP free_interface_queue(); + kernel_netlink_close(); #endif #ifdef DEBUG @@ -196,6 +197,7 @@ reload_check_thread(thread_t * thread) free_checkers_queue(); #ifdef WITH_VRRP free_interface_queue(); + stop_check(); #endif free_ssl(); ipvs_stop(); Thank you for considering this patch, Heather
--- End Message ---
--- Begin Message ---Source: keepalived Source-Version: 1:2.0.19-1 We believe that the bug you reported is fixed in the latest version of keepalived, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Alexander Wirt <[email protected]> (supplier of updated keepalived package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Sun, 05 Jan 2020 18:45:43 +0100 Source: keepalived Binary: keepalived keepalived-dbgsym Architecture: source amd64 Version: 1:2.0.19-1 Distribution: unstable Urgency: medium Maintainer: Alexander Wirt <[email protected]> Changed-By: Alexander Wirt <[email protected]> Description: keepalived - Failover and monitoring daemon for LVS clusters Closes: 775868 859142 878241 931617 940036 942182 947472 Changes: keepalived (1:2.0.19-1) unstable; urgency=medium . * [3e69686] New upstream version 2.0.19 (Closes: #947472) - fixes execution of scripts with /bin/sh (Closes: #931617) - fixes configuration parsing for SMTP sections (Closes: #859142) - fixes stuck in receive queue (Closes: #942182) - close netlink in checker (Closes: #775868) - fix infinite loop when tracker script times out (Closes: #940036) - fix loading of libipset (Closes: #878241) * [6a81734] Move to debhelper(-compat) 12 * [02d9f5d] Bump standards version * [239c70f] Fix location of the ip_vs header file * [495b6e5] Disable dbus create instance feature * [ec5c22c] Enable iptc support Checksums-Sha1: ee4bce546944cbc31b1e07cfb0b88976e3dddd98 2091 keepalived_2.0.19-1.dsc 42c4ba1ae53acdd72f0f73ba275ae884f3ff73bb 1025062 keepalived_2.0.19.orig.tar.gz 42564b5fd9a48c432076922702f49c0ad3395682 10820 keepalived_2.0.19-1.debian.tar.xz 60e7f0b2736fea4e813a334773896657177aa2e1 912124 keepalived-dbgsym_2.0.19-1_amd64.deb 77d8c5de13ebd1048649acec7a77f0b8f978499d 7981 keepalived_2.0.19-1_amd64.buildinfo 4f2fed8c53acabc7f72dc28bd6de52bab21528b1 523004 keepalived_2.0.19-1_amd64.deb Checksums-Sha256: b20037249f7a48fc4ccffcf5e28545f733b5d71576c2da21ef7fc79200333742 2091 keepalived_2.0.19-1.dsc 0e2f8454765bc6a5fa26758bd9cec18aae42882843cdd24848aff0ae65ce4ca7 1025062 keepalived_2.0.19.orig.tar.gz bbb0eaf620901aaec4cd82c07839ba88d529380c9290eafa9a15eef41337d7ea 10820 keepalived_2.0.19-1.debian.tar.xz 9eb59e6690dfcbeff7412fc46eeefbfc9070f89a9228903efcbfcbed50979048 912124 keepalived-dbgsym_2.0.19-1_amd64.deb 5aa0a94cc8a7641690ed646bcdb0005afbb794e4bcd48a892327c24b9af09edc 7981 keepalived_2.0.19-1_amd64.buildinfo 35d83745f6b912f6f23748557048952d61c7fda8781ae5bff92ee450738deedf 523004 keepalived_2.0.19-1_amd64.deb Files: 7817d8b440a75ec232a6051d03a9a8bd 2091 admin optional keepalived_2.0.19-1.dsc df670e0904d4e48e72ccc8409ad9c6de 1025062 admin optional keepalived_2.0.19.orig.tar.gz 17f859811d9735fb5bb02359e201bf66 10820 admin optional keepalived_2.0.19-1.debian.tar.xz 1f2e93d221196bc1b3bc4b8d7f34a0fc 912124 debug optional keepalived-dbgsym_2.0.19-1_amd64.deb 087df2fce5309ced0161f70981ebd285 7981 admin optional keepalived_2.0.19-1_amd64.buildinfo 200cab35e2e853dff2194f9fc320fca6 523004 admin optional keepalived_2.0.19-1_amd64.deb -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEbjlmweHRXblz0FtJHkX4yp3iOxYFAl4SQUIACgkQHkX4yp3i OxZVnQ//dQp0h/2/EjEATC2hPcvZ7QHeWtJiquvzSO9QYfthXgjNhhfPZoqV6tUQ x5IlqtO3NV0YCzfndq2ZoP97HAx11ow7XyzoZ1QrxLqagcYrufnM9c9gVJ9BJ1bM 4mC+/WbaNetQNA5Ml/RKvOFvLrWdoouTuWMzLLytRtHpgIHudqgpiYRr4yMQirIv ruwC47w2R1cn5aBT3rKQbsLc0TSuGFx2yOGfWf28dX0nATYB/y5eIAvx7w9dQG63 PlKsex+cEqRiR/Ri3DE9XLjHcW+con+Ab2uorcdE2ApAYc99XmaJHLvDdar3yvdg xkdJ10K6XvE3sqjVVXUpuV4Fvg2corx/lTaTWcVAdrr2Bq156ABGTtkf4qA24xgN 1iipjbSs4lcw4IP6ZMXQPn6R2TKZWtJ8OzoJHhbT+XVOmf8+LIb3IgMeMN71gy2z Met96g2okws8VThykDMRcdZpC1xDsZalNPVN0M4EvD4KGFwndBVYJIkmcBsAZXI1 ogMrYrqYHtnVwDgeJsHBvA4KI8qqfBECTQEcuh9Mu6EYMroadY24W9BJcu7+7gxw 0d5NXNH2CtG6cY+qGakf6+ctvA3EGK1BQbZuy0u4vtRz+HjWmPGaLb5/VwkLBxQK sJrVkdMvGsfUSHy8cElJF5ZSmudn/0YecYkes5q3a5z4EAPGGYI= =I2I/ -----END PGP SIGNATURE-----
--- End Message ---
