Your message dated Sun, 19 Jan 2020 01:00:37 +0000
with message-id <[email protected]>
and subject line Bug#895329: fixed in pdbg 2.0-1
has caused the Debian Bug report #895329,
regarding pdbg: -lfdt must be in _LDADD, not _LDFLAGS, to work with Ubuntu 
toolchain
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
895329: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=895329
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: pdbg
Version: 1.0-1
Severity: normal
Tags: patch
User: [email protected]
Usertags: origin-ubuntu bionic ubuntu-patch

Dear Frédéric,

The pdbg package has been failing to build in Ubuntu because it supplies
options to the linker in the wrong order:

[...]
libtool: link: gcc -I./libpdbg -Wall -Werror -DGIT_SHA1=\"unknown\" -g -O3 
-fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat 
-Werror=format-security -Wl,--whole-archive -Wl,-lpdbg -Wl,--no-whole-archive 
-Wl,-Bsymbolic-functions -Wl,-z -Wl,relro -Wl,-z -Wl,now -o .libs/pdbg 
src/pdbg-main.o fake.dtb.o p8-fsi.dtb.o p8-i2c.dtb.o p9w-fsi.dtb.o 
p9z-fsi.dtb.o p9r-fsi.dtb.o p9-kernel.dtb.o  -lfdt ./.libs/libpdbg.so -L.libs
./.libs/libpdbg.so: undefined reference to `fdt_check_header'
./.libs/libpdbg.so: undefined reference to `fdt_get_name'
./.libs/libpdbg.so: undefined reference to `fdt_string'
./.libs/libpdbg.so: undefined reference to `fdt_offset_ptr'
./.libs/libpdbg.so: undefined reference to `fdt_next_tag'
collect2: error: ld returned 1 exit status
Makefile:568: recipe for target 'pdbg' failed
[...]

(https://launchpad.net/ubuntu/+source/pdbg/1.0-1)

Per <https://wiki.ubuntu.com/ToolChain/CompilerFlags#A-Wl.2C--as-needed>,
libraries must be passed on the commandline after the objects which
reference them, otherwise they will be discarded by the linker, resulting in
errors such as the above.

I have uploaded the attached patch to pdbg in Ubuntu.  Please consider
applying it in Debian as well.

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
[email protected]                                     [email protected]
diff -Nru pdbg-1.0/debian/patches/use-debian-libfdt.patch 
pdbg-1.0/debian/patches/use-debian-libfdt.patch
--- pdbg-1.0/debian/patches/use-debian-libfdt.patch     2017-10-06 
06:55:13.000000000 -0700
+++ pdbg-1.0/debian/patches/use-debian-libfdt.patch     2018-04-09 
16:18:46.000000000 -0700
@@ -2,10 +2,15 @@
  pdbg embeds libfdt, but in Debian libfdt is packaged and we prefer to make use
  of it. So we just disable that in Makefile.am and switch to the installed 
libfdt-dev
 Author: Frédéric Bonnard <[email protected]>
+Author: Steve Langasek <[email protected]>
+Last-Modified: 2018-04-09
+
 ---
 This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
---- a/Makefile.am
-+++ b/Makefile.am
+Index: pdbg-1.0/Makefile.am
+===================================================================
+--- pdbg-1.0.orig/Makefile.am
++++ pdbg-1.0/Makefile.am
 @@ -1,7 +1,5 @@
  GIT_SHA1 = `git --work-tree=$(top_srcdir) --git-dir=$(top_srcdir)/.git 
describe --always --long --dirty || echo unknown`
  
@@ -14,16 +19,16 @@
  bin_PROGRAMS = pdbg
  
  ACLOCAL_AMFLAGS = -Im4
-@@ -10,28 +8,16 @@
+@@ -10,28 +8,16 @@ AM_CFLAGS = -I$(top_srcdir)/ccan/array_s
  pdbg_SOURCES = \
        src/main.c
  pdbg_LDADD = fake.dtb.o p8-fsi.dtb.o p8-i2c.dtb.o p9w-fsi.dtb.o       \
 -      p9z-fsi.dtb.o p9r-fsi.dtb.o p9-kernel.dtb.o libpdbg.la libfdt.la \
+-      -L.libs
 +      p9z-fsi.dtb.o p9r-fsi.dtb.o p9-kernel.dtb.o libpdbg.la  \
-       -L.libs
++      -L.libs -lfdt
  
--pdbg_LDFLAGS = -Wl,--whole-archive,-lpdbg,--no-whole-archive
-+pdbg_LDFLAGS = -Wl,--whole-archive,-lpdbg,--no-whole-archive -lfdt
+ pdbg_LDFLAGS = -Wl,--whole-archive,-lpdbg,--no-whole-archive
  pdbg_CFLAGS = -I$(top_srcdir)/libpdbg -Wall -Werror -DGIT_SHA1=\"${GIT_SHA1}\"
  
 -lib_LTLIBRARIES = libpdbg.la libfdt.la

--- End Message ---
--- Begin Message ---
Source: pdbg
Source-Version: 2.0-1

We believe that the bug you reported is fixed in the latest version of
pdbg, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Frédéric Bonnard <[email protected]> (supplier of updated pdbg package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 07 Feb 2019 17:20:54 +0100
Source: pdbg
Binary: libpdbg-dev libpdbg1 libpdbg1-dbgsym pdbg pdbg-dbgsym
Architecture: source ppc64el
Version: 2.0-1
Distribution: unstable
Urgency: medium
Maintainer: Frédéric Bonnard <[email protected]>
Changed-By: Frédéric Bonnard <[email protected]>
Description:
 libpdbg-dev - PowerPC FSI Debugger library (development)
 libpdbg1   - PowerPC FSI Debugger library (runtime)
 pdbg       - PowerPC FSI Debugger
Closes: 895329
Changes:
 pdbg (2.0-1) unstable; urgency=medium
 .
   [ Ondřej Nový ]
   * d/control: Fix wrong Vcs-*
 .
   [ Frédéric Bonnard ]
   * Fix d/watch with new upstream prefix
   * Update upstream prefix in d/gbp.conf
   * Delete applied upstream d/Remove-usage-of-libfdt-internal-functions.patch
   * Rediff patch use-debian-libfdt.patch with 2.0 (Closes: #895329)
   * Add libpdbg symbol versioning : 1.0.0
   * Distribute libpdbg headers
   * Add libpdbg-dev package
   * Migrate to compatibility level 12
   * Remove dh autoreconf option
   * Update copyright information
   * Bump Standards-Version
   * Add Multi-Arch keywords in d/control
   * Do not override test target to not break check target
   * Add armel architecture
Checksums-Sha1:
 418210fc34cdc40cfe577fa329fbb4c98bdb7779 2012 pdbg_2.0-1.dsc
 1d86688b48c4f36df04a2da55fda21a0597f1459 131599 pdbg_2.0.orig.tar.gz
 b5fc61b3a9c5eae7e8cea788dd103d7264e90d19 9064 pdbg_2.0-1.debian.tar.xz
 359176f58488423d8bf97a81e5fab4d7e1ed7754 53536 libpdbg-dev_2.0-1_ppc64el.deb
 debe9d8a1efd5013dd2ca2d6b28e05f7c2076731 101044 
libpdbg1-dbgsym_2.0-1_ppc64el.deb
 cb5b51cd88ad471aa0ca5e98d71296fee911eb88 44884 libpdbg1_2.0-1_ppc64el.deb
 8bd009415c022215028f4558efbe489d80b94f7f 47516 pdbg-dbgsym_2.0-1_ppc64el.deb
 19484ec60948cdceb2130b1b2614c27e31dba0d5 7268 pdbg_2.0-1_ppc64el.buildinfo
 40b6f2387c504a2d231fd692a685e4f20fe5aca9 28020 pdbg_2.0-1_ppc64el.deb
Checksums-Sha256:
 6d0d1f4c6935e843f137c29ee0f160200fff38195de39e0c6d9ac5184d27e1e5 2012 
pdbg_2.0-1.dsc
 da65ebbd9a710555e9684472ee36fff37e897111034fcc2c07172cc39016d169 131599 
pdbg_2.0.orig.tar.gz
 d5b8080eccc9a56ce9ab28bae33cf7ab7ebe2956b1b56c8f6e20b43f87cea4c5 9064 
pdbg_2.0-1.debian.tar.xz
 e6cf27ee0a94b681946949f24edf02c87ab1482e6e679270eacbc5b0f6da1d7e 53536 
libpdbg-dev_2.0-1_ppc64el.deb
 3bb19abbbca3d565054e734e1d4b048bdad28edb8c615fa01efe89faed32249b 101044 
libpdbg1-dbgsym_2.0-1_ppc64el.deb
 e8ed3c142b2b3fa54eea8181a97096a88387d0a858229987d787d7c5e5f807a6 44884 
libpdbg1_2.0-1_ppc64el.deb
 35dd689b6aa45a6c258e2a0d7b9ca790e63a6b4a19609700ce89ade7c2c3aa82 47516 
pdbg-dbgsym_2.0-1_ppc64el.deb
 05ac8bc00b0b2c1e72308dd8525cb2b18b2046232c03275f37869e1d6d6cbea5 7268 
pdbg_2.0-1_ppc64el.buildinfo
 df3a9bcc1f1bb5e49737be5cab968acf6be54dde052418f84f429b8665dbb271 28020 
pdbg_2.0-1_ppc64el.deb
Files:
 24c1b913d4f17b17555d345d84b659d5 2012 misc optional pdbg_2.0-1.dsc
 e2ff58931571e71169472017c7d0a7ad 131599 misc optional pdbg_2.0.orig.tar.gz
 a329ac1c7fc4b19d874ba7577c97e83f 9064 misc optional pdbg_2.0-1.debian.tar.xz
 978f19c58375cbec748d53a1afff93a8 53536 libdevel optional 
libpdbg-dev_2.0-1_ppc64el.deb
 d3118cc9072a90709db84d56fc8f2e48 101044 debug optional 
libpdbg1-dbgsym_2.0-1_ppc64el.deb
 d0978334baa6a3258b23b1f3b86c6238 44884 libs optional libpdbg1_2.0-1_ppc64el.deb
 3934cfffd68fdc6f7b1419419a878335 47516 debug optional 
pdbg-dbgsym_2.0-1_ppc64el.deb
 734f1ac8ca40df3fe3d27d532fda2d9e 7268 misc optional 
pdbg_2.0-1_ppc64el.buildinfo
 572168a921d55ae1a1e2489f8b22a9e5 28020 misc optional pdbg_2.0-1_ppc64el.deb

-----BEGIN PGP SIGNATURE-----

iQJOBAEBCgA4FiEEh9vVdWFVIC7DiF6Ta3SY/LmzWKwFAlxdQWcaHGZyZWRpekBs
aW51eC52bmV0LmlibS5jb20ACgkQa3SY/LmzWKybeA/7BD3lzAGUvwmmIlm514x2
t+B9DcHEsARFI7TnnSRLXIqYjOc0x5ZVJhOTh3f7zauSrRF4fyXpSpZDtHV00Qc1
HraJBbSlqmI3S5vhGvYxQX4VJfTZuLev/++VzGjYan9iH56JMRHCfFlE9mWudUaa
HOteRaqMLwNM2G9VPZyZerwe2YKMXRtl1JUym75WV1SW2gHF363Dn3mMAeSSBOoP
fllrO8PZiGTw+5GI/Xu9zN1ZD40cQvE48xW/wrb3QmBnzTrE+d2P3noqBj1Jhq4z
XqmsYe+5JaZSpPI2LIeOgZyBjR1DtsCkK+VVxpna1VC04+5nEGE6qGBYGAntqzeO
CZq+xpuZ3l0e+nFcEc3jKaoBsjcjNz29GVzqf9tz9E8rAgeCqxY3EHP68Zgwj5qM
ELudKP1jCbNa+KzTddpZSZMVXY90204MC0aHakCY2jnF74zOVHArb07rGKjClt5q
ZitRtwWSDhZCx6CW7CUz0EU69kuc7tcOOJ2DobvY6yINTO29RIKniG6onRbXEKfa
LA35BGC+adTUTWeZCMk24mOjccNAS3FH2ECA3Xyjw+jtZ2TTsFCI9r88lTVP4u2q
GXwRIwnEPUGmUBrnq2bTggxSH5KSvkjH1plVhX7a6riV/SUw7hGYPdWrgsqvT3Y7
ug2RCtB2HPVsd7TzYeBwc6g=
=0fVJ
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to