Your message dated Sat, 01 Feb 2020 15:11:05 +0000
with message-id <[email protected]>
and subject line Bug#948891: fixed in licensecheck 3.0.42-1
has caused the Debian Bug report #948891,
regarding licensecheck --encoding utf8 exits on error when parsing binary files
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
948891: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=948891
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: licensecheck
Version: 3.0.39-1
Severity: normal

Dear Maintainer,

When used with --encoding utf8 option, licensecheck exits on error when
parsing png files.

This was found with scikit-learn package:
$ licensecheck --encoding utf8 --copyright --machine --deb-fmt --recursive 
doc/testimonials 
doc/testimonials/README.txt     UNKNOWN *No copyright*
doc/testimonials/testimonials.rst       UNKNOWN *No copyright*
utf8 "\xFF" does not map to Unicode at 
/usr/share/licensecheck/App/Licensecheck.pm line 358.
$ echo $?
25

Strace show that licensecheck is tripped by birchbox.jpg file:

$ strace licensecheck --encoding utf8 --copyright --machine --deb-fmt 
--recursive doc/testimonials
[snip]
stat("doc/testimonials/images/birchbox.jpg", {st_mode=S_IFREG|0644, 
st_size=14595, ...}) = 0
openat(AT_FDCWD, "doc/testimonials/images/birchbox.jpg", O_RDONLY|O_CLOEXEC) = 3
ioctl(3, TCGETS, 0x7ffe9ca1fc10)        = -1 ENOTTY (Inappropriate ioctl for 
device)
lseek(3, 0, SEEK_CUR)                   = 0
ioctl(3, TCGETS, 0x7ffe9ca1fc40)        = -1 ENOTTY (Inappropriate ioctl for 
device)
fstat(3, {st_mode=S_IFREG|0644, st_size=14595, ...}) = 0
read(3, "\377\330\377\340\0\20JFIF\0\1\1\1\0H\0H\0\0\377\342\7\270ICC_PROF"..., 
8192) = 8192
write(2, "utf8 \"\\xFF\" does not map to Unic"..., 93utf8 "\xFF" does not map 
to Unicode at /usr/share/licensecheck/App/Licensecheck.pm line 358.
) = 93
lseek(3, 0, SEEK_SET)                   = 0
lseek(3, 0, SEEK_CUR)                   = 0
close(3)                                = 0

I'd suggest to either:
- skip binary files
- read binary file without utf8 encoding (even if --encoding utf8 is used to 
run licensecheck)
- for image files, use exiftool or Image::Exif to extract license information 
from copyright tags See Image::ExifTool::TagNames for tag list (which 
unfortunately depend on file format)

All the best

Dod



-- System Information:
Debian Release: bullseye/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable'), (1, 
'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.4.0-2-amd64 (SMP w/8 CPU cores)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_WARN, TAINT_OOT_MODULE, 
TAINT_UNSIGNED_MODULE
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages licensecheck depends on:
ii  libgetopt-long-descriptive-perl        0.104-1
ii  liblog-any-adapter-screen-perl         0.140-1
ii  liblog-any-perl                        1.707-1
ii  libmoo-perl                            2.003006-1
ii  libnamespace-clean-perl                0.27-1
ii  libpath-iterator-rule-perl             1.014-1
ii  libpath-tiny-perl                      0.108-1
ii  libpod-constants-perl                  0.19-1
ii  libre-engine-re2-perl                  0.13-4+b1
ii  libregexp-pattern-license-perl         3.1.99-1
ii  libregexp-pattern-perl                 0.2.11-1
ii  libscalar-list-utils-perl              1:1.53-1
ii  libsort-key-perl                       1.33-2+b2
ii  libstrictures-perl                     2.000006-1
ii  libstring-copyright-perl               0.003006-1
ii  libstring-escape-perl                  2010.002-2
ii  libtry-tiny-perl                       0.30-1
ii  perl                                   5.30.0-9
ii  perl-base [libscalar-list-utils-perl]  5.30.0-9

licensecheck recommends no packages.

Versions of packages licensecheck suggests:
ii  bash-completion  1:2.9-1

-- no debconf information

--- End Message ---
--- Begin Message ---
Source: licensecheck
Source-Version: 3.0.42-1

We believe that the bug you reported is fixed in the latest version of
licensecheck, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Jonas Smedegaard <[email protected]> (supplier of updated licensecheck package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 01 Feb 2020 14:38:48 +0100
Source: licensecheck
Architecture: source
Version: 3.0.42-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Perl Group <[email protected]>
Changed-By: Jonas Smedegaard <[email protected]>
Closes: 948891
Changes:
 licensecheck (3.0.42-1) unstable; urgency=medium
 .
   [ upstream ]
   * new release(s)
     + fix gracefully skip to next file on failure decoding a file
       (broken since release 3.0.38);
       closes: bug#948891, thanks to Dominique Dumont
 .
   [ gregor herrmann ]
   * autopkgtests: skip use.t
   * autopkgtests: set PERL5LIB for smoke test.
   * autopkgtests: add empty debian/tests/pkg-perl/syntax-skip
 .
   [ Jonas Smedegaard ]
   * build-depend on libtest-command-simple-perl
     (not libtest-script-perl)
   * autopkgtests: fix override path to licensecheck in environment;
     thanks to Gregor Hermann for the suggestion
   * tests: set licensecheck script executable
   * autopkgtests: skip t/encoding.t (fails to setup UTF-8 environment)
Checksums-Sha1:
 81b13275dd183f3533c10a1533b84b2338936007 2673 licensecheck_3.0.42-1.dsc
 053960034ddb325143c8e0f431f83e6e6db7e8b6 382734 licensecheck_3.0.42.orig.tar.gz
 b5382c64a74dd169bd69d04b6eb6b63a5abd9607 28432 
licensecheck_3.0.42-1.debian.tar.xz
 9e71168a39157c29a34943f4e8ee00c974a42cc9 7555 
licensecheck_3.0.42-1_amd64.buildinfo
Checksums-Sha256:
 c7aedb7e34c958c3daaf97dd5a6d196407b6cf58ad529ac3b6877c9ec82d934d 2673 
licensecheck_3.0.42-1.dsc
 1e896c94c84d80b7156943662b60fa0134a1bf01a0ff3ddc090a51acab7c633e 382734 
licensecheck_3.0.42.orig.tar.gz
 04113d9c05650b55f56dd9439bede117784dcc68eb59440173b172167be0e402 28432 
licensecheck_3.0.42-1.debian.tar.xz
 f6fd860b3a00b19aa96c595dcb7d0807fb56e5aa4a290e1caac7a922235023b6 7555 
licensecheck_3.0.42-1_amd64.buildinfo
Files:
 ce3aeb25da5e9a330e51d5f726b959c6 2673 admin optional licensecheck_3.0.42-1.dsc
 43a04646c2882e9b6f8c031cd3e584df 382734 admin optional 
licensecheck_3.0.42.orig.tar.gz
 32ffbc05912767d18f656efaafc59972 28432 admin optional 
licensecheck_3.0.42-1.debian.tar.xz
 e5cfa3f62241e1fa2a0d9a9f64f06ca5 7555 admin optional 
licensecheck_3.0.42-1_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEn+Ppw2aRpp/1PMaELHwxRsGgASEFAl41f9UACgkQLHwxRsGg
ASHjDA/+PxxMWwnIGn8Kt7FKYhz9yjps92zLTQ3cNxqgDl+VgDG/qE/T+yVo5tUl
i2GgbTgasOL0ZGqVqjAf3Y/iLtX3uegbMkzSXvEMfboYQ+wjxShxRoVO+Ka7uDcu
LxMA1/qz5wiCnKocsuH3ges25xK2IDEglI/kUuwpLogHOuGNKiEde8NdIykeHfmm
zBWNNADTZl6F/XslMOUPTVhMaQf312JOvAj4ZLNkT3DkqdB34P70iR/wbVi/gQjW
+CbGQH6UiVC6Ag/d5B6oFwTunik4uXocOR0hi8YLWYXKXwpglC296iXKC0myRmIx
RIf6rpVyA/+/6dNdADVZ/kqufUhvPu+yKAIzuzjC17IF/SnhUZLfQMOI1igW/QEq
YloW+jB7FhVfm/JCtdPnmsjLqsXgp0O3NgRFAwD+n+lqMiB33PWiU9V2Uw1SOtdN
5KNBdyKqvPqHPlWIVCUy5Hrx+CffaOreh7szMurE4hx/1XqLx0ycZkfNoEX7WCr9
bAVm8Tsz9YVDKYmYaYo5i8FLyUjx2UpY0sGrSY8P0rrhZ+500/mk4ousuHaStlCz
5uEcS89rbxCk731ormEUlzyMj9R6G4vDPkizrtBim2ifppz27LtASSfvJmuhIqBC
XBECnFdPK5RCjGYPWlvIonEbI0MUB7yFpa3aGlCkyGC08vP4Cus=
=khM6
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to