Your message dated Sat, 08 Feb 2020 07:34:19 +0000
with message-id <[email protected]>
and subject line Bug#949684: fixed in mcomix 1.2.1mcomix3+git20200206-1
has caused the Debian Bug report #949684,
regarding mcomix: please make the build reproducible
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
949684: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=949684
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: mcomix
Version: 1.2.1mcomix3+git20200122-1
Severity: wishlist
Tags: patch
User: [email protected]
Usertags: filesystem
X-Debbugs-Cc: [email protected]
Hi,
Whilst working on the Reproducible Builds effort [0] I noticed that
mcomix could not be built reproducibly.
Specifically, variations were observed between the modification times
of the /usr/share/mcomix directory between two builds:
- 2020-01-22 05:02:54
+ 2020-01-17 13:20:55
The first of these is the time taken the latest entry in the Debian
changelog via the SOURCE_DATE_EPOCH[1] mechanism and the second is
upstream's original timestamp.
After some investigation I discovered that this was due to the
nondeterministic ordering of files in UNIX filesystems: upstream's
installer.py script was attempting to ensure that generated GNU
gettext .po files were created in directories that inherited the
original timestamps around them. However, if these .po files happened
to be processed for install before, for example, the Python scripts,
due to the order in which they existed on the filesystem, then it
would inherit a different timestamp and result in the variation seen
above.
This non-intuitive result has — of course — a trivial-looking fix,
namely to ensure that upstreams's installer.py script recurses into
any subdirectories in a sorted and thus determinstic order:
def scandir(root,dest,pool=None):
for r,dl,fl in walk(root):
+ dl.sort()
for f in fl:
yield r,f,dest,pool
[0] https://reproducible-builds.org/
[1] https://reproducible-builds.org/specs/source-date-epoch/
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` [email protected] / chris-lamb.co.uk
`-
--- a/debian/patches/reproducible-build.patch 1970-01-01 01:00:00.000000000
+0100
--- b/debian/patches/reproducible-build.patch 2020-01-23 15:49:59.572926655
+0000
@@ -0,0 +1,14 @@
+Description: Make the build reproducible
+Author: Chris Lamb <[email protected]>
+Last-Update: 2020-01-23
+
+--- mcomix-1.2.1mcomix3+git20200122.orig/installer.py
++++ mcomix-1.2.1mcomix3+git20200122/installer.py
+@@ -61,6 +61,7 @@ def install(srcdir,filename,target,pool)
+
+ def scandir(root,dest,pool=None):
+ for r,dl,fl in walk(root):
++ dl.sort()
+ for f in fl:
+ yield r,f,dest,pool
+
--- a/debian/patches/series 2020-01-23 15:19:31.120441310 +0000
--- b/debian/patches/series 2020-01-23 15:27:00.106822832 +0000
@@ -0,0 +1 @@
+reproducible-build.patch
--- a/installer.py 2020-01-23 15:19:31.120441310 +0000
--- b/installer.py 2020-01-23 15:49:58.524896459 +0000
@@ -61,6 +61,7 @@
def scandir(root,dest,pool=None):
for r,dl,fl in walk(root):
+ dl.sort()
for f in fl:
yield r,f,dest,pool
--- End Message ---
--- Begin Message ---
Source: mcomix
Source-Version: 1.2.1mcomix3+git20200206-1
We believe that the bug you reported is fixed in the latest version of
mcomix, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Emfox Zhou <[email protected]> (supplier of updated mcomix package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sat, 08 Feb 2020 15:00:41 +0800
Source: mcomix
Architecture: source
Version: 1.2.1mcomix3+git20200206-1
Distribution: unstable
Urgency: medium
Maintainer: Krzysztof Klimonda <[email protected]>
Changed-By: Emfox Zhou <[email protected]>
Closes: 949684
Changes:
mcomix (1.2.1mcomix3+git20200206-1) unstable; urgency=medium
.
* New upstream release
- set mtime of parent directory after msgfmt finished
(Closes: #949684)
Checksums-Sha1:
715d8277510719b1acc94210747ee63dcc960a58 1925
mcomix_1.2.1mcomix3+git20200206-1.dsc
9aa8608bc4a6e0bd9c5ecc275c37cc335bc3409b 2939868
mcomix_1.2.1mcomix3+git20200206.orig.tar.xz
ed79c985a50ce26ec43692adcef39a732abe01c4 3144
mcomix_1.2.1mcomix3+git20200206-1.debian.tar.xz
862f146b98e8cd2f1df31ed25f57245f54db7c82 6243
mcomix_1.2.1mcomix3+git20200206-1_amd64.buildinfo
Checksums-Sha256:
281cbbf33cf017cda6ae4683369c102bcfc5005aa4f19b6c0e8c9e3384f184a9 1925
mcomix_1.2.1mcomix3+git20200206-1.dsc
b53eebf43092941689ff012a18ea4c9545156ffd3515953dc598bfff8dde54cd 2939868
mcomix_1.2.1mcomix3+git20200206.orig.tar.xz
1e7458f57048b04db551a059552da24de952a2dc27554e125714f19a91fbecc7 3144
mcomix_1.2.1mcomix3+git20200206-1.debian.tar.xz
3b000c7f7330913c7d51f891dac92ff0a22248cf3ee30448683c062c18f98d2c 6243
mcomix_1.2.1mcomix3+git20200206-1_amd64.buildinfo
Files:
adb286e0b91f5f2c903d9edfa19b26b2 1925 x11 optional
mcomix_1.2.1mcomix3+git20200206-1.dsc
a7983efe9ac153f24eb2a98e007b056a 2939868 x11 optional
mcomix_1.2.1mcomix3+git20200206.orig.tar.xz
02459cdcb33336dba17943b78460aeb8 3144 x11 optional
mcomix_1.2.1mcomix3+git20200206-1.debian.tar.xz
91a93b27fe8a4641ffe86f59f9362ed3 6243 x11 optional
mcomix_1.2.1mcomix3+git20200206-1_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEGSauJtItZVqOiaNpgImbv9t7vZQFAl4+XtcACgkQgImbv9t7
vZQutA//Z0A6+seDdb5vo+GrM8WLgDzv34vwrOnphiqaL6Ske6BozOQQw9/rSZVt
vpw/dBqHcsDBOlYp/Nqf+6+7S8FPhZJ4itBGxhg9Xo9AoYSebu0Lhd18sIh4FbpO
OC6MEvn1s/oBiQJWRSHkOlxgxdXV71U2uMLOYTEgk2jpVuCFhRlUl6kT7Awe0tpV
qnfXeeOChl0yfD9hg9Vi2XHO0VoFNbir4ofhDEv4AfYtDdQyHay1Bo9F2IjCUm4G
hhvFGyJ44l3J6zOfqTl8u2HEsvAogZs/kEiHIWVkSks5Or73sT1ZeyV19Bst69yV
J2rxG2SRgIZXlRfHPBwQQMR3qiF4S8d+kKmWs1+g6tyDPjo4nxynFF6kyM5K+TX3
Mo8ZPswv+fukclrj6rqZZK6A4ZRYuFDbovCx7XtJlafDn805cdvorf5RNtqN6n/y
zQ5SEbYBedjVwufKPzCnpN24Y+ZEby9Ce8COJhPPG22Ydf1AkU/PzzrSmglPDGwR
4cQ1Tsvh4IQc/uawstq6XKKMx0Pzb3hPPEIPMZzBZjLzEhLfNsJsBU/Bdi8oUash
YdFqptd6PvF+6p6aqV+JFEr/aKkAPSR9nd8Y0cu8GgVTYbnCWBI703UEReDLJf9l
UGV0L8l1MLHEFnBK18Kx8UwPdZV6uklbopUDPFOuCGy/xaCP9as=
=l36t
-----END PGP SIGNATURE-----
--- End Message ---
