Your message dated Wed, 12 Feb 2020 16:19:23 +0000
with message-id <[email protected]>
and subject line Bug#951206: fixed in ltt-control 2.11.1-2
has caused the Debian Bug report #951206,
regarding "Error: Rotation feature not supported by the kernel tracer."
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
951206: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=951206
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: lttng-tools
Version: 2.11.1-1ubuntu1
Severity: normal

Dear Maintainer,

lttng-tools introduced a regression wrt session rotation when tracing
kernel domain - for more detailed info and a simple reproducer, see here:

https://bugs.launchpad.net/ubuntu/+source/ltt-control/+bug/1862936

See the attached debdiff for a fix (that i already applied & tested locally).

-- System Information:
Debian Release: bullseye/sid
  APT prefers focal-proposed
  APT policy: (500, 'focal-proposed'), (500, 'focal')
Architecture: amd64 (x86_64)

Kernel: Linux 5.4.0-14-generic (SMP w/8 CPU cores)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, 
TAINT_UNSIGNED_MODULE
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to 
C.UTF-8), LANGUAGE=C.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to C.UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages lttng-tools depends on:
ii  libc6              2.30-0ubuntu3
ii  libkmod2           26-3ubuntu1
ii  liblttng-ctl0      2.11.1-1
ii  liblttng-ust-ctl4  2.11.0-1
ii  libpopt0           1.16-14
ii  liburcu6           0.11.1-2
ii  libuuid1           2.34-0.1ubuntu6
ii  libxml2            2.9.4+dfsg1-8ubuntu3
ii  lsb-base           11.1.0ubuntu2

Versions of packages lttng-tools recommends:
ii  babeltrace  1.5.8-1

Versions of packages lttng-tools suggests:
ii  lttng-modules-dkms  2.10.8-1ubuntu2

-- no debconf information
diff -Nru ltt-control-2.11.1/debian/changelog 
ltt-control-2.11.1/debian/changelog
--- ltt-control-2.11.1/debian/changelog 2020-02-06 21:50:54.000000000 +0000
+++ ltt-control-2.11.1/debian/changelog 2020-02-12 12:30:52.000000000 +0000
@@ -1,3 +1,9 @@
+ltt-control (2.11.1-1ubuntu1) focal; urgency=medium
+
+  * Fix session rotation within kernel domain tracing (LP: #1862936)
+
+ -- Paolo Pisati <[email protected]>  Wed, 12 Feb 2020 12:30:52 +0000
+
 ltt-control (2.11.1-1) unstable; urgency=medium
 
   * [47b26b1] New upstream version 2.11.1
diff -Nru 
ltt-control-2.11.1/debian/patches/0002-Fix-sessiond-check-for-lttng-modules-ABI-2.1-rather-.patch
 
ltt-control-2.11.1/debian/patches/0002-Fix-sessiond-check-for-lttng-modules-ABI-2.1-rather-.patch
--- 
ltt-control-2.11.1/debian/patches/0002-Fix-sessiond-check-for-lttng-modules-ABI-2.1-rather-.patch
   1970-01-01 00:00:00.000000000 +0000
+++ 
ltt-control-2.11.1/debian/patches/0002-Fix-sessiond-check-for-lttng-modules-ABI-2.1-rather-.patch
   2020-02-12 12:29:59.000000000 +0000
@@ -0,0 +1,43 @@
+From 3029bc92f20d249ebea8779e46f6007aa0519b9a Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?J=C3=A9r=C3=A9mie=20Galarneau?=
+ <[email protected]>
+Date: Thu, 19 Dec 2019 22:13:10 -0500
+Subject: [PATCH] Fix: sessiond: check for lttng-modules ABI 2.1 rather than
+ 2.8
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+The clear patchset introduces a regression that breaks session
+rotations when the kernel domain is used. The 2.8 lttng-modules ABI
+does not exist yet.
+
+The packet sequence number functionality was introduced in LTTng 2.8,
+which introduced the 2.1 kernel tracer ABI.
+
+Signed-off-by: Jérémie Galarneau <[email protected]>
+Change-Id: Ief97e7e25f6f0fcb5b5b97b39abb417c1eb327ec
+---
+ src/bin/lttng-sessiond/kernel.c | 5 +++--
+ 1 file changed, 3 insertions(+), 2 deletions(-)
+
+diff --git a/src/bin/lttng-sessiond/kernel.c b/src/bin/lttng-sessiond/kernel.c
+index 1f987ef7..2626e98b 100644
+--- a/src/bin/lttng-sessiond/kernel.c
++++ b/src/bin/lttng-sessiond/kernel.c
+@@ -1445,9 +1445,10 @@ int 
kernel_supports_ring_buffer_packet_sequence_number(void)
+       }
+ 
+       /*
+-       * Packet sequence number was introduced in 2.8
++       * Packet sequence number was introduced in LTTng 2.8,
++       * lttng-modules ABI 2.1.
+        */
+-      if (abi.major >= 2 && abi.minor >= 8) {
++      if (abi.major >= 2 && abi.minor >= 1) {
+               /* Supported */
+               ret = 1;
+       } else {
+-- 
+2.25.0
+
diff -Nru ltt-control-2.11.1/debian/patches/series 
ltt-control-2.11.1/debian/patches/series
--- ltt-control-2.11.1/debian/patches/series    2020-02-06 21:14:42.000000000 
+0000
+++ ltt-control-2.11.1/debian/patches/series    2020-02-12 12:30:28.000000000 
+0000
@@ -1,2 +1,3 @@
 0001-Fix-compile-fails-for-x32-arch.patch
 fix-lttng-health-check-manpage.patch
+0002-Fix-sessiond-check-for-lttng-modules-ABI-2.1-rather-.patch

--- End Message ---
--- Begin Message ---
Source: ltt-control
Source-Version: 2.11.1-2

We believe that the bug you reported is fixed in the latest version of
ltt-control, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Michael Jeanson <[email protected]> (supplier of updated ltt-control package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 12 Feb 2020 10:58:54 -0500
Source: ltt-control
Architecture: source
Version: 2.11.1-2
Distribution: unstable
Urgency: medium
Maintainer: Jon Bernard <[email protected]>
Changed-By: Michael Jeanson <[email protected]>
Closes: 951206
Changes:
 ltt-control (2.11.1-2) unstable; urgency=medium
 .
   * [3aeb42e] Fix session rotation with kernel domain (Closes: #951206)
Checksums-Sha1:
 40d5ee39d850345ae3873f34c830fae7388cc922 2635 ltt-control_2.11.1-2.dsc
 784c00b8bf6862d0d8c3beb5f1f10db595b5990d 1491891 
ltt-control_2.11.1.orig.tar.bz2
 e9740a4203d5862131f0ffac76d505955e2e836b 833 
ltt-control_2.11.1.orig.tar.bz2.asc
 68956da193f35fdf77dea7338051c73e87affc07 21060 
ltt-control_2.11.1-2.debian.tar.xz
 d4eb7853a6640d128199b8aa26daec206836ba57 8335 
ltt-control_2.11.1-2_source.buildinfo
Checksums-Sha256:
 a976b70655f3091e6d89050b8ca5bfaf4cdebef722151ed48b1e2c7b33b7acd5 2635 
ltt-control_2.11.1-2.dsc
 00ea7a5247f17b2cb211b4fabe09a4d97ba8deb51420a378586b4d72d443f115 1491891 
ltt-control_2.11.1.orig.tar.bz2
 86fd6a89647decf68fe98ea61977e99244b8bb84e55576668454417ee857ab64 833 
ltt-control_2.11.1.orig.tar.bz2.asc
 575e684ce4d4057755c7221f9225443312abcf11c6b3520d6946342592dcd8e5 21060 
ltt-control_2.11.1-2.debian.tar.xz
 11ae7d7c18adb3570df583f4ddc19cca67e2e685f6ba7937dd143a3c0a02ba85 8335 
ltt-control_2.11.1-2_source.buildinfo
Files:
 00683081950bfce71aadb2fb85a39a4b 2635 libs optional ltt-control_2.11.1-2.dsc
 f0ecaa3ca44f6f20aa4cc70256f3c9f7 1491891 libs optional 
ltt-control_2.11.1.orig.tar.bz2
 f8928c6b803cc11e6aa5fa4edc6536c6 833 libs optional 
ltt-control_2.11.1.orig.tar.bz2.asc
 fe2c222b0c0ec284d1bea8f7608902b7 21060 libs optional 
ltt-control_2.11.1-2.debian.tar.xz
 db8aa59556f6c71344baf769d7bfa642 8335 libs optional 
ltt-control_2.11.1-2_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJIBAEBCgAyFiEEmGYkMkK2Qid54gtihlYfRSGA/P4FAl5EIbkUHG1qZWFuc29u
QGRlYmlhbi5vcmcACgkQhlYfRSGA/P4/ZQ/6AvKSA3RfzDhXFE7H/dhSf6Vj6DOJ
6j4xk1i1xSAvbSW+eaWEAV2PlJnz+QuVuLrk3QG2/Dh3KS+bf5v1M9gmGvo5isjX
iLeKv2LxZgnGdu0fFrkdS8XmJn1fzc70jO35nNU3yk+6k55EslL+9rLI4iPY7t2z
JTjOBioJYj6vtx/qXuj3qVukiVVpbNgy5Mi+7fm8fUrqcAYeyzVyzSylJIPu/KwP
vIlJS++G0lyq3C1zvD5dSNF9O0EUTgoKFiA89WjHYTErpgV5A6Radty7Po5k0C/O
3VuunrdveDQvMAs6zAHj3EKx+Ii74dMHQ4yYmUC23wPn75qAsOw3LykaO95Rh3v9
MZBctNx5dWNuITt+1o4uq8dgSj7wWYZUdA+237D2+4g8bY8q4fcT1BKbk0NeXTki
6HmmnAvg30CEKURXJ7bD0QbJmwlInpejv8C24qE9j7zFALnSOoh4ZOnwRayeDC9q
i4OLzH2Wjl5qGvB0TYShtjB7YopYyg1in4ljrR/CfSxLDWWZrPKK5z9sa3Cv/YJy
EmhraxOh45AXmg+UehEemUeDmnUNG2MDMv32qxnacG/O+DKEiDkqhWfAoBT2YFrO
tN/6AvN4D+mJSzZtSNoB2UdPH/psBxqkSDVc7RnOZRmK9okrnIlqq/dbiUX6JXQV
fecYTM4SwKcYfJ4=
=1d23
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to