Your message dated Sun, 23 Feb 2020 17:08:43 +0000
with message-id <[email protected]>
and subject line Bug#911178: fixed in jconvolver 1.0.3-1
has caused the Debian Bug report #911178,
regarding jconvolver FTCBFS: builds for the wrong architecture
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
911178: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=911178
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: jconvolver
Version: 0.9.3-2
Tags: patch
User: [email protected]
Usertags: rebootstrap
jconvolver fails to cross build from source, because it builds for the
wrong architecture. For one thing, the upstream Makefile hard codes the
build architecture compiler "g++". Making it substitutable is part of
the solution. Then jconvolver does not build anything during
dh_auto_build. The actual build is performed during make install and no
cross tools are passed at that point. Replacing all those overrides with
a --sourcedirectory flag fixes that part as well and makes jconvolver
cross buildable. Please consider applying the attached patch.
Helmut
diff --minimal -Nru jconvolver-0.9.3/debian/changelog
jconvolver-0.9.3/debian/changelog
--- jconvolver-0.9.3/debian/changelog 2016-12-20 16:03:48.000000000 +0100
+++ jconvolver-0.9.3/debian/changelog 2018-10-16 21:26:18.000000000 +0200
@@ -1,3 +1,12 @@
+jconvolver (0.9.3-2.1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Fix FTCBFS: (Closes: #-1)
+ + Avoid overrides using dh --sourcedirectory.
+ + cross.patch: Make g++ substitutable.
+
+ -- Helmut Grohne <[email protected]> Tue, 16 Oct 2018 21:26:18 +0200
+
jconvolver (0.9.3-2) unstable; urgency=medium
[ James Cowgill ]
diff --minimal -Nru jconvolver-0.9.3/debian/patches/cross.patch
jconvolver-0.9.3/debian/patches/cross.patch
--- jconvolver-0.9.3/debian/patches/cross.patch 1970-01-01 01:00:00.000000000
+0100
+++ jconvolver-0.9.3/debian/patches/cross.patch 2018-10-16 21:26:18.000000000
+0200
@@ -0,0 +1,29 @@
+--- jconvolver-0.9.3.orig/source/Makefile
++++ jconvolver-0.9.3/source/Makefile
+@@ -37,7 +37,7 @@
+ JCONVOLVER_O = jconvolver.o config.o jconfig.o audiofile.o sstring.o
jclient.o
+ jconvolver: LDLIBS += -lzita-convolver -lfftw3f -lsndfile -lclthreads
-ljack -lpthread -lrt
+ jconvolver: $(JCONVOLVER_O)
+- g++ $(LDFLAGS) -o $@ $(JCONVOLVER_O) $(LDLIBS)
++ $(CXX) $(LDFLAGS) -o $@ $(JCONVOLVER_O) $(LDLIBS)
+ $(JCONVOLVER_O):
+ -include $(JCONVOLVER_O:%.o=%.d)
+
+@@ -46,7 +46,7 @@
+ FCONVOLVER_O = fconvolver.o config.o fconfig.o audiofile.o sstring.o
+ fconvolver: LDLIBS += -lzita-convolver -lfftw3f -lsndfile -lpthread -lrt
+ fconvolver: $(FCONVOLVER_O)
+- g++ $(LDFLAGS) -o $@ $(FCONVOLVER_O) $(LDLIBS)
++ $(CXX) $(LDFLAGS) -o $@ $(FCONVOLVER_O) $(LDLIBS)
+ $(FCONVOLVER_O):
+ -include $(FCONVOLVER_O:%.o=%.d)
+
+@@ -55,7 +55,7 @@
+ MAKEMULTI_O = makemulti.o audiofile.o
+ makemulti : LDLIBS += -lsndfile -lrt
+ makemulti: $(MAKEMULTI_O)
+- g++ $(LDFLAGS) -o $@ $(MAKEMULTI_O) $(LDLIBS)
++ $(CXX) $(LDFLAGS) -o $@ $(MAKEMULTI_O) $(LDLIBS)
+
+
+ install: all
diff --minimal -Nru jconvolver-0.9.3/debian/patches/series
jconvolver-0.9.3/debian/patches/series
--- jconvolver-0.9.3/debian/patches/series 2014-02-26 13:05:14.000000000
+0100
+++ jconvolver-0.9.3/debian/patches/series 2018-10-16 21:25:04.000000000
+0200
@@ -1,3 +1,4 @@
makefile.patch
makefile2.patch
03-spelling.patch
+cross.patch
diff --minimal -Nru jconvolver-0.9.3/debian/rules jconvolver-0.9.3/debian/rules
--- jconvolver-0.9.3/debian/rules 2016-12-20 16:03:48.000000000 +0100
+++ jconvolver-0.9.3/debian/rules 2018-10-16 21:26:15.000000000 +0200
@@ -5,11 +5,4 @@
export DEB_BUILD_MAINT_OPTIONS = hardening=+all
%:
- dh $@
-
-override_dh_auto_clean:
- $(MAKE) -C source/ clean
- dh_auto_clean
-
-override_dh_auto_install:
- $(MAKE) -C source/ DESTDIR=$(CURDIR)/debian/jconvolver install
+ dh $@ --sourcedirectory=source
--- End Message ---
--- Begin Message ---
Source: jconvolver
Source-Version: 1.0.3-1
Done: Dennis Braun <[email protected]>
We believe that the bug you reported is fixed in the latest version of
jconvolver, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Dennis Braun <[email protected]> (supplier of updated jconvolver package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sun, 23 Feb 2020 17:45:31 +0100
Source: jconvolver
Architecture: source
Version: 1.0.3-1
Distribution: experimental
Urgency: medium
Maintainer: Debian Multimedia Maintainers <[email protected]>
Changed-By: Dennis Braun <[email protected]>
Closes: 911178 950808
Changes:
jconvolver (1.0.3-1) experimental; urgency=medium
.
* New upstream version 1.0.3
+ Fix FTCBFS: Make g++ substitutable (Closes: #911178)
* Use dh-compat instead of debian/compat
* d/control:
+ Change maintainer address to [email protected]
+ Add myself as an uploader
+ Bump dh-compat to 12
+ Make libzita-convolver-dev depend on >= 4.0.0 (Closes: #950808)
+ Bump Standards-Version to 4.5.0
+ Set Vcs-* to salsa.debian.org
+ Use https protocol for homepage
+ Set RRR: no
* d/copyright: Update year, http > https & add myself
* d/jconvolver.install: Add, to install the bins
* d/patches: Update patchset
* d/rules:
+ Add prefix, libdir and destdir exports
+ Fix installation
* d/source/local-options: Drop, obsolete
* d/watch: Use https protocol
Checksums-Sha1:
afa4fb03950411d7c59176bd7a84cd6a95fc0e5b 2287 jconvolver_1.0.3-1.dsc
2f7587600144bacc2345bc5ce5f91d8947913ea0 380769 jconvolver_1.0.3.orig.tar.bz2
20ead932684d0709adb21377cc987df3e6bb32a3 5496 jconvolver_1.0.3-1.debian.tar.xz
Checksums-Sha256:
3653dd1c858591686972c7f80aea1a1f184430d47655260f0e6137f440b05758 2287
jconvolver_1.0.3-1.dsc
e88cc61b792a7497544aa227861d38a39ac465021a793ba004dbbfbace8abbd3 380769
jconvolver_1.0.3.orig.tar.bz2
969cb2a1ffb10853b0eff27d3eef233d6787c3f20fe8f77dc7cbbec4dd122dce 5496
jconvolver_1.0.3-1.debian.tar.xz
Files:
1c6cde6e866ff66f50e0c75e5bf8e5b0 2287 sound optional jconvolver_1.0.3-1.dsc
812104df668b755919d3ffc0cde0e23d 380769 sound optional
jconvolver_1.0.3.orig.tar.bz2
fe44c5afe1bbf28e040ea4e479d17040 5496 sound optional
jconvolver_1.0.3-1.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEE94y6B4F7sUmhHTOQafL8UW6nGZMFAl5SrJ0ACgkQafL8UW6n
GZPbBBAAmk1y/1SAU2n11dagt8fjcfjgN2A1/dFwNtsOx6CD45Ulk7FT9bVysAcL
Twg7OhY/qwSuvKLengVb73Y371n+jMm8Veu9bxVsTAtR2l6lB0Fzf2EOnkl28xsR
B97WseOHKbFtNH7QpV5wLbD2Yn4IcCcl74QFYf6RXCBUBXNCIoSSeBfHlwnLJP94
CdUNUbmPcAPgdF/w0cv8WAUzh7WGlD43sKqUUKJQK4l6kGSDq+IWm/Naj+RWmHec
4gGSBVcK20bwccMXm9htf/gLwDRyX5OeDGSEKRqVnOUI6H4JSGGUrbGRSBO/Q4Y4
6kvrWO+/99XkO0Ls5hGHLezWG0o6tirYiltzMGg9GPScAtqHrKkyTUG+D5+rRofP
iuBBVO+fD4ZPttvbjYFTXsX5QY5UV4z+mfgMGfE3BOLKL5Mcs4GNnrwpNS2eKuKe
hWNF0a2o09uzuGv7/QZ5aZVt+PDb06rzTPP1IFKvLUAw38s98UJRHSpNyD4dF3gf
WlWZaxBSyx9qbcn+q8M4mPpqOTEl7gEe1HgZsvhPTmZE8pcS5yjkvB8CslGct+iQ
4dUP+GWTH7ssDF0rvCtaY9RsgjKkGFw4c/kyYAZVylmE+M0/p55zE1dwZ+uklWph
k14kxiX3S02kXkBr0og2oCC68LGRwMM60bmL64gSy6pZ+2lfuf0=
=rHny
-----END PGP SIGNATURE-----
--- End Message ---
