Your message dated Tue, 25 Feb 2020 19:19:32 +0000
with message-id <[email protected]>
and subject line Bug#850627: fixed in bless 0.6.0-7
has caused the Debian Bug report #850627,
regarding The preferences, session (last opened file, window geometry, cursor 
position) and history files are not saved correctly (Patch attached)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
850627: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=850627
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: bless
Version: 0.6.0-5
Severity: important
Tags: patch

Hi

Many problems (one was already reported in bug: #767216) arised because the
preferences
file, last session file, and history file are not saved correctly.

Cause:
The XML class used (XmlTextWriter) causes troubles (i,e, it can only write 1024
bytes
without being flushed, causing the preferences.xml to be cut off at 1024 bytes
so there
are errors when loading it.

Solution:
Change to the newer XmlWriterSettings.

Attachment:
Attached is a patch file which solves the saving of all these XML files using
the
newer XmlWriterSettings class.
Now all the files are saved and loaded correctly, so all functions like
temporary
directory, last open file, cursor position, remember window geometry and file
history
work again normally as they should.

Note that bug #767216 (which is caused only by an empty "Temporary Directory")
can be closed too as the Temporary directory will now be populated correctly.

Regards



-- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.8.0-2-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages bless depends on:
ii  libc6                         2.24-8
ii  libglade2.0-cil               2.12.40-1
ii  libglib2.0-cil                2.12.40-1
ii  libgtk2.0-cil                 2.12.40-1
ii  libmono-corlib4.5-cil         4.6.2.7+dfsg-1
ii  libmono-posix4.0-cil          4.6.2.7+dfsg-1
ii  libmono-system-xml4.0-cil     4.6.2.7+dfsg-1
ii  libmono-system4.0-cil         4.6.2.7+dfsg-1
ii  mono-runtime                  4.6.2.7+dfsg-1
ii  rarian-compat [scrollkeeper]  0.8.1-6

bless recommends no packages.

bless suggests no packages.

-- no debconf information
diff -Naurd bless-0.6.0.orig/src/tools/Preferences.cs bless-0.6.0/src/tools/Preferences.cs
--- bless-0.6.0.orig/src/tools/Preferences.cs	2008-06-07 14:18:14.000000000 +0200
+++ bless-0.6.0/src/tools/Preferences.cs	2016-10-28 22:47:50.000000000 +0200
@@ -127,10 +127,10 @@
 	///</summary>
 	public void Save(string path)
 	{
-		XmlTextWriter xml = new XmlTextWriter(path, null);
-		xml.Formatting = Formatting.Indented;
-		xml.Indentation = 1;
-		xml.IndentChar = '\t';
+		XmlWriterSettings settings = new XmlWriterSettings();
+		settings.Indent = true;
+		settings.IndentChars = ("\t");
+		XmlWriter xml = XmlWriter.Create(path, settings);
 
 		xml.WriteStartElement(null, "preferences", null);
 
diff -Naurd bless-0.6.0.orig/src/tools/Session.cs bless-0.6.0/src/tools/Session.cs
--- bless-0.6.0.orig/src/tools/Session.cs	2008-06-07 14:18:14.000000000 +0200
+++ bless-0.6.0/src/tools/Session.cs	2017-01-08 15:21:29.000000000 +0100
@@ -72,10 +72,10 @@
 
 	public void Save(string path)
 	{
-		XmlTextWriter xml = new XmlTextWriter(path, null);
-		xml.Formatting = Formatting.Indented;
-		xml.Indentation = 1;
-		xml.IndentChar = '\t';
+		XmlWriterSettings settings = new XmlWriterSettings();
+		settings.Indent = true;
+		settings.IndentChars = ("\t");
+		XmlWriter xml = XmlWriter.Create(path, settings);
 
 		xml.WriteStartElement(null, "session", null);
 

--- End Message ---
--- Begin Message ---
Source: bless
Source-Version: 0.6.0-7
Done: Jo Shields <[email protected]>

We believe that the bug you reported is fixed in the latest version of
bless, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Jo Shields <[email protected]> (supplier of updated bless package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 25 Feb 2020 14:09:28 -0500
Source: bless
Binary: bless
Architecture: source
Version: 0.6.0-7
Distribution: unstable
Urgency: medium
Maintainer: Debian CLI Applications Team 
<[email protected]>
Changed-By: Jo Shields <[email protected]>
Description:
 bless      - A full featured hexadecimal editor
Closes: 767216 850627
Changes:
 bless (0.6.0-7) unstable; urgency=medium
 .
   * [9d4017b] Fix save behaviour (Closes: #850627, 767216)
Checksums-Sha1:
 c871905944b1cc832a9bd1cbda35befb5208bfa1 1695 bless_0.6.0-7.dsc
 9df609e717b2bd427cf54de6043284b5e636f655 7332 bless_0.6.0-7.debian.tar.xz
 6caf54bf8a7a17874e2e9b476810bb58bcf32ffc 7050 bless_0.6.0-7_source.buildinfo
Checksums-Sha256:
 bfe69f37081125326643f01c5ea399d42b7e895474b405cd5f14f90ac8900167 1695 
bless_0.6.0-7.dsc
 f4e6949fbb8d5be43e25201da320a07e577ca63a4c50365b63338918151d92ba 7332 
bless_0.6.0-7.debian.tar.xz
 165b2c106d6d19abe6cbf4bae25d3ca0300678744405ae6d4f529cfc75d084f7 7050 
bless_0.6.0-7_source.buildinfo
Files:
 e0a7f3a90c84ba5678c4292179ccc857 1695 editors optional bless_0.6.0-7.dsc
 e3eb75b60352fdf4f60c701c6734d748 7332 editors optional 
bless_0.6.0-7.debian.tar.xz
 8b4ed9e5f46840605a8919bffb315a14 7050 editors optional 
bless_0.6.0-7_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQFLBAEBCgA1FiEEwQsMQnGBo0sbxf7dyQ+cuQ4frQwFAl5VcYcXHGpvc2hpZWxk
QG1pY3Jvc29mdC5jb20ACgkQyQ+cuQ4frQyuvgf9E23fYWK5I7WNMBVDz40ruGEV
2cKD8od6JMw2oQkGa5CQOe4Tda2QUPOZl47oAe+qAYpVBRXOB4mHoJFPA7IYYRVD
tsXRDcWFfOqj78G1cBObhTHroWmmxhIllVvqHdY1aa/+WXr9pT90K8dVTfxbJLOn
gVo/llcflmfj36Habc24o9a8jVyN/Lfhxl7VlYiLv0c1Cd2cQKqS/rKjE+4GtH4X
FQTActPRI/XrWHD8OGueRVTt1wvheYlYBIySpbTI57ZuQlIulzNCe7bcgXDSWb5V
GQxx+u49I1rQL413g4+CNGzKix5FqdTsM/1YqnE+P4+St9DvZAo6OHtSu7MQ1g==
=MGPK
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to