Your message dated Fri, 28 Feb 2020 19:09:13 +0000
with message-id <[email protected]>
and subject line Bug#952743: fixed in libdbi-drivers 0.9.0-9
has caused the Debian Bug report #952743,
regarding Test suite failures don't fail the build
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
952743: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=952743
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: libdbi-drivers
Version: 0.9.0-8
Tags: patch
User: [email protected]
Usertags: origin-ubuntu focal ubuntu-patch
Hi,
I noticed that the test suite during the build is currently failing,
including on the Debian buildds, but this isn't causing the package
built to fail.
Patch attached.
From 7bb6ed96a6900a6178ca390a3d2ce99c7ca4cacc Mon Sep 17 00:00:00 2001
From: Robie Basak <[email protected]>
Date: Thu, 27 Feb 2020 15:48:31 +0000
Subject: [PATCH] * d/p/test_exception_failure.patch: make test exceptions
fail the test suite and thus the build.
---
debian/patches/series | 1 +
debian/patches/test_exception_failure.patch | 28 +++++++++++++++++++++
2 files changed, 29 insertions(+)
create mode 100644 debian/patches/test_exception_failure.patch
diff --git a/debian/patches/series b/debian/patches/series
index ffca70f..975fbf4 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -7,3 +7,4 @@ dbd_sqlite3_resolve_a_stack_buffer_overflow.patch
freetds-1.0-fix.patch
pgsql_precision.patch
mysql-8.0.patch
+test_exception_failure.patch
diff --git a/debian/patches/test_exception_failure.patch b/debian/patches/test_exception_failure.patch
new file mode 100644
index 0000000..c871b95
--- /dev/null
+++ b/debian/patches/test_exception_failure.patch
@@ -0,0 +1,28 @@
+Author: Robie Basak <[email protected]>
+Description: make test exceptions fail the test suite and thus the build
+ Syntax-related issues in the MySQL tests were resulting in setup like INSERT
+ INTO to fail. This was resulting in a test exception rather than a failure,
+ causing the entire MySQL test suite to silently fail. This should instead cause
+ the build to fail, so patch the testsuite to treat exceptions as failures.
+Last-Update: 2020-02-27
+
+--- a/tests/cgreen/src/unit.c
++++ b/tests/cgreen/src/unit.c
+@@ -130,7 +130,7 @@
+ int run_test_suite(TestSuite *suite, TestReporter *reporter) {
+ setup_reporting(reporter);
+ run_every_test(suite, reporter);
+- int success = (reporter->failures == 0);
++ int success = (reporter->failures == 0 && reporter->exceptions == 0);
+ clean_up_test_run(suite, reporter);
+ return success ? EXIT_SUCCESS : EXIT_FAILURE;
+ }
+@@ -138,7 +138,7 @@
+ int run_single_test(TestSuite *suite, char *name, TestReporter *reporter) {
+ setup_reporting(reporter);
+ run_named_test(suite, name, reporter);
+- int success = (reporter->failures == 0);
++ int success = (reporter->failures == 0 && reporter->exceptions == 0);
+ clean_up_test_run(suite, reporter);
+ return success ? EXIT_SUCCESS : EXIT_FAILURE;
+ }
--
2.25.0
signature.asc
Description: PGP signature
--- End Message ---
--- Begin Message ---
Source: libdbi-drivers
Source-Version: 0.9.0-9
Done: Laszlo Boszormenyi (GCS) <[email protected]>
We believe that the bug you reported is fixed in the latest version of
libdbi-drivers, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Laszlo Boszormenyi (GCS) <[email protected]> (supplier of updated libdbi-drivers
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Fri, 28 Feb 2020 17:08:27 +0000
Source: libdbi-drivers
Architecture: source
Version: 0.9.0-9
Distribution: unstable
Urgency: medium
Maintainer: Laszlo Boszormenyi (GCS) <[email protected]>
Changed-By: Laszlo Boszormenyi (GCS) <[email protected]>
Closes: 952743 952744
Changes:
libdbi-drivers (0.9.0-9) unstable; urgency=medium
.
* Fix MariaDB test failure due to unsupported time zone literals
(closes: #952744).
.
[ Robie Basak <[email protected]> ]
* d/p/test_exception_failure.patch: make test exceptions fail the test
suite and thus the build (closes: #952743).
Checksums-Sha1:
849561a6ba22422d4e6d992653e67bbb4756bf24 2255 libdbi-drivers_0.9.0-9.dsc
af6462e681c9f02cc78496ab7e04266a994a2c5f 13280
libdbi-drivers_0.9.0-9.debian.tar.xz
Checksums-Sha256:
ce1ece0d5b10cf1670450744899280542b1ea8246252b51308b08c28b1146ef5 2255
libdbi-drivers_0.9.0-9.dsc
dd773b3289a8a95be49f0e1aeb8c78625074b7cb76b209670265f8e96eee54d0 13280
libdbi-drivers_0.9.0-9.debian.tar.xz
Files:
7e70a776187bb9edf48fb001b9964119 2255 libs optional libdbi-drivers_0.9.0-9.dsc
8903453ee0d341393124824ebdd6c66c 13280 libs optional
libdbi-drivers_0.9.0-9.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEfYh9yLp7u6e4NeO63OMQ54ZMyL8FAl5ZYPcACgkQ3OMQ54ZM
yL81zhAAozzD/u903irEcY49Gf+/jHuUHHEhm0c9Gvusi7781PI66zQgVu+gzKOo
+76FZO7cmJJwn7LZzN+Ae2/QYT6nS1x78WefHaCs6mCkmtJKfC5pbftszIWcHbwb
wW8AwzffEf5zDanwFoXIGukpenkSrx3w479A+b7pxmCKYibrbOoeFkiDJ3TXBIsT
8mwvkJl3TR59Z0uSWLamXYIkdZHldeidnTH5k0WusJG+jJRN7cczbiWGAM0FNtpm
teQwng4I0+AMJl5yeRy4LhOutVebACBsW/TfSkWPiRIp0xi/VZ6PJGWAM4yAaZtm
MVws5E4Mx/lsZ08R4/mNvLN43hblaPBRcwykv9yUxwLlRofiCZtc898OyOHZ+O7s
R+KY4MJRG5GAhFy/5+TdRK0QlSPKO6wBx/ry9dYw8dBqjPtlGkdcGyTGDMAuGMHf
j8yvq5mgcnbjUKVW+Zz3HbyvDQ/n0vPY2Lj22Iyo+9hxgT5wsQg92PqCUVTHBgiz
tk5Z4sGQQeSdOMsAP4sRo3KVHDhlvj0CbjcItGuNz9XqwD6p8hqJkmTvotXeB6En
Omrh7tHlRHRYPggkrdsnbmU7Fb36hW358tg7Si44S883STDctXxLpUWUsU3Gfla9
pgc58M+yLnapGosaF8yC49WBnkgN2yNsXlcZdnuy8wTPbgldXMM=
=oCBg
-----END PGP SIGNATURE-----
--- End Message ---
