Your message dated Mon, 02 Mar 2020 09:34:27 +0000
with message-id <[email protected]>
and subject line Bug#826998: fixed in php-imagick 3.4.4-4
has caused the Debian Bug report #826998,
regarding php-imagick: properly avoid openmp threads and use a non-soname
dependency
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
826998: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=826998
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: php-imagick
Version: 3.4.2-2
Severity: wishlist
Tags: patch
User: [email protected]
Usertags: origin-ubuntu yakkety ubuntu-patch
Dear Maintainer,
In Ubuntu, the attached patch was applied to achieve the following:
* Merge with Debian unstable (LP: #1590618). Remaining changes:
- Use libmagickwand-6.q16-dev | libmagickwand-dev as the test
dependency instead of hard-coding an soname that will require us
to update the tests file for each new ABI.
[ This is ostensibly cleaner than what I provided to Debian in Bug
#816724 ]
- debian/patches/no-openmp-threads.patch: limit the number of openmp
threads used to 1.
[ As is this. If we can't trust the tests to run with > 1 OpenMP
threads, we should probably limit it at all times with this library.
]
- Fix failures in autopkgtests (LP #1549942)
+ imagick-3.4.0RC6/tests/025-get-color.phpt: Do not do version
check, as Ubuntu has backported the referenced fixes.
[ I did not include this delta here, but I would like to. I do not
believe there has been any movement in Debian wrt. my submissions in
Debian #811308 or #816701.
And, in fact, #811308 has been re-marked fix, but that seems false,
as the version that fixes it is wheezy-security upload? I might just
missing something in the Debian process. ]
* Do not manually set MAGICK_THREAD_LIMIT in d/t/control, as the
number of threads are limited in the source.
[ superseded by the source change ]
* d/patches/: update 3.4.0RC6 to 3.4.2 for new upstream version.
[ if the imagemagick changes get picked by Debian, I'll send this with
a follow-on debdiff. ]
Thanks for considering the patch.
-- System Information:
Debian Release: stretch/sid
APT prefers xenial-updates
APT policy: (500, 'xenial-updates'), (500, 'xenial-security'), (500,
'xenial'), (100, 'xenial-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 4.4.0-22-generic (SMP w/4 CPU cores)
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
diff -Nru php-imagick-3.4.2/debian/patches/no-openmp-threads.patch php-imagick-3.4.2/debian/patches/no-openmp-threads.patch
--- php-imagick-3.4.2/debian/patches/no-openmp-threads.patch 1969-12-31 16:00:00.000000000 -0800
+++ php-imagick-3.4.2/debian/patches/no-openmp-threads.patch 2016-06-09 16:47:41.000000000 -0700
@@ -0,0 +1,23 @@
+Description: limit the number of openmp threads used to 1
+ The php-imagick 3.4.0 test suite fails with various segfaults when openmp
+ threads are in use. Force the openmp thread count to 1 to avoid this
+ problem.
+ .
+ This patch is a workaround only; it is currently unknown if the root bug
+ lies in php-imagick or in imagemagick.
+Author: Steve Langasek <[email protected]>
+Bug-Ubuntu: https://bugs.launchpad.net/bugs/1549942
+
+Index: php-imagick-3.4.0~rc6/imagick-3.4.2/imagick.c
+===================================================================
+--- php-imagick-3.4.0~rc6.orig/imagick-3.4.2/imagick.c
++++ php-imagick-3.4.0~rc6/imagick-3.4.2/imagick.c
+@@ -3579,6 +3579,8 @@
+ checkImagickVersion();
+ }
+
++ SetMagickResourceLimit(ThreadResource, 1);
++
+ return SUCCESS;
+ }
+
diff -Nru php-imagick-3.4.2/debian/patches/series php-imagick-3.4.2/debian/patches/series
--- php-imagick-3.4.2/debian/patches/series 2016-04-29 02:17:36.000000000 -0700
+++ php-imagick-3.4.2/debian/patches/series 2016-06-09 16:47:41.000000000 -0700
@@ -1 +1,2 @@
0001-Hardcode-path-to-usrsharefontstruetypettf-dejavuDeja.patch
+no-openmp-threads.patch
diff -Nru php-imagick-3.4.2/debian/tests/control php-imagick-3.4.2/debian/tests/control
--- php-imagick-3.4.2/debian/tests/control 2016-04-29 02:17:36.000000000 -0700
+++ php-imagick-3.4.2/debian/tests/control 2016-06-09 16:47:41.000000000 -0700
@@ -1,2 +1,2 @@
-Test-Command: cd imagick-*/tests && MAGICK_THREAD_LIMIT=1 phpunit --verbose .
-Depends: php-cli, php-imagick, gsfonts, libmagickcore-6.q16-2-extra, phpunit
+Test-Command: cd imagick-*/tests && phpunit --verbose .
+Depends: php-cli, php-imagick, gsfonts, libmagickwand-6.q16-dev | libmagickwand-dev, phpunit
--- End Message ---
--- Begin Message ---
Source: php-imagick
Source-Version: 3.4.4-4
Done: =?utf-8?b?T25kxZllaiBTdXLDvQ==?= <[email protected]>
We believe that the bug you reported is fixed in the latest version of
php-imagick, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Ondřej Surý <[email protected]> (supplier of updated php-imagick package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Mon, 02 Mar 2020 10:04:48 +0100
Source: php-imagick
Architecture: source
Version: 3.4.4-4
Distribution: unstable
Urgency: medium
Maintainer: Debian PHP PECL Maintainers <[email protected]>
Changed-By: Ondřej Surý <[email protected]>
Closes: 826998 854707
Changes:
php-imagick (3.4.4-4) unstable; urgency=medium
.
[ Ondřej Surý ]
* Pull Ubuntu changes to the php-imagick package (Closes: #854707, #826998)
.
[ Bryce Harrington ]
* d/t/control: Restore Restriction: needs-recommends since the tests
require the -extra libmagickcore package
* d/p/no-openmp-threads.patch: limit the number of openmp threads used
to 1.
* d/p/0003-Disable-test-014-which-fails-due-to-system-resources.patch:
Disable 014-setresourcelimit.phpt to fix autopkgtest failure. The test
describes itself as 'flaky', and appears to suffer from sensitivity to
system resource limit policies with ImageMagick.
.
[ Christian Ehrhardt ]
* d/rules: re-enable to fail on build time tests
* d/p/0004-Disable-remaining-tests-failing-with-7.4.patch to at least
retain the remaining coverage
Checksums-Sha1:
d21f662ae5870be56ec04a6b22213b199c7b5d3c 2269 php-imagick_3.4.4-4.dsc
86d682c82170e7a599f55fca8590b2c655801d21 13152
php-imagick_3.4.4-4.debian.tar.xz
9c9863816ee02fa7a161a19c009623e4d35a41d5 11724
php-imagick_3.4.4-4_amd64.buildinfo
Checksums-Sha256:
7ea9e8be0ccc9ad726b8d40b9406c3e9fe7fac80b5a06c3fec331aa41aa26a0e 2269
php-imagick_3.4.4-4.dsc
d934b5939dc61c3da9f76c04f159e086e2075de06a00e56ad8a436402832369b 13152
php-imagick_3.4.4-4.debian.tar.xz
6923cd816bc51718c5a4a6bbc0046ddba7701e3685d599ffa40989daf342bf31 11724
php-imagick_3.4.4-4_amd64.buildinfo
Files:
96caa0dc873792e969642c67d05396e4 2269 php optional php-imagick_3.4.4-4.dsc
481c462325e58d5bb2551a81bfd9583f 13152 php optional
php-imagick_3.4.4-4.debian.tar.xz
bcd3e7b136b384e742ddf32f629d80a3 11724 php optional
php-imagick_3.4.4-4_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQKTBAEBCgB9FiEEw2Gx4wKVQ+vGJel9g3Kkd++uWcIFAl5czdZfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEMz
NjFCMUUzMDI5NTQzRUJDNjI1RTk3RDgzNzJBNDc3RUZBRTU5QzIACgkQg3Kkd++u
WcJH1Q//SX468TBex4nwxvXhVPCCzxtgGHzZrmmiCOgIolXuy4fbHL/Gb+AiiX5v
qS1l0WvxPdxr2ju6CjPDAjcuOoKPf55XAiUINHpjjPAWh2pImso0EUx9Ot3dznrd
loWSVuS5ccMR3AcQPIAHlyHf4g+TVrLka6SocLU835xCmV6w5+F6ZBdR3Qd3wuS7
HlZuYuKZpaKwceIcPtj+CXhnByy/+gIvR364p/iiUy7PY1pj7wJd256+CNqoPY0x
zmz06wUa6NHhcsxosu80ZHLoA+7YENu8TajiA9IjbzmC/SbUbOrEZoI4tuLE6Qzb
G/V8DAD9Ut2BXecNmwCUnj3JlJclIuT7NlSOSSXTvefTeaNY/tKDoFrJuNunniZ3
ximtniaL08ExppbQYTscnYuLv3K1R4ezGFDODFX6c4nTWobzxRSsuHPs6wq0YGYp
nHHa0tG0A5cxy31LSCRSDMrToLNmMNTPcl364qRruVsdSnE2AEQxxQJCG7rbNgxR
QtsS1D6gsroF2YXND48zNizUFB44EZG4Wkkr9QEcMnrxRuoWZL30afMHcPpJOXXC
OYThNbJNmh49uhOWRsHTGrTsij+Bg6L+7C9OVo0nJQvgBZSRCB5MG/O+hsdNb1P1
9gdXTE3NJnuXQ7on2rRbSe0fw7cKRb7GG9BzR21KLUicy8J+H0A=
=Z0G7
-----END PGP SIGNATURE-----
--- End Message ---
