Your message dated Sat, 21 Mar 2020 17:05:10 +0100
with message-id <[email protected]>
and subject line Re: Bug#953608: nm.debian.org: Some data belonging to legacy 
processes is no longer shown on the site
has caused the Debian Bug report #953608,
regarding nm.debian.org: Some data belonging to legacy processes is no longer 
shown on the site
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
953608: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=953608
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: nm.debian.org
Severity: minor

Some data belonging to legacy processes is no longer shown on the site

- Mailbox view (https://nm.debian.org/legacy/display-mail-archive/$PNR) 
doesn't show any mails

- On the process page (https://nm.debian.org/legacy/process/$PNR)
-- "Personal information"
advocates are not shown and neither the former graphic for Mailbox stats.
-- "Process log"
"Changed by" does not show uids

- On pages of Persons and AMs (https://nm.debian.org/person/$uid)
Old style process tables are also missing advocates

added a patch for the advocates and "Changed by" parts.
>From 9bfbcd607d8e233302d9f0fe20c468117a825afd Mon Sep 17 00:00:00 2001
From: Judit Foglszinger <[email protected]>
Date: Wed, 11 Mar 2020 05:39:13 +0600
Subject: [PATCH] fix some references to uid (now person.ldap_fields.uid)

---
 legacy/templates/legacy/process.html              | 4 ++--
 public/templates/public/person_process_table.html | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/legacy/templates/legacy/process.html b/legacy/templates/legacy/process.html
index 61c63f9..63c171f 100644
--- a/legacy/templates/legacy/process.html
+++ b/legacy/templates/legacy/process.html
@@ -17,7 +17,7 @@
     <th>{% trans "Advocate" %}{{process.advocates.count|pluralize}}</th>
         <td>
             {% for a in process.advocates.all %}
-            <a href="{{ a.get_absolute_url }}">{{a.uid}}</a>{% if not forloop.last %},{% endif %}
+            <a href="{{ a.get_absolute_url }}">{{a.person.ldap_fields.uid}}</a>{% if not forloop.last %},{% endif %}
             {% endfor %}
         </td>
     </tr>
@@ -103,7 +103,7 @@
         {% endif %}
         <td>{{l.logdate|date:"Y-m-d"}}</td>
         <td>
-            <a href="{{l.changed_by.get_absolute_url}}">{{l.changed_by.uid}}</a>
+            <a href="{{l.changed_by.get_absolute_url}}">{{l.changed_by.person.ldap_fields.uid}}</a>
         </td>
         <td>{{l.progress|desc_progress}}</td>
         {% if visitor.am %}
diff --git a/public/templates/public/person_process_table.html b/public/templates/public/person_process_table.html
index 91a965c..9aa9f30 100644
--- a/public/templates/public/person_process_table.html
+++ b/public/templates/public/person_process_table.html
@@ -30,7 +30,7 @@
             </td>
             <td>
                 {% for a in p.advocates.all %}
-                <a href="{{ a.get_absolute_url }}" title="{{a.fullname}}">{{a.uid}}</a>{% if not forloop.last %},{% endif %}
+                <a href="{{ a.get_absolute_url }}" title="{{a.person.fullname}}">{{a.person.ldap_fields.uid}}</a>{% if not forloop.last %},{% endif %}
                 {% endfor %}
             </td>
         </tr>
-- 
2.25.1

Attachment: signature.asc
Description: This is a digitally signed message part.


--- End Message ---
--- Begin Message ---
On Sat, Mar 21, 2020 at 09:39:06PM +0600, Judit Foglszinger wrote:

> > Could you give me an example of a legacy process which doesn't show
> > mails for you?
> One of your recent mailbox fixes also fixed that issue, so no longer :)

Ok, cool, thanks! I'll close this then.


Enrico

-- 
GPG key: 4096R/634F4BD1E7AD5568 2009-05-08 Enrico Zini <[email protected]>

Attachment: signature.asc
Description: PGP signature


--- End Message ---

Reply via email to