Your message dated Sat, 28 Mar 2020 18:49:03 +0000
with message-id <[email protected]>
and subject line Bug#954127: fixed in fermi-lite 0.1-11
has caused the Debian Bug report #954127,
regarding fermi-lite broken on armhf
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
954127: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=954127
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: fermi-lite
Version: 0.1-9
Severity: grave
Tags: patch
User: [email protected]
Usertags: origin-ubuntu focal ubuntu-patch
Dear maintainers,
In Ubuntu, the fermi-lite autopkgtest has started failing on armhf with
version 0.1-9; where it previously succeeded, it now produces a segfault.
Investigation shows a problem with an assumption about the behavior when
implicitly casting from an unsigned integer type to a signed integer type:
when v->n is 0 in this function, because v->n is of type size_t, v->n - 1
yields UINT32_MAX, not -1.
The attached patch fixes the segfault.
Since the code here doesn't seem to have changed since the previous version
of the package whose autopkgtests succeeded, I assume this is due to a
behavior change in the compiler. However, as far as I can see the new and
old behavior are valid under the C standard, so this is a fermi-lite bug,
not a compiler bug.
Cheers,
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer https://www.debian.org/
[email protected] [email protected]
diff -Nru fermi-lite-0.1/debian/patches/ensure-signed-comparison
fermi-lite-0.1/debian/patches/ensure-signed-comparison
--- fermi-lite-0.1/debian/patches/ensure-signed-comparison 1969-12-31
16:00:00.000000000 -0800
+++ fermi-lite-0.1/debian/patches/ensure-signed-comparison 2020-03-17
01:09:35.000000000 -0700
@@ -0,0 +1,21 @@
+Description: Ensure that our variable checking for >= 0 is signed
+ The type of v->n is size_t, which is an unsigned type, and we are assigning
+ v->n - 1 to i and looping while this is >= 0. If v->n == 0, on some
+ architectures (armhf) this results in i being set to a positive value
+ (specifically, UINT32_MAX).
+Author: Steve Langasek <[email protected]>
+Last-Update: 2020-03-17
+
+Index: fermi-lite-0.1/mag.c
+===================================================================
+--- fermi-lite-0.1.orig/mag.c
++++ fermi-lite-0.1/mag.c
+@@ -506,7 +506,7 @@
+
+ for (j = 0; j < 2; ++j) {
+ sum_n = sum_l = 0;
+- for (i = v->n - 1; i >= 0; --i) {
++ for (i = (int64_t)v->n - 1; i >= 0; --i) {
+ const magv_t *p = &v->a[srt[i]<<32>>32];
+ int tmp1, tmp2;
+ tmp1 = tmp2 = 0;
diff -Nru fermi-lite-0.1/debian/patches/series
fermi-lite-0.1/debian/patches/series
--- fermi-lite-0.1/debian/patches/series 2020-02-15 04:17:54.000000000
-0800
+++ fermi-lite-0.1/debian/patches/series 2020-03-17 01:04:57.000000000
-0700
@@ -3,4 +3,5 @@
rename_bseq1_t.patch
bcf_seqlib.patch
simde
+ensure-signed-comparison
sync_instead_of_atomic
--- End Message ---
--- Begin Message ---
Source: fermi-lite
Source-Version: 0.1-11
Done: Andreas Tille <[email protected]>
We believe that the bug you reported is fixed in the latest version of
fermi-lite, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Andreas Tille <[email protected]> (supplier of updated fermi-lite package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sat, 28 Mar 2020 19:33:46 +0100
Source: fermi-lite
Architecture: source
Version: 0.1-11
Distribution: unstable
Urgency: medium
Maintainer: Debian Med Packaging Team
<[email protected]>
Changed-By: Andreas Tille <[email protected]>
Closes: 954127
Changes:
fermi-lite (0.1-11) unstable; urgency=medium
.
[ Steve Langasek ]
* Ensure that our variable checking for >= 0 is signed
Closes: #954127
Checksums-Sha1:
69ec56909e8712b2c3b3457909aa8c480eda119c 2138 fermi-lite_0.1-11.dsc
2ff2f990c46a8c24757e532cc4bbff88bff82ec9 45172 fermi-lite_0.1-11.debian.tar.xz
464546ce30476c77c81e96c2d791f3daeb20db80 7011 fermi-lite_0.1-11_amd64.buildinfo
Checksums-Sha256:
84d7a9b418dc60bac4de9feefebf5926037781cb9107a3182289aa67d650298c 2138
fermi-lite_0.1-11.dsc
2239bb78f74ed0f5a3e660d5b3b6489ddb95a4e8abf02d347eb1573e6972a2b1 45172
fermi-lite_0.1-11.debian.tar.xz
888a2852c2a79b36c1d87d50a431f947a47e629b01d742d205ecba60df46d0cb 7011
fermi-lite_0.1-11_amd64.buildinfo
Files:
69dad43671ab518d6b9b12b976b86614 2138 science optional fermi-lite_0.1-11.dsc
6b073bb04244e03a3c301da59addb25a 45172 science optional
fermi-lite_0.1-11.debian.tar.xz
a5f6c29cadf242be9e2da458b2e5334c 7011 science optional
fermi-lite_0.1-11_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJFBAEBCgAvFiEE8fAHMgoDVUHwpmPKV4oElNHGRtEFAl5/mVcRHHRpbGxlQGRl
Ymlhbi5vcmcACgkQV4oElNHGRtG11w/+Nzz1NBwjTszouU4v1Po+y6mZcGWj3Om8
LpxbLP8yqe3skmfdhYbtC3mWzQXQECGR/LlLlj0DZO2eXp44s0ObgIO+HmAgc6tl
nDiMJ8VCzfOP+JK21uGywGvcVRjht5XvxWBo0VwgciFFPqdjGXmdSs54MRUN64LO
N+hXpEW1NqUvzfcfx7VZWPiEK8wPiXLxK3o2/U7wcp4WE8BMQb2Q5RxwOWSGuW9T
yUEQouv9uTLW7LwsGB15IK2Rm4FUgea/pZUPyB5EZ6PNw047HbN5WOqtjwSk6d0i
u1Bca5pdj1dTuQjWVs8L0rYSDbL0JWq2x0GFB8aRTF9Ehygg8Y+Rv2rU+ABpxIuu
W5o8h3VxNu/bC/wYy/IWWLm+u/SpEuTTWVOQDokfVW5KHd7m0kxBQbtGoJqSOZMo
JDjydnB2/EBwGrwriDRctgIwnVQ2cLEeZFd2aaJpDiSqREMOGwlYdsNfAJq+DsUO
7bupH8VwCea2xacLzOx+uyDbhy64FSsCfSYtg7w1VWh1jWin6dADICS02xpS8JiK
Yl0/o4ZGQHY1AcZYzJWzxrtjvu46QGW/0Dlr1RJ+FS7FdvND6qbCKHH41MFFmcCp
n/8thdqJC6uaN0b7huTXf3wjp1SUQ27pC+ABNe5r/NQr6ve0+j1TgnDnDWPhn5dg
GuM/Vrzq5fU=
=dsfG
-----END PGP SIGNATURE-----
--- End Message ---
