Your message dated Sat, 28 Mar 2020 19:33:45 +0000 with message-id <[email protected]> and subject line Bug#933729: fixed in gobject-introspection 1.64.0-2 has caused the Debian Bug report #933729, regarding dh_girepository: Parsing of the build-dependencies is really fragile to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 933729: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=933729 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: gobject-introspection Version: 1.58.3-2 Severity: important File: /usr/bin/dh_girepository Hello, It seems that the parsing of the build-dependencies in dh_girepository is really fragile. # Get Build-Depends in an array my @bdeps; my $cur = 0; open (my $control, "<", "debian/control") or error ("Cannot open debian/control"); while (<$control>) { chomp; s/\s+$//; if ($cur) { if (/^\s+(.*)$/) { push @bdeps, split ",",$1; if ($1 !~ /,$/) { $cur = 0; } } else { $cur = 0; } } if (/^Build-Depends:\s*(.*)$/) { push @bdeps, split ",",$1; if ($1 =~ /,$/) { $cur = 1; } else { $cur = 0; } } } close $control; It's not escaping lines with comments and and stops the processing. It also fails if the 1st build-dependency is not on the same line as the Build-Depends field like: Build-Depends: build-dep1, build-dep2 This is quite annoying as it can generate dependencies with incorrect minimal version. Kind regards, Laurent Bigonville -- System Information: Debian Release: bullseye/sid APT prefers unstable-debug APT policy: (500, 'unstable-debug'), (500, 'unstable'), (1, 'experimental-debug'), (1, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 4.19.0-5-amd64 (SMP w/8 CPU cores) Locale: LANG=fr_BE.UTF-8, LC_CTYPE=fr_BE.UTF-8 (charmap=UTF-8), LANGUAGE=fr_BE:fr (charmap=UTF-8) Shell: /bin/sh linked to /usr/bin/dash Init: systemd (via /run/systemd/system) LSM: AppArmor: enabled Versions of packages gobject-introspection depends on: ii build-essential 12.6 ii libc6 2.28-10 ii libffi6 3.2.1-9 ii libgirepository-1.0-1 1.58.3-2 ii libglib2.0-0 2.60.6-1 ii python3 3.7.3-1 ii python3-distutils 3.7.4-3 ii python3-mako 1.0.7+ds1-1 ii python3-markdown 3.0.1-3 gobject-introspection recommends no packages. gobject-introspection suggests no packages. -- no debconf information
--- End Message ---
--- Begin Message ---Source: gobject-introspection Source-Version: 1.64.0-2 Done: Laurent Bigonville <[email protected]> We believe that the bug you reported is fixed in the latest version of gobject-introspection, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Laurent Bigonville <[email protected]> (supplier of updated gobject-introspection package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Sat, 28 Mar 2020 20:17:49 +0100 Source: gobject-introspection Architecture: source Version: 1.64.0-2 Distribution: unstable Urgency: medium Maintainer: Debian GNOME Maintainers <[email protected]> Changed-By: Laurent Bigonville <[email protected]> Closes: 933729 Changes: gobject-introspection (1.64.0-2) unstable; urgency=medium . * debian/dh_girepository: Make the parsing of BD more robust. Thanks to Simon McVittie (Closes: #933729) Checksums-Sha1: 5ca7248c4b06c0debe66909f8f14710e8c5200b8 2614 gobject-introspection_1.64.0-2.dsc 94128ededca020e4f00d476bca869b782b020c6d 23672 gobject-introspection_1.64.0-2.debian.tar.xz afd0477b84a4eb8736e1899138fb400f9a5a9ce4 8418 gobject-introspection_1.64.0-2_source.buildinfo Checksums-Sha256: 05bff32a5dba30cd6a738cf2657f2863a58f2ae92673f6bf824386ff98eb83ab 2614 gobject-introspection_1.64.0-2.dsc 10260a7759cf9244327d4c3dff1e2a241e71a58f9dd8d042eb23ef0ddcc84b7b 23672 gobject-introspection_1.64.0-2.debian.tar.xz 34ffc9bc4527775d060467e7632fac47ed8de47b04f1c980428b7cbbbf6c479e 8418 gobject-introspection_1.64.0-2_source.buildinfo Files: e6a439f4394c233cc6b272263475d714 2614 devel optional gobject-introspection_1.64.0-2.dsc b233546c4045e377c3cec3b9049e4930 23672 devel optional gobject-introspection_1.64.0-2.debian.tar.xz d207d40d98f59428275ecdf1256f4c0c 8418 devel optional gobject-introspection_1.64.0-2_source.buildinfo -----BEGIN PGP SIGNATURE----- iQFFBAEBCAAvFiEEmRrdqQAhuF2x31DwH8WJHrqwQ9UFAl5/owIRHGJpZ29uQGRl Ymlhbi5vcmcACgkQH8WJHrqwQ9V0wgf/R6D4nb5wbvhzpvX7wddup66aBoV7HaHo Tl7bACrZS9V2RDdU76uLL2CRWtyvPsYGrEUL5zFfbj4bhZJPUsC8MH4R89GK2iP2 Kst39xP6s5hBTN4FsIfxXRENMKSBX7TmG48jLKjwZzw239U1MtvIhy/aYWurCjVc rMc6Fz0UqKizSqk3Mgm6ANNPNKHX0/UqUvUb5n5zT5uU9yN+pBjTUxElB8TI3JnO 32TqvMnYGbgOaZxsDVIgYjBFCmY/mTitbgLtjFNYt32DBowg6ctG1y7q2qxCeloD +V4ZvGMC6470MKaFsj/UjIFGXo2oukAvnyzjxHJqexgdEM5Enf5zNQ== =crAc -----END PGP SIGNATURE-----
--- End Message ---
