Your message dated Tue, 14 Apr 2020 16:38:41 +0000
with message-id <e1jooa9-000fne...@fasolo.debian.org>
and subject line Bug#930674: fixed in wmaker 0.95.9-1
has caused the Debian Bug report #930674,
regarding automatically generated menus prevent some applications from running
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
930674: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=930674
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: wmaker
Version: 0.95.8-3

automatically generated menus prevent some applications from running,
e.g. libreoffice will not run complaining that file "%U does not exist"
and others will open an empty file, e.g. %F.

Looking at the code the XDG menu parser does not strip "%X" arguments
from Exec entries, I attached a sample patch as a workaround to this
problem.
Index: wmaker-0.95.8/util/wmmenugen_parse_xdg.c
===================================================================
--- wmaker-0.95.8.orig/util/wmmenugen_parse_xdg.c
+++ wmaker-0.95.8/util/wmmenugen_parse_xdg.c
@@ -297,7 +297,7 @@ static void getKey(char **target, const
 static void getStringValue(char **target, const char *line)
 {
 	const char *p;
-	int kstart;
+	int kstart, kend;

 	p = line;
 	kstart = 0;
@@ -311,7 +311,15 @@ static void getStringValue(char **target
 	while (*(p + kstart) && isspace(*(p + kstart)))
 		kstart++;

-	*target = wstrdup(p + kstart);
+	/* skip until first % */
+	kend = kstart + 1;
+	while (*(p + kend) && *(p + kend) != '%')
+		kend++;
+
+	/* strip heading white space if any */
+	if(isspace(*(p + kend -1))) kend--;
+
+	*target = wstrndup(p + kstart, kend - kstart);
 }

 /* get a localized string value from line. allocates target, which must be wfreed later.

--- End Message ---
--- Begin Message ---
Source: wmaker
Source-Version: 0.95.9-1
Done: Andreas Metzler <ametz...@debian.org>

We believe that the bug you reported is fixed in the latest version of
wmaker, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 930...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Andreas Metzler <ametz...@debian.org> (supplier of updated wmaker package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 14 Apr 2020 18:06:26 +0200
Source: wmaker
Architecture: source
Version: 0.95.9-1
Distribution: experimental
Urgency: low
Maintainer: Debian Window Maker Team <pkg-wmaker-de...@lists.alioth.debian.org>
Changed-By: Andreas Metzler <ametz...@debian.org>
Closes: 922284 930674
Changes:
 wmaker (0.95.9-1) experimental; urgency=low
 .
   [ Doug Torrance ]
   * New upstream release.
     - No longer sets GNUSTEP_USER_ROOT environment variable
       (Closes: #922284).
     - Prefers TryExec to Exec when generating menu entries from XDG desktop
       files (closes: #930674).
     - Drop patches previously pulled from upstream GIT:
       10_util-fix-parsing-of-XDG-menus-with-multiple-groups.patch
       11_XDG-menu-categories.patch 12_reference-proplist-menus.patch
       60_fix_pkg-config_variable_typo.patch
     - Unfuzz 75_WPrefs_to_bindir_when_gnustedir_is_set.diff
     - 54_Debian_wmmacros.diff dropped, main functionality included upstream.
   * debian/compat
     - Remove file; compatibility level now handled by debhelper-compat
       package.
   * debian/control
     - Bump Standards-Version to 4.5.0.
     - Switch Build-Depends on debhelper to debhelper-compat for
       compatibility level 12.
   * debian/lib*.symbols
     - Add Build-Depends-Package fields.
   * debian/libwings3.symbols
     - Add new WINGs symbols.
   * debian/patches/10_support_imagemagick6.diff
     - New patch; restore support for ImageMagick v6, as v7 is not in
       Debian yet.
   * debian/patches/.keepme
     - Remove unnecessary file; was causing
       patch-file-present-but-not-mentioned-in-series Lintian warning.
   * debian/README.Debian
     - Fix typo.
   * debian/rules
     - Remove replacement of #wmdatadir# to $(WMSHAREDIR) in some menu
       files; this is now done by upstream during build.
     - Install README's from WindowMaker directory correctly. Avoids
       package-contains-documentation-outside-usr-share-doc Lintian
       warning.
   * debian/wmaker-common.docs
     - Use wildcard to catch all the README's that have been renamed
       in d/rules.
Checksums-Sha1: 
 4dbddc3445ab055cd7f28daaa88a7ba36a169e48 2728 wmaker_0.95.9-1.dsc
 4c19bb85bf2d1a3412ec42b3810d1aebc0a8f76f 3397167 wmaker_0.95.9.orig.tar.gz
 71d1b462f382ae440c0f27ca42dd6c10cc2ebb5c 482028 wmaker_0.95.9-1.debian.tar.xz
Checksums-Sha256: 
 612ce5d46ca9aed4f9b60f8ebbda96fbbd74c17db2283f3b983fc8bf0c1a7990 2728 
wmaker_0.95.9-1.dsc
 f22358ff60301670e1e2b502faad0f2da7ff8976632d538f95fe4638e9c6b714 3397167 
wmaker_0.95.9.orig.tar.gz
 0b5a7cc74d73d815c48e5d94c21503255c6e88a12fba737adb84600625cf37ec 482028 
wmaker_0.95.9-1.debian.tar.xz
Files: 
 047068bc083679cc93f87927514c4bb6 2728 x11 optional wmaker_0.95.9-1.dsc
 ae34634643699de996695f26624631f6 3397167 x11 optional wmaker_0.95.9.orig.tar.gz
 70d1249aaef6de0d779091eda8591f5c 482028 x11 optional 
wmaker_0.95.9-1.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE0uCSA5741Jbt9PpepU8BhUOCFIQFAl6V4SYACgkQpU8BhUOC
FIS/Tw/9FAAnVBnMU0ZafdRvkR1ZVbAdat4mVH7ZW8OidJyE5FN5fPJn7rZnB7w8
/+6H2h5Xi5ogU7rl0Ms6fzh+pVjKPMkWWNmpBe6sqq27mfjB/x/N3Lf4XQ7+jKUY
+dRE4LsQ/9mIBtfDMrv/F7b75pmhDy1Nae8xnW6BZ+1mzwNb6Qw9uUPPn5/CWPMT
51hq6yJlfVPHpPOyUEJr/Io5r/e9modTqoxma/Z0+wkHIDKCr3tsDK3zjsr2+S9Q
e1eKRz9oziPkvl5xhldAVbp6LRLiKsMotqLslJr6yWS/rMbn6SfNg26Z72Ahuq43
LgptJPNWe/lyrjK3Yf9v+CcX9JTqa42CFGt/APUb+u5YihXYcERGawMFlIp7PSVv
Vmj1vK4+gDtkYwH1sjZ5oGACXcG8c8Kwtm49jAXyXokJ0wvjqjjP+Squw2Xza9oh
v2iw/NUvpI5lqE+TL9lfgpO+bL+AuXdHR+C1KI9yrxo9AAOYzHapRBxnHoFpMu9s
dQqtb8EWTBwM+1UBPvuBmBMnfmR3dPJMVQlBWyToBir277yLO3Z+mWYYuvQr34Hk
ymRHIZODVJXNBkY5MBQz2IsYP6NRLjY08wwd80WPJDA6paz0Tc2ixe9ihbNqAyTw
5f/T9URprUAFaAsh3sKhn+xc2Gdtrz8t4ESldmfAe1YLrXNBMOU=
=rBIs
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to