Your message dated Tue, 21 Apr 2020 19:18:59 +0000
with message-id <[email protected]>
and subject line Bug#922691: fixed in influxdb 1.6.4-2
has caused the Debian Bug report #922691,
regarding influxdb: init script restart action always returns an error code
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
922691: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=922691
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: influxdb
Version: 1.6.4-1
Severity: normal
Tags: patch
Hi!
The init script's restart action always returns an error code, because
the errcode variable is only assigned on errors from the status
action, and the log_end_msg function will default to an error value if
non is passed to it.
Attached patch should fix this.
Thanks,
Guillem
From 5aa9e83baf01384ddd5a5d10ef3ab29d67360dc9 Mon Sep 17 00:00:00 2001
From: Guillem Jover <[email protected]>
Date: Tue, 19 Feb 2019 15:17:52 +0100
Subject: [PATCH] debian: Fix init script return code on restart action
The errcode is only assigned conditionally when there's an error return
code from the status action. But log_end_msg will default to an error
code of 1 if it gets no argument passed. So in this case the restart
will always return an error code.
---
debian/influxdb.init | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/debian/influxdb.init b/debian/influxdb.init
index 7e1600d..322dca8 100644
--- a/debian/influxdb.init
+++ b/debian/influxdb.init
@@ -115,8 +115,8 @@ case $1 in
log_daemon_msg "Restarting $desc" "$name"
# Restart the daemon.
$0 stop && sleep 2 && $0 start
- $0 status || errcode=$?
- log_end_msg $errcode
+ $0 status
+ log_end_msg $?
;;
status)
--
2.21.0.rc0.258.g878e2cd30e
--- End Message ---
--- Begin Message ---
Source: influxdb
Source-Version: 1.6.4-2
Done: Shengjing Zhu <[email protected]>
We believe that the bug you reported is fixed in the latest version of
influxdb, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Shengjing Zhu <[email protected]> (supplier of updated influxdb package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Wed, 22 Apr 2020 02:59:01 +0800
Source: influxdb
Architecture: source
Version: 1.6.4-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Go Packaging Team <[email protected]>
Changed-By: Shengjing Zhu <[email protected]>
Closes: 922691 954240
Changes:
influxdb (1.6.4-2) unstable; urgency=medium
.
* Team upload.
.
[ Shengjing Zhu ]
* Remove dgrijalva/jwt-go v3 patch.
Replace golang-github-dgrijalva-jwt-go-v3-dev with
golang-github-dgrijalva-jwt-go-dev
* Update maintainer address to [email protected]
* Use getent to parse entries (Closes: #954240)
Thanks Andreas Maus
.
[ Guillem Jover ]
* debian: Fix init script return code on restart action. (Closes: #922691)
The errcode is only assigned conditionally when there's an error return
code from the status action. But log_end_msg will default to an error
code of 1 if it gets no argument passed. So in this case the restart
will always return an error code.
Checksums-Sha1:
395b37943f9b4e56c93f09552852e82017b1413c 2986 influxdb_1.6.4-2.dsc
8d998e71dc3f0084fa357a26fb51077e39b97bf4 16700 influxdb_1.6.4-2.debian.tar.xz
697ab92fea75212e4ff9b5c3f096bf6273eb6624 11398 influxdb_1.6.4-2_amd64.buildinfo
Checksums-Sha256:
660cb988f856c29a5a58ffbb1a82ea3668827b26cc88c5ce471399d2f07e736a 2986
influxdb_1.6.4-2.dsc
6df79ca0eec7baa86b41408757ab0428ff228f210bcf4cd9697a56cff14e8c7b 16700
influxdb_1.6.4-2.debian.tar.xz
32bf5c5940202a9126f299e488baa8ab1d196b677a35dee82b7572dc30fb2c66 11398
influxdb_1.6.4-2_amd64.buildinfo
Files:
9be43169c48fc1e78d8de4774688d050 2986 database optional influxdb_1.6.4-2.dsc
c6804884daf4a431331d445634b526e3 16700 database optional
influxdb_1.6.4-2.debian.tar.xz
4c61e66e3cc5e398924f231eacb8118f 11398 database optional
influxdb_1.6.4-2_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iIYEARYIAC4WIQTiXc95jUQrjt9HgU3EhUo4GOCwFgUCXp9DARAcemhzakBkZWJp
YW4ub3JnAAoJEMSFSjgY4LAWRm0A/Rd3fV0uJcp9NPGRQkbqi0sKymbENSu38eJB
A5iWlCMfAQDgPCz/kvq7WFxKShIwCiq5HM5IVqy7BEe36GuNDXk4Cg==
=dRjq
-----END PGP SIGNATURE-----
--- End Message ---
