Your message dated Fri, 05 May 2006 07:18:23 -0700
with message-id <[EMAIL PROTECTED]>
and subject line Bug#336202: fixed in xcdroast 0.98+0alpha15-5
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--- Begin Message ---
Package: xcdroast
Version: 0.98+0alpha15-3
Severity: minor

If I try to do a cddbquery for a CD from, for example, Hüsker Dü or
Motörhead or generally for CDs whith non-ascii signs cddbtool fails
because the cddbserver does not return a valid UTF-8 string.

One solution is to build xcdroast without gtk2.

Another solution is the attached patch. It works for me but non-ascii
signs will be shown as '?' in xcdroast.

-- System Information:
Debian Release: 3.1
  APT prefers unstable
  APT policy: (100, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.6.13.4
Locale: [EMAIL PROTECTED], [EMAIL PROTECTED] (charmap=ISO-8859-15)

Versions of packages xcdroast depends on:
ii  cdda2wav                  4:2.01+01a01-2 Creates WAV files from audio CDs
ii  cdrecord                  4:2.01+01a03-3 command line CD writing tool
ii  debconf [debconf-2.0]     1.4.30.13      Debian configuration management sy
ii  libatk1.0-0               1.8.0-4        The ATK accessibility toolkit
ii  libc6                     2.3.2.ds1-22   GNU C Library: Shared libraries an
ii  libglib2.0-0              2.6.4-1        The GLib library of C routines
ii  libgtk2.0-0               2.6.4-3        The GTK+ graphical user interface 
ii  libpango1.0-0             1.8.1-1        Layout and rendering of internatio
ii  libpcre3                  4.5-1.2sarge1  Perl 5 Compatible Regular Expressi
ii  makedev                   2.3.1-77       creates device files in /dev
ii  mkisofs                   4:2.01+01a03-3 Creates ISO-9660 CD-ROM filesystem

-- debconf information excluded
--- src/cddbtool.c.orig 2002-12-14 17:08:01.000000000 +0100
+++ src/cddbtool.c      2005-10-28 16:25:00.000000000 +0200
@@ -46,7 +46,11 @@
 
 #define CDDB_HTTP_CMD  "GET http://%s/~cddb/cddb.cgi?cmd=";
 #define CDDB_HTTP_KEEP " HTTP/1.0\r\nHost: %s\r\nConnection: 
Keep-Alive\r\nProxy-Connection: Keep-Alive\r\n%s\r\n"
+#if GTK_MAJOR_VERSION < 2
 #define CDDB_HTTP_HELLO        "hello=%s+%s+xcdroast+%s&proto=1"CDDB_HTTP_KEEP
+#else
+#define CDDB_HTTP_HELLO "hello=%s+%s+xcdroast+%s&proto=6"CDDB_HTTP_KEEP
+#endif
 #define CDDB_HTTP_STAT CDDB_HTTP_CMD"stat&"CDDB_HTTP_HELLO
 #define CDDB_HTTP_MOTD CDDB_HTTP_CMD"motd&"CDDB_HTTP_HELLO
 #define CDDB_HTTP_QUERY        CDDB_HTTP_CMD"cddb+query+%s&"CDDB_HTTP_HELLO
@@ -240,11 +244,30 @@
                fflush(stdout);
                return 1;
        }
-
+       
+#if GTK_MAJOR_VERSION > 1
+       
+       g_snprintf(tmp,MAXLINE,"%s %d\r\n", "proto", 6);
+       if (writen(sockfd,tmp,strlen(tmp), 1) != strlen(tmp)) {
+                g_print("Error: write error on socket when setting 
protocol\n");
+                fflush(stdout);
+                return 1;
+        }
+        n = read_line2(sockfd, tmp, MAXLINE, 1);
+        if (n < 0) {
+                g_print("Error: read error on socket when setting protocol\n");
+                fflush(stdout);
+                return 1;
+        }
+#endif 
        code = get_cddb_code(tmp);
        switch(code) {
-               /* all ok */
+               /* all ok  */
+#if GTK_MAJOR_VERSION < 2
                case 200:
+#else
+               case 201:
+#endif
                        return 0;
 
                /* handshake failed */

--- End Message ---
--- Begin Message ---
Source: xcdroast
Source-Version: 0.98+0alpha15-5

We believe that the bug you reported is fixed in the latest version of
xcdroast, which is due to be installed in the Debian FTP archive:

xcdroast_0.98+0alpha15-5.diff.gz
  to pool/main/x/xcdroast/xcdroast_0.98+0alpha15-5.diff.gz
xcdroast_0.98+0alpha15-5.dsc
  to pool/main/x/xcdroast/xcdroast_0.98+0alpha15-5.dsc
xcdroast_0.98+0alpha15-5_i386.deb
  to pool/main/x/xcdroast/xcdroast_0.98+0alpha15-5_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Hector Garcia <[EMAIL PROTECTED]> (supplier of updated xcdroast package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Fri,  5 May 2006 15:49:52 +0200
Source: xcdroast
Binary: xcdroast
Architecture: source i386
Version: 0.98+0alpha15-5
Distribution: unstable
Urgency: low
Maintainer: Hector Garcia <[EMAIL PROTECTED]>
Changed-By: Hector Garcia <[EMAIL PROTECTED]>
Description: 
 xcdroast   - X based CD-writer software
Closes: 336202
Changes: 
 xcdroast (0.98+0alpha15-5) unstable; urgency=low
 .
   * Included 09_share_dir which provides the configure flag to tell the system
     where is the share dir and changes to the code to place icons on the share
     dir.
   * Updated standards version to 3.7.2. Didn't need any change on package.
   * Added patch 10_cddbtool to support non-ascii querys to cddb.
     Author: Robert Grimm. (Closes: #336202)
Files: 
 01ae87eae5c1d4e9e5b227e820e847c1 649 otherosfs extra 
xcdroast_0.98+0alpha15-5.dsc
 3a4017da8d3efab73447377b63304db6 89063 otherosfs extra 
xcdroast_0.98+0alpha15-5.diff.gz
 9167380be1082ebdbcd57f67fbec9e1f 1877678 otherosfs extra 
xcdroast_0.98+0alpha15-5_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)

iD8DBQFEW1mXMwsDi2xjdG0RAnGEAKCRHoC9QeealhkbzJWwIuygZ+2fIACg7mC6
lDgUugLypdhJ5d6aCwupbG8=
=UDSE
-----END PGP SIGNATURE-----


--- End Message ---

Reply via email to