Your message dated Tue, 5 May 2020 12:13:48 +0200
with message-id <[email protected]>
and subject line CLOSE openstack-pkg-tools: Ensure AFTER and WANTS are
initialized when either Should-Start or Required-Start are specified
has caused the Debian Bug report #952691,
regarding openstack-pkg-tools: Ensure AFTER and WANTS are initialized when
either Should-Start or Required-Start are specified
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
952691: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=952691
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: openstack-pkg-tools
Version: 109
Severity: normal
Tags: patch
User: [email protected]
Usertags: origin-ubuntu focal ubuntu-patch
Dear Maintainer,
In Ubuntu, the attached patch was applied to achieve the following:
* pkgos-gen-systemd-unit: Ensure AFTER and WANTS are initialized when
one of Should-Start or Required-Start are specified.
Thanks for considering the patch.
-- System Information:
Debian Release: bullseye/sid
APT prefers focal
APT policy: (500, 'focal')
Architecture: amd64 (x86_64)
Kernel: Linux 5.4.0-14-generic (SMP w/4 CPU cores)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8),
LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
diff -Nru openstack-pkg-tools-108/init-template/pkgos-gen-systemd-unit
openstack-pkg-tools-109/init-template/pkgos-gen-systemd-unit
--- openstack-pkg-tools-108/init-template/pkgos-gen-systemd-unit
2020-02-14 08:54:31.000000000 -0500
+++ openstack-pkg-tools-109/init-template/pkgos-gen-systemd-unit
2020-02-27 10:37:44.000000000 -0500
@@ -42,12 +42,15 @@
X_START_BEFORE=$(cat ${INIT_TEMPLATE} | grep "# X-Start-Before:" | sed 's/#
X-Start-Before://')
REQUIRED_START=$(cat ${INIT_TEMPLATE} | grep "# Required-Start:" | sed 's/#
Required-Start://')
-if [ -n "${SHOULD_START}" ] ; then
+if [ -n "${SHOULD_START}" ] || [ -n "${REQUIRED_START}" ] ; then
AFTER="After="
+ WANTS="Wants="
+fi
+
+if [ -n "${SHOULD_START}" ] ; then
for i in ${SHOULD_START} ; do
AFTER="${AFTER}${i}.service "
done
- WANTS="Wants="
fi
for i in $(cat ${INIT_TEMPLATE} | grep "# Required-Start:" | sed 's/#
Required-Start://' ) ; do
--- End Message ---
--- Begin Message ---
Package: openstack-pkg-tools
Version: 109
Hi Corey,
Very thanks for attached patch, it was merged and currently available in
version 109 (sid).
I am closing this bugreport manually as I forgot to add Close flag to
changelog in 109 version.
openstack-pkg-tools (109) unstable; urgency=medium
* Added patches from Ubuntu:
[ Corey Bryant ]
* pkgos-gen-systemd-unit: Ensure AFTER and WANTS are initialized when
one of Should-Start or Required-Start are specified.
[ Thomas Goirand ]
* Fix uwsgi bind address so it doesn't require IPv6.
* Endpoint creation: fallsback to hostname -i when detecting IP. Do
not crash
if we can't find an IP address.
* Also support +ds1 as Debian version for packages.
[ Michal Arbet ]
* Fix etc/pkgos/pkgos.conf to use train instead of stein
Thank you,
Michal Arbet ( kevko )
signature.asc
Description: OpenPGP digital signature
--- End Message ---
