Your message dated Sun, 10 May 2020 03:01:07 +0000
with message-id <[email protected]>
and subject line Bug#959993: Removed package(s) from unstable
has caused the Debian Bug report #850752,
regarding syslog-summary: Ignore logic invalid when multiple lines should be 
ignored
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
850752: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=850752
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: syslog-summary
Version: 1.14-2.1
Severity: important
Tags: patch upstream

Dear Maintainer,

   * What led up to the situation?

        ** syslog file containing multiple INFO lines following each
        other
        ** ignore pattern to block INFO lines in
        /etc/syslog-summary/ignore.rules.

   * What exactly did you do (or not do) that was effective (or
     ineffective)?

        run syslog-summary on this file

   * What was the outcome of this action?

        about half of the INFO lines are not ignored and output in the
        summary

   * What outcome did you expect instead?

        no INFO lines in the summary output


   * Patch

        There are 2 PR against upstream to fix this (I was a bit eager
        to fix this...) [0,1], the oldest 5 years old.

        My proposed patch [1] is at the end of this report, but [0] is a
        one-line change.

        [0] https://github.com/dpaleino/syslog-summary/pull/1
        [1] https://github.com/dpaleino/syslog-summary/pull/3

-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'oldstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.8.0-2-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages syslog-summary depends on:
pn  python:any  <none>

Versions of packages syslog-summary recommends:
ii  python-magic  1:5.29-2

syslog-summary suggests no packages.

-- Configuration Files:
/etc/syslog-summary/ignore.rules changed [not included]

-- no debconf information

>From cb5748700d9f9d42b8680fa1ef3cc232df97823a Mon Sep 17 00:00:00 2001
From: Olivier Mehani <[email protected]>
Date: Mon, 9 Jan 2017 21:16:33 +1100
Subject: [PATCH] Fix ignore logic

The previous structure failed to ignore two lines in a row.

Signed-off-by: Olivier Mehani <[email protected]>
---
 syslog-summary | 47 +++++++++++++++++++++++------------------------
 1 file changed, 23 insertions(+), 24 deletions(-)

diff --git a/syslog-summary b/syslog-summary
index 17ad38b..8ffb27b 100755
--- a/syslog-summary
+++ b/syslog-summary
@@ -197,31 +197,30 @@ def summarize(filename, states):
                        ignored_count += 1
                        if DEBUG:
                                print "Ignoring: %s" % line
-                       line = file.readline()
-               
-               date, rest = split_date(line)
-               if date:
-                       found = pidpat.search(rest)
-                       if found:
-                               rest = found.group(1) + ": " + 
rest[found.end():]
-
-               count = 1
-               repeated = None
-               if REPEAT:
-                       repeated = repeatpat.search(rest)
-               if repeated and previous:
-                       count = int(repeated.group(1))
-                       rest = previous
-
-               if counts.has_key(rest):
-                       counts[rest] = counts[rest] + count
                else:
-                       assert count == 1
-                       counts[rest] = count
-                       order.append(rest)
-
-               if not repeated:
-                       previous = rest
+                       date, rest = split_date(line)
+                       if date:
+                               found = pidpat.search(rest)
+                               if found:
+                                       rest = found.group(1) + ": " + 
rest[found.end():]
+       
+                       count = 1
+                       repeated = None
+                       if REPEAT:
+                               repeated = repeatpat.search(rest)
+                       if repeated and previous:
+                               count = int(repeated.group(1))
+                               rest = previous
+       
+                       if counts.has_key(rest):
+                               counts[rest] = counts[rest] + count
+                       else:
+                               assert count == 1
+                               counts[rest] = count
+                               order.append(rest)
+       
+                       if not repeated:
+                               previous = rest
                line = file.readline()
        file.close()
 
-- 
2.11.0

--- End Message ---
--- Begin Message ---
Version: 1.14-2.1+rm

Dear submitter,

as the package syslog-summary has just been removed from the Debian archive
unstable we hereby close the associated bug reports.  We are sorry
that we couldn't deal with your issue properly.

For details on the removal, please see https://bugs.debian.org/959993

The version of this package that was in Debian prior to this removal
can still be found using http://snapshot.debian.org/.

Please note that the changes have been done on the master archive and
will not propagate to any mirrors until the next dinstall run at the
earliest.

This message was generated automatically; if you believe that there is
a problem with it please contact the archive administrators by mailing
[email protected].

Debian distribution maintenance software
pp.
Scott Kitterman (the ftpmaster behind the curtain)

--- End Message ---

Reply via email to