Your message dated Tue, 09 Jun 2020 00:18:45 +0000 with message-id <[email protected]> and subject line Bug#954234: fixed in munin 2.0.63-1 has caused the Debian Bug report #954234, regarding /etc/init.d/munin has two broken function definitions to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 954234: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=954234 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: munin Version: 2.0.57-1 At the bottom of the /etc/init.d/munin script are two lines: do_stop_cmd_override() true do_start_cmd_override() true This is **NOT** how you define a shell function. The function code needs to be inside curly braces, and (because they're defined with a one-liner) the functions need to end with a trailing semi-colon. Like so: do_stop_cmd_override() { true ; } do_start_cmd_override() { true ; } Without this patch (attached), upgrading munin to 2.0.57-1 leaves the package in a broken (installed/Failed-config, or "iF") state and results in the following: # systemctl status munin ● munin.service - LSB: Create munin master directories on boot Loaded: loaded (/etc/init.d/munin; generated) Active: failed (Result: exit-code) since Thu 2020-03-19 13:33:46 AEDT; 5min ago Docs: man:systemd-sysv-generator(8) Process: 3625739 ExecStart=/etc/init.d/munin start (code=exited, status=2) Mar 19 13:33:46 ganesh systemd[1]: Starting LSB: Create munin master directories on boot... Mar 19 13:33:46 ganesh munin[3625739]: /etc/init.d/munin: line 30: syntax error near unexpected token `true' Mar 19 13:33:46 ganesh munin[3625739]: /etc/init.d/munin: line 30: `do_stop_cmd_override() true' Mar 19 13:33:46 ganesh systemd[1]: munin.service: Control process exited, code=exited, status=2/INVALIDARGUMENT Mar 19 13:33:46 ganesh systemd[1]: munin.service: Failed with result 'exit-code'. Mar 19 13:33:46 ganesh systemd[1]: Failed to start LSB: Create munin master directories on boot. After patching and running 'dpkg --configure --pending': ● munin.service - LSB: Create munin master directories on boot Loaded: loaded (/etc/init.d/munin; generated) Active: active (exited) since Thu 2020-03-19 14:00:23 AEDT; 4min 45s ago Docs: man:systemd-sysv-generator(8) Process: 3699607 ExecStart=/etc/init.d/munin start (code=exited, status=0/SUCCESS) Mar 19 14:00:23 ganesh systemd[1]: Starting LSB: Create munin master directories on boot... Mar 19 14:00:23 ganesh munin[3699607]: Starting Preparing munin directories: munin. Mar 19 14:00:23 ganesh systemd[1]: Started LSB: Create munin master directories on boot. craig--- munin.dpkg-dist 2020-03-14 03:40:22.000000000 +1100 +++ munin 2020-03-19 14:00:07.916057288 +1100 @@ -27,5 +27,5 @@ # there is no process to be started or stopped ("munin-update" is executed via cron) -do_stop_cmd_override() true -do_start_cmd_override() true +do_stop_cmd_override() { true ; } +do_start_cmd_override() { true ; }
--- End Message ---
--- Begin Message ---Source: munin Source-Version: 2.0.63-1 Done: Holger Levsen <[email protected]> We believe that the bug you reported is fixed in the latest version of munin, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Holger Levsen <[email protected]> (supplier of updated munin package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Tue, 09 Jun 2020 01:55:12 +0200 Source: munin Architecture: source Version: 2.0.63-1 Distribution: unstable Urgency: medium Maintainer: Munin Debian Maintainers <[email protected]> Changed-By: Holger Levsen <[email protected]> Closes: 713891 761190 806173 863231 934334 954234 954930 Changes: munin (2.0.63-1) unstable; urgency=medium . [ Lars Kruse ] * New upstream release, 2.0.63. * New upstream release, 2.0.62. * New upstream release, 2.0.61. * New upstream release, 2.0.60, fixing the following issue: - asterisk_* plugins: removal due to being outdated. Use the plugins from "contrib" repository instead (e.g. via "munin-get"). (Closes: #713891, #806173, #934334) * New upstream release, 2.0.59. * New upstream release, 2.0.58, fixing the following issue: - apt_all plugin: override local apt settings that could interfere with the plugin operation (Closes: #761190) - apt_all plugin: rename state file in order to avoid confusion (Closes: #863231) * munin sysvinit: fix bash-incompatibility of init script (thanks, Craig Sanders, Closes: #954234) * munin-plugins-core: add missing "Suggests" for "nginx_status" (package "libwww-perl") (thanks, Olaf Zaplinski, Closes: #954930) * clean up maintainer scripts (quoting, whitespace, parameter handling) * munin-(node|common).postinst: remove redundant code * munin-node.postinst: remove unused conditional * munin-node.postinst: simplify log redirections * mask systemd service "munin" The init script only creates directories - these are handled via systemd-tmpfiles. (thanks, Andreas Henriksson) . [ Holger Levsen ] * Bump debhelper-compat to 13. Checksums-Sha1: 0e32487219136bf04979f2d27ab895a2e180a6e2 3138 munin_2.0.63-1.dsc 3d1fde3b877e78db1ad634006c9a4e3121a072cb 2247156 munin_2.0.63.orig.tar.gz b98c52fbe1561e7308ebb6e3e930db2821587019 833 munin_2.0.63.orig.tar.gz.asc 51392222d42689ef6e5551b597f7f27a44b4cb39 64316 munin_2.0.63-1.debian.tar.xz 390d8945985b7f2ccc1b1530bee2172048bf3eac 5251 munin_2.0.63-1_source.buildinfo Checksums-Sha256: 0fe449b9045008e87e92cb7447c6673eeb8d9e445772213c4d499cabc86eefb1 3138 munin_2.0.63-1.dsc bbe4d5e31e99e49274b3ad9a2f6ccda4e90a3c5b5dad440455d66d6b1ad783dd 2247156 munin_2.0.63.orig.tar.gz 992a0237f864bd6a2bada5ded840ba2636e7f019b275b935452c69353f023191 833 munin_2.0.63.orig.tar.gz.asc a108d8a9cdd5b09c9a6cf814ab01a55fabb222752172ef07a0f551e62abedb0c 64316 munin_2.0.63-1.debian.tar.xz f0baafb7e6a6273a2223ca41947c30d3a4f5cc7642cd7a564f76d57653798cf9 5251 munin_2.0.63-1_source.buildinfo Files: d635d6eef0003b8bd35e3be4e17beb94 3138 net optional munin_2.0.63-1.dsc 90cafa8c1f0da167bbe6b278e2732a9a 2247156 net optional munin_2.0.63.orig.tar.gz 712fb918b0abb1396efadf36ca8f85f4 833 net optional munin_2.0.63.orig.tar.gz.asc 319aa23568558d6b4c70552b8a247723 64316 net optional munin_2.0.63-1.debian.tar.xz 8826c45a025239f61558cbf8423ebf05 5251 net optional munin_2.0.63-1_source.buildinfo -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEuL9UE3sJ01zwJv6dCRq4VgaaqhwFAl7e0EgACgkQCRq4Vgaa qhyD8hAApmHRo/PwBzqOihSZzdWkGyYGyNRqSdOSybV+iFRN+9FVO3Ct+lbmZ+f3 jPzLHrPEMv58voQOUK1wfA1qG2x1BIU1QBSS4sBqhGeY3KbXfcU9jEVHseW67uW/ icOhnfQrq2TkVxzku5GNoqdSbGLPu2YrfH9HMc/gKhcOl3pkenoC77jRe8sMTnNh TIKph86aS0LznjvsuvjOSnhxaw/zCW7hp1ypjGYcBL63R+uLdinUQqFwv4/Ef6b0 R7HaUcjsCFTBz243xIqsMuKKBgINDhI8daLxDYHOgJABmgHyk/Ra0iXdO05R/jBG pJA7VyQbzp6AEtffDVKnxr9Utq+vUJjAv5pZ96ovOcF/WaPfkmoDyq0uR0GsO1j3 okTRDGDmLYGSBOmnf05WL198r7qISgipsfEKhrId0N1GQiMK8QzeOjv7UxslHQVJ pMb1IQoXol+1pZ4Es0kzdd9YsuPwZYzUbOyvLkUkB7WMpVA9lLlFbQtwohK1wEyR GIb7PsqT2iFGzL98SBZVZUv0Pea4O+zddRD1PYV9neT1M1otUQX7/SnDCPTK8NVP Eo0fSKartNEbav8qzLumstRxOYZ7nQnO2UoRG2EwRL0yR3ZzQIS2gf7ngyFGyFWG cJHw0b3jy32t3paUOonL+UATSx35ivAxOFeTQyJAqn72CSU3Cew= =ENkO -----END PGP SIGNATURE-----
--- End Message ---
