Your message dated Wed, 24 Jun 2020 15:22:23 +0000 with message-id <[email protected]> and subject line Bug#963486: fixed in tkabber-plugins 1.1.2+20170328-2 has caused the Debian Bug report #963486, regarding tkabber-plugins: please make the build reproducible to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 963486: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=963486 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Source: tkabber-plugins Version: 1.1.2+20170328-1 Severity: wishlist Tags: patch User: [email protected] Usertags: filesystem X-Debbugs-Cc: [email protected] Hi, Whilst working on the Reproducible Builds effort [0] I noticed that tkabber-plugins could not be built reproducibly. This is because the upstream tarball contains the following files: ./attline/readme ./checkers/readme ./ctcomp/readme ./floatingcontact/readme ./jidlink/readme ./otr/readme ./otr/tclotr/readme ./presencecmd/readme ./quotelastmsg/readme ./receipts/readme ... but the following code in debian/docify.sh that is meant to loop over each of the `attline`, `checkers`, top-level directories to rename and move the documentation into place did not take filesystem ordering into consideration: for f in ` find "$d" -type f \( \ -iname README \ -o -iname proto \ \) `; do mv "$f" "$DOCDIR/`basename \"$f\"`.`basename \"$d\"`" done For example, when $d was pointing to $(CURDIR)/otr/, the above code was either iterating over the filesystem in the "human expected" way: ./otr/README ./otr/tclotr/README ... but it would also process them in the following order: ./otr/tclotr/README ./otr/README This would mean that /usr/share/doc/tkabber-plugins/README.otr in the generated .deb would non-deterministically include `otr/tclotr/README` or `otr/README`. Patch attached that, via `-maxdepth 1` ensures only the top-level version is used. Note that stopping on the first result (without sorting) is not a solution as it would simply reverse the non-deterministic logic result we are currently observing. [0] https://reproducible-builds.org/ Regards, -- ,''`. : :' : Chris Lamb `. `'` [email protected] / chris-lamb.co.uk `---- a/debian/docify.sh 2020-06-22 10:40:23.249097774 +0100 --- b/debian/docify.sh 2020-06-22 11:07:08.354698465 +0100 @@ -20,6 +20,7 @@ for f in ` find "$d" -type f \( \ -iname README \ + -maxdepth 1 \ -o -iname proto \ \) `; do mv "$f" "$DOCDIR/`basename \"$f\"`.`basename \"$d\"`"
--- End Message ---
--- Begin Message ---Source: tkabber-plugins Source-Version: 1.1.2+20170328-2 Done: Sergei Golovan <[email protected]> We believe that the bug you reported is fixed in the latest version of tkabber-plugins, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Sergei Golovan <[email protected]> (supplier of updated tkabber-plugins package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Wed, 24 Jun 2020 17:52:10 +0300 Source: tkabber-plugins Architecture: source Version: 1.1.2+20170328-2 Distribution: unstable Urgency: medium Maintainer: Sergei Golovan <[email protected]> Changed-By: Sergei Golovan <[email protected]> Closes: 963486 Changes: tkabber-plugins (1.1.2+20170328-2) unstable; urgency=medium . * Make the build reproducible by reliably including both otr/README and otr/tclotr/README into the binary package (closes: #963486). * Bump the standards version to 4.5.0. Checksums-Sha1: 749ad20772ff69e5c93552c6c8de2867f5835b4f 2020 tkabber-plugins_1.1.2+20170328-2.dsc 738aa4a45b4ba692028742477d93532097908a94 9496 tkabber-plugins_1.1.2+20170328-2.debian.tar.xz 309a234b9fb4f1244c643b760897304f64e0f856 5380 tkabber-plugins_1.1.2+20170328-2_amd64.buildinfo Checksums-Sha256: 3f9934a7e1ae9489479c9296cc1115ad7793950c7d8092e6f46dc51bfec22865 2020 tkabber-plugins_1.1.2+20170328-2.dsc 60229abacb6fec2bf2d6f47d6595eb330536b4605602b7f91a6a631c8a06b81b 9496 tkabber-plugins_1.1.2+20170328-2.debian.tar.xz d8fbabfd4b2f7524e6242768b1145815a8df85dc4a983fdfb0ab43a3de7034ba 5380 tkabber-plugins_1.1.2+20170328-2_amd64.buildinfo Files: e5e94a83cc73892e759b659598cf0f0d 2020 net optional tkabber-plugins_1.1.2+20170328-2.dsc 90c75d6d52b8ecc65c6df3991d4de083 9496 net optional tkabber-plugins_1.1.2+20170328-2.debian.tar.xz a05447e26dbba4e52870e199cf77e96d 5380 net optional tkabber-plugins_1.1.2+20170328-2_amd64.buildinfo -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE/SYPsyDB+ShSnvc4Tyrk60tj54cFAl7za1MACgkQTyrk60tj 54dV2w//W0V9ptq/BXln+FhJ+poCY4X9JgLnMrIFhsbxlMmf+hjX8tOwFs3afKp5 UdsQTanxLKJwvTakaUi0bBzXOKD7d215ihD2JdbmWOx1r0R0v0tRV+bkK07rpWha 6NHc5JWBh1K0bsF1svPXGSnAjZ2K8Sr3JWLsja1B2hQcHUYeu8pOen4tJ04DILvI 63I12DmDrtdYJYqyNMPGa1H3sNbm9euoh3F1z8ijiAkjg4wu1q6mLJvfbMlubNQR 8zmCroSujyaDOniUaQIFXBSd9cY2kRi+jbnxYfnsC8dB0yV+h4V1o7qEcb8tfgKJ 1npx0+z5uIy/daTJCHkHd4HWtz3wTYoIFMTJkjEcmv71C+ia2bAIPYpoQVi3oPtw e56V+tYWF04dw+QLysBgLCgyS66U8DlkTlzAydSWKgvt/n7TAGS3jWZ9qzc25oO6 TEhtAxHl6DMa2ifKDPTSTEx1D+EXW3001XUdYWbe+HIxcgmqvtgIk/Ub0Ah5S3Mi //08W/rrQ2A3gxI/vF9Di9BpvRVCRReVfnuZkFftBgvln1rqpsUXZBxqd0A4THZY BJzsoZOuagNB+hpuN21nlum94qqYZzYPRF3iHDzhqZBqz/LA6rNGK3b9YnH4gU0e 9q/n059TE0mzG/XI4701TwWGMOoTAVO3xSOQPydXgUPQnrXst5k= =eN3G -----END PGP SIGNATURE-----
--- End Message ---
