Your message dated Thu, 09 Jul 2020 10:18:31 +0000
with message-id <[email protected]>
and subject line Bug#953110: fixed in libmpdclient 2.19-1
has caused the Debian Bug report #953110,
regarding libmpdclient2: broken request when size exceeds 4096 bytes
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
953110: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=953110
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: libmpdclient2
Version: 2.16-1
Severity: normal
Tags: upstream

Control: found -1 2.18-1

Reproducer:

Uses mpc to send a 'find' request, containing an invalid search expression. The 
expected result is an error message about the invalid search expression.

working:

 $ strace -s 40 -e trace=sendto,recvfrom mpc find '('$(for i in $(seq 1 4086); 
do echo -n "+"; done)')'
 recvfrom(3, "OK MPD 0.21.4\n", 4096, MSG_DONTWAIT, NULL, NULL) = 14
 sendto(3, "find \"(+++++++++++++++++++++++++++++++++"..., 4096, MSG_DONTWAIT, 
NULL, 0) = 4096
 recvfrom(3, "ACK [2@0] {find} Word expected\n", 4096, MSG_DONTWAIT, NULL, 
NULL) = 31
 mpd error: Word expected
 +++ exited with 1 +++

Note the request size on line 3: 4096 bytes.

broken:

The only difference is one more '+' in the expression, which would result in a 
request of 4097 bytes.

 $ strace -s 40 -e trace=sendto,recvfrom mpc find '('$(for i in $(seq 1 4087); 
do echo -n "+"; done)')'
 recvfrom(3, "OK MPD 0.21.4\n", 4096, MSG_DONTWAIT, NULL, NULL) = 14
 mpd error: Timeout
 +++ exited with 1 +++

Instead of error about the invalid request, a timeout occurs after 30 seconds 
because the request is not really sent (note the missing sendto() call).

Ideally, libmpdclient should support requests of arbitrary size (eventually 
reaching the server limit), but if that is not feasible, at least a proper 
error reporting would be nice.

Thanks for taking care of mpd software in Debian.


Cheers,
    dam

-- System Information:
Debian Release: 10.3
  APT prefers stable
  APT policy: (990, 'stable'), (500, 'unstable'), (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-8-amd64 (SMP w/2 CPU cores)
Locale: LANG=bg_BG.UTF-8, LC_CTYPE=bg_BG.UTF-8 (charmap=UTF-8), 
LANGUAGE=bg_BG.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Init: systemd (via /run/systemd/system)

Versions of packages libmpdclient2 depends on:
ii  libc6  2.29-3

libmpdclient2 recommends no packages.

libmpdclient2 suggests no packages.

-- no debconf information

--- End Message ---
--- Begin Message ---
Source: libmpdclient
Source-Version: 2.19-1
Done: Florian Schlichting <[email protected]>

We believe that the bug you reported is fixed in the latest version of
libmpdclient, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Florian Schlichting <[email protected]> (supplier of updated libmpdclient package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 09 Jul 2020 17:35:20 +0800
Source: libmpdclient
Architecture: source
Version: 2.19-1
Distribution: unstable
Urgency: medium
Maintainer: mpd maintainers <[email protected]>
Changed-By: Florian Schlichting <[email protected]>
Closes: 953110
Changes:
 libmpdclient (2.19-1) unstable; urgency=medium
 .
   * Import new upstream version 2.19 (closes: #953110)
   * Set upstream metadata fields: Bug-Database, Bug-Submit, Repository (thanks
     lintin-brush)
   * Add Rules-Requires-Root: no
   * Update symbols file
   * Bump debhelper-compat to level 13
Checksums-Sha1:
 39267321f088295f2fc7bc2366caa82a17e7c12f 2426 libmpdclient_2.19-1.dsc
 37c769a25d24b7c0172aa1256c520b1b7191351d 69144 libmpdclient_2.19.orig.tar.xz
 ebef7d73c8c2f06fd87e793f05c4da47d3aae8d3 833 libmpdclient_2.19.orig.tar.xz.asc
 b1f54c6f1ad1724a535d3fef11a295cdb7b42951 10440 
libmpdclient_2.19-1.debian.tar.xz
 a2733384bdd7b8c50408b6df83b3e0c23b187e9e 8158 
libmpdclient_2.19-1_amd64.buildinfo
Checksums-Sha256:
 4ded47b652239160ae9b737ea0f93ffce491d4e3e924bf3459ce947b62105bf1 2426 
libmpdclient_2.19-1.dsc
 158aad4c2278ab08e76a3f2b0166c99b39fae00ee17231bd225c5a36e977a189 69144 
libmpdclient_2.19.orig.tar.xz
 52defda8dadc662a477dce67e3d8036890e4cf83c7ef348feeb532f6090dbd23 833 
libmpdclient_2.19.orig.tar.xz.asc
 a67b4a51885fb1562f7ea5d278157b9c433149a4337c5b0bdeadf62a1813970f 10440 
libmpdclient_2.19-1.debian.tar.xz
 b02f973ee78c4a0aa371bf14b9d8c7acbc0b41d10a87f5433760df537340eb4f 8158 
libmpdclient_2.19-1_amd64.buildinfo
Files:
 ab8339f4569061ef3c0ed171af1f6f2b 2426 libs optional libmpdclient_2.19-1.dsc
 aee66cbf5ce2ebf1b976e9c6ade0feee 69144 libs optional 
libmpdclient_2.19.orig.tar.xz
 691d3dc030bd95c6f87333b6438e5d83 833 libs optional 
libmpdclient_2.19.orig.tar.xz.asc
 f5129306c50eea95671d721c1c21b4c1 10440 libs optional 
libmpdclient_2.19-1.debian.tar.xz
 923f5f9fee7c8c122337140c8aaa2fe1 8158 libs optional 
libmpdclient_2.19-1_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEMLI8i05qOwnqprZSEpc7bnLcB7UFAl8G6hUACgkQEpc7bnLc
B7WPGQ/+OCGus1qFa/v66FjxtZbzcf85Cbyjyfdu0juGfeU5TqYwrjPasJPve8+R
r2CsjxXGf6xc52eo98Z5gHTKDlt7A1WPNP5U3TZAKMPLS+Vn9N2HsomKxNSWzRr4
1mZ9Wld5yRikHKvvxiUZaNun1NWa3vMX70cNe1V8JYJA6MFEpKEALUf7akPm3rso
+YwAkbQYM35gEGvN4cmmIDt3UQ1jQ6pwkpYVMv0Z72maB8aoaapXi4jCAhuiSyjb
qeVHPTAhTZw19Dkx13ea2xUf/CAnD521KlHAaKv1p0BbgmJ593qJmCgjqKZF0bMb
XLYIcMAyWlzqYw2SlRRyEOAQD8M+PzvEZV2QA+6XUzG6mPDoCSnmnLYAu7VwWETs
Z4o/k6p9BvER7AWui2mbYhPek6t69pThKjDYJRVYFTFEQceWAs5LSnGCUjdSl+vn
YyttxwF5UjqVzRv0+jCdd1L9alAMlu9jLqOctz7GtsYbgbsQ3RoRRpgfuhe6biJ1
H72E16FFHkA+DQt6P0lm8+WsRlWfyq6Irb/aJK8T2UxTrGUeIhOydoHgRiTviemL
75l/kl48pURg1pit6CcQAPj2C1ZNf1J+4vJ4zA1fFZzrcvIyDDZn34Fp6kwOG0lv
LfeE/P0S9Vf6aUrivBAoM3gNb9Tcfq3KrstTQ5bPJEZEFmrY1vE=
=jGDj
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to