Your message dated Tue, 18 Aug 2020 09:49:04 +0000
with message-id <[email protected]>
and subject line Bug#968185: fixed in pixelmed-codec 20200328-3
has caused the Debian Bug report #968185,
regarding pixelmed-codec: please make the build reproducible
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
968185: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=968185
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: pixelmed-codec
Version: 20200328-2
Severity: wishlist
Tags: patch
User: [email protected]
Usertags: timestamps
X-Debbugs-Cc: [email protected]

Hi,

Whilst working on the Reproducible Builds effort [0] we noticed that
pixelmed-codec could not be built reproducibly.

This is because recently (?) upstream generated a new imageio .jar
file and my previous patch to ensure that the BUILDDATE file needed to
be updated.

Patch attached that abstracts out the generation and uses it two
places.

 [0] https://reproducible-builds.org/


Regards,

--
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      [email protected] / chris-lamb.co.uk
       `-
--- a/Makefile  2020-08-10 11:23:34.813798287 +0100
--- b/Makefile  2020-08-10 11:44:43.921980734 +0100
@@ -65,20 +65,21 @@
        rm -f META-INF/services/javax.imageio.spi.ImageReaderSpi
        echo >META-INF/services/javax.imageio.spi.ImageReaderSpi 
"com.pixelmed.imageio.JPEGLosslessImageReaderSpi"
 
-pixelmed_codec.jar:
-       (cd com/pixelmed/codec/jpeg; make all)
+BUILDDATE:
 ifdef SOURCE_DATE_EPOCH
-       LC_ALL=C date --utc --date="@$$SOURCE_DATE_EPOCH" >BUILDDATE
+       LC_ALL=C date --utc --date="@$$SOURCE_DATE_EPOCH" >$@
 else
-       date >BUILDDATE
+       date >$@
 endif
+
+pixelmed_codec.jar: BUILDDATE
+       (cd com/pixelmed/codec/jpeg; make all)
        jar -cvf $@ BUILDDATE COPYRIGHT \
                com/pixelmed/codec/jpeg/*.class
 
-pixelmed_imageio.jar:  metainf
+pixelmed_imageio.jar: metainf BUILDDATE
        (cd com/pixelmed/codec/jpeg; make all)
        (cd com/pixelmed/imageio; make all)
-       date >BUILDDATE
        jar -cvf $@ BUILDDATE COPYRIGHT \
                META-INF/services/javax.imageio.spi.ImageReaderSpi \
                com/pixelmed/codec/jpeg/*.class \
--- a/debian/patches/reproducible_build.patch   2020-08-10 11:23:34.817798340 
+0100
--- b/debian/patches/reproducible_build.patch   2020-08-10 11:44:51.858080884 
+0100
@@ -3,17 +3,31 @@
 Last-Update: 2016-08-11
 Bug-Debian: https://bugs.debian.org/834052
 
---- a/Makefile
-+++ b/Makefile
-@@ -67,7 +67,11 @@ metainf:
+--- pixelmed-codec-20200328.orig/Makefile
++++ pixelmed-codec-20200328/Makefile
+@@ -65,16 +65,21 @@ metainf:
+       rm -f META-INF/services/javax.imageio.spi.ImageReaderSpi
+       echo >META-INF/services/javax.imageio.spi.ImageReaderSpi 
"com.pixelmed.imageio.JPEGLosslessImageReaderSpi"
  
- pixelmed_codec.jar:
-       (cd com/pixelmed/codec/jpeg; make all)
+-pixelmed_codec.jar:
++BUILDDATE:
 +ifdef SOURCE_DATE_EPOCH
-+      LC_ALL=C date --utc --date="@$$SOURCE_DATE_EPOCH" >BUILDDATE
++      LC_ALL=C date --utc --date="@$$SOURCE_DATE_EPOCH" >$@
 +else
-       date >BUILDDATE
++      date >$@
 +endif
++
++pixelmed_codec.jar: BUILDDATE
+       (cd com/pixelmed/codec/jpeg; make all)
+-      date >BUILDDATE
        jar -cvf $@ BUILDDATE COPYRIGHT \
                com/pixelmed/codec/jpeg/*.class
  
+-pixelmed_imageio.jar: metainf
++pixelmed_imageio.jar: metainf BUILDDATE
+       (cd com/pixelmed/codec/jpeg; make all)
+       (cd com/pixelmed/imageio; make all)
+-      date >BUILDDATE
+       jar -cvf $@ BUILDDATE COPYRIGHT \
+               META-INF/services/javax.imageio.spi.ImageReaderSpi \
+               com/pixelmed/codec/jpeg/*.class \

--- End Message ---
--- Begin Message ---
Source: pixelmed-codec
Source-Version: 20200328-3
Done: Mathieu Malaterre <[email protected]>

We believe that the bug you reported is fixed in the latest version of
pixelmed-codec, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Mathieu Malaterre <[email protected]> (supplier of updated pixelmed-codec 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 18 Aug 2020 11:32:08 +0200
Source: pixelmed-codec
Architecture: source
Version: 20200328-3
Distribution: unstable
Urgency: medium
Maintainer: Debian Med Packaging Team 
<[email protected]>
Changed-By: Mathieu Malaterre <[email protected]>
Closes: 968185
Changes:
 pixelmed-codec (20200328-3) unstable; urgency=medium
 .
   [ Chris Lamb ]
   * d/patches: please make the build reproducible. Closes: #968185
 .
   [ Mathieu Malaterre ]
   * Team upload.
   * d/jpegparse Add new command line tool.
   * d/patches: Add patch to handle help2man
   * d/jpegparse.1.in: Add template for help2man
   * d/rules: Build jpegparse man page
   * d/control: Reflect location of new command line tool: jpegparse.
   * d/manpages: Install jpegparse manpage
Checksums-Sha1:
 2aea96d764568bf480ad9c9b334a74588e56b70c 2179 pixelmed-codec_20200328-3.dsc
 5c92a5825501e9bfeac0cdc758a23acb79b52667 5412 
pixelmed-codec_20200328-3.debian.tar.xz
 7c2a384289f3dedd37daafbba81488adb2f581b3 5618 
pixelmed-codec_20200328-3_source.buildinfo
Checksums-Sha256:
 3435fdd20ab21021ba61238c3cd7421fe7206fff548ae0672b8fb7e787a6e592 2179 
pixelmed-codec_20200328-3.dsc
 5399c6d4e3c752e30609f0430bcb71407f1f782743c45096445e9658cfde4a29 5412 
pixelmed-codec_20200328-3.debian.tar.xz
 57944f55aa3de5e467157ead863ef65489dcb7d5783aa5a235a2f744a3f6e2c9 5618 
pixelmed-codec_20200328-3_source.buildinfo
Files:
 d78347ac23346bceeaf14a53387a7a57 2179 graphics optional 
pixelmed-codec_20200328-3.dsc
 2ede4aa86fe3b7db6cb69152515a62b8 5412 graphics optional 
pixelmed-codec_20200328-3.debian.tar.xz
 a90824abe67c2a6a3855461f8692d4f7 5618 graphics optional 
pixelmed-codec_20200328-3_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJFBAEBCgAvFiEEaTNn/67NjqrNHwY7AXHhgorgk0UFAl87oFMRHG1hbGF0QGRl
Ymlhbi5vcmcACgkQAXHhgorgk0Xbfg/7BnSKkW6AQr0lLBM0jVOSOYXIL3Gl+A57
HwfLlqV0nkeQYyKzcgsU5stTv1PeqKpmHleqJmsHv66QnjDCxVCyxfMZuTSWVisI
LBgYFdXA/IIu7//mXpddG1Bw5fFdD3Q4L4wLx5dmPa9iJeOSMl6xjtn9cKWYtCCO
/RlHJACTR0Awk5o/UGIiJzfgFB5PLSEEpvEGBlz1/fGcMQhJenYdMu0mA/28k6tG
d94JhRylHsIoGVt0zmVI9fExw2rqcvi+DSTjgBBYuosangpIlPO6yKph+0eDO3FA
8Mjkzviuzinwe/FEx3449K1LDBCk0clWV/LqAjbCRWBGfqGIbkuAIltpUqtG/e/j
ixLpNq05CtN0JuEM4CiDkJXWvzP+Pg8WiqoKvXuHzQjOuNQfaDKK+S5TVrLbxBW4
V4p4lmln/naPz2kxX1g8HgGxhuk/2RuO7UpTTVl4m3nO+p+UhIJKrAvn8keF57Ef
QXzUcfsAdkTlPYhNnsSJzUr7AvMZl8Q51xLgv4aVme6bBcSUp2dbXtxosvZp9Hky
0IXc1lR8a2ub8mtdFdLuos+x7oLUXvjp/Mz6sM8MbaLdidwbeVlsOTmicv7ft8ue
FebBiFmGRrhzqktIovL4BZqiikasZIgILUAOyOzJ3az0nwfm5WSTF7o+A6UCQk9p
n5QJcu+Fmuc=
=6r3H
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to