Your message dated Thu, 17 Sep 2020 05:04:19 +0000
with message-id <[email protected]>
and subject line Bug#969396: fixed in sleef 3.5.0-1
has caused the Debian Bug report #969396,
regarding sleef FTBFS on arm64 with gcc-10, sve code requires __sizeless_struct
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
969396: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=969396
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: sleef
Version: 3.4.1-4
Severity: serious
The most recent upload of sleef fixed the build on amd64, armhf, i386 and
ppc64el. Unfortunately
it is still failing on arm64, with the following error.
In file included from /<<PKGBUILDDIR>>/src/libm/sleefsimdsp.c:209:
/<<PKGBUILDDIR>>/src/arch/helpersve.h:94:27: error: expected ‘=’, ‘,’, ‘;’,
‘asm’ or ‘__attribute__’ before ‘{’ token
94 | typedef __sizeless_struct {
| ^
It looks like __sizeless_struct is a compiler feature that was proposed for
adding to gcc,
but it doesn't appear to have actually been added, at least not under that name.
It looks like this bug has shown up now because gcc-10 added support for
"arm_sve.h". previously
this header was not present and so COMPILER_SUPPORTS_SVE was false, but now it
is true and
sleef tries and fails to build the arm sve code.
I whipped up a patch that changes the detection code so it will not try to
build the sve code
if the compiler does not support __sizeless_struct. Unfortunately it then
failed with
[ 50%] Building C object
src/libm-tester/CMakeFiles/iutypurec_scalar.dir/iutsimd.c.o
cd /sleef-3.4.1/obj-aarch64-linux-gnu/src/libm-tester && /usr/bin/cc
-DDETERMINISTIC=1 -DENABLE_ALIAS=1 -DENABLE_PUREC_SCALAR=1 -DENABLE_SYS_getrandom=1
-I/sleef-3.4.1/src/common -I/sleef-3.4.1/src/arch
-I/sleef-3.4.1/obj-aarch64-linux-gnu/include -I/sleef-3.4.1/src/libm
-I/sleef-3.4.1/obj-aarch64-linux-gnu/src/libm/include -Wall -Wno-unused -Wno-attributes
-Wno-unused-result -Wno-psabi -ffp-contract=off -fno-math-errno -fno-trapping-math -O2
-g -DNDEBUG -std=gnu99 -o CMakeFiles/iutypurec_scalar.dir/iutsimd.c.o -c
/sleef-3.4.1/src/libm-tester/iutsimd.c
/sleef-3.4.1/src/libm-tester/iutsimd.c:198:9: error: unknown type name
‘Sleef_double_2’
198 | typedef Sleef_double_2 vdouble2;
| ^~~~~~~~~~~~~~
/sleef-3.4.1/src/libm-tester/iutsimd.c:199:9: error: unknown type name
‘Sleef_float_2’
199 | typedef Sleef_float_2 vfloat2;
|
That was about where I reached the limit of my skills as someone not familiar
with the package,
a work-in progress debdiff is attatched.
Alternatively it looks like there is a new upstream release of sleef that
revamps the sve
code so it can be built with gcc 10. So that might be an alternative route.
diff -Nru sleef-3.4.1/debian/changelog sleef-3.4.1/debian/changelog
--- sleef-3.4.1/debian/changelog 2020-07-30 12:55:23.000000000 +0000
+++ sleef-3.4.1/debian/changelog 2020-09-01 21:17:11.000000000 +0000
@@ -1,3 +1,12 @@
+sleef (3.4.1-4.1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Make sve detection code check for __sizeless_struct. gcc 10 has
+ arm_sve.h but not __sizeless_struct which is needed by the sve
+ implementation in this version.
+
+ -- Peter Michael Green <[email protected]> Tue, 01 Sep 2020 21:17:11 +0000
+
sleef (3.4.1-4) unstable; urgency=medium
* Team Upload.
diff -Nru sleef-3.4.1/debian/patches/check-for-sizeless-struct.patch
sleef-3.4.1/debian/patches/check-for-sizeless-struct.patch
--- sleef-3.4.1/debian/patches/check-for-sizeless-struct.patch 1970-01-01
00:00:00.000000000 +0000
+++ sleef-3.4.1/debian/patches/check-for-sizeless-struct.patch 2020-09-01
21:17:11.000000000 +0000
@@ -0,0 +1,15 @@
+Description: Make sve detection code check for __sizeless_struct.
+ gcc 10 has arm_sve.h but not __sizeless_struct which is needed by the sve
+ implementation in this version.
+Author: Peter Michael Green <[email protected]>
+
+--- sleef-3.4.1.orig/Configure.cmake
++++ sleef-3.4.1/Configure.cmake
+@@ -554,6 +554,7 @@ if(SLEEF_ARCH_AARCH64 AND NOT DISABLE_SV
+ set (CMAKE_REQUIRED_FLAGS ${FLAGS_ENABLE_SVE})
+ CHECK_C_SOURCE_COMPILES("
+ #include <arm_sve.h>
++ typedef __sizeless_struct { svint32_t x, y;} vmask2;
+ int main() {
+ svint32_t r = svdup_n_s32(1); }"
+ COMPILER_SUPPORTS_SVE)
diff -Nru sleef-3.4.1/debian/patches/series sleef-3.4.1/debian/patches/series
--- sleef-3.4.1/debian/patches/series 2020-07-30 12:55:23.000000000 +0000
+++ sleef-3.4.1/debian/patches/series 2020-09-01 21:17:11.000000000 +0000
@@ -1,2 +1,3 @@
disable-neon-on-armel.patch
fix-gcc10-build.patch
+check-for-sizeless-struct.patch
--- End Message ---
--- Begin Message ---
Source: sleef
Source-Version: 3.5.0-1
Done: Mo Zhou <[email protected]>
We believe that the bug you reported is fixed in the latest version of
sleef, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Mo Zhou <[email protected]> (supplier of updated sleef package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Thu, 17 Sep 2020 10:30:28 +0800
Source: sleef
Architecture: source
Version: 3.5.0-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Science Maintainers
<[email protected]>
Changed-By: Mo Zhou <[email protected]>
Closes: 969396
Changes:
sleef (3.5.0-1) unstable; urgency=medium
.
* New upstream version 3.5.0 (Closes: #969396)
* Refresh existing patches and remove fix-gcc10-build.patch (upstreamed).
* Update the installation paths accordingly.
* Refresh symbols control file.
Checksums-Sha1:
cbf9ad20f32e284cac326718f37a728066c9ee65 2080 sleef_3.5.0-1.dsc
e2cfdd7abaab55c48efee10e6f92b488095d0576 1205317 sleef_3.5.0.orig.tar.gz
fd0603ca93af531763cae5020b210922e5252d0f 20840 sleef_3.5.0-1.debian.tar.xz
016d16a441ef1547b6c932492b42960436e44c51 6811 sleef_3.5.0-1_source.buildinfo
Checksums-Sha256:
fa97a7e8b987b9b2a05a7b08b88b2b6da22f42a711190f572564cc5dc002b7f7 2080
sleef_3.5.0-1.dsc
6b952560cec091477affcb18baf06bf50cef9f932ff6aba491a744ee8e77ffea 1205317
sleef_3.5.0.orig.tar.gz
0a4363320d176de1dcd0b782b49d53b1dd118152d7c1df99585dcbc333371b9d 20840
sleef_3.5.0-1.debian.tar.xz
62fba0e7e54d64caae060f9c3bcdb6623b10e9ccd13134d772f32de10455c670 6811
sleef_3.5.0-1_source.buildinfo
Files:
5cb3a8c1cb24ac4bda8889d2053cbc0b 2080 math optional sleef_3.5.0-1.dsc
40c7360f827b26acfb6bc5608a3deb89 1205317 math optional sleef_3.5.0.orig.tar.gz
536f4b2b6657d4a559f004ae8919e32b 20840 math optional
sleef_3.5.0-1.debian.tar.xz
d7ab7ab4cffe497615dde19c7714afc6 6811 math optional
sleef_3.5.0-1_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJFBAEBCgAvFiEEY4vHXsHlxYkGfjXeYmRes19oaooFAl9i6X0RHGx1bWluQGRl
Ymlhbi5vcmcACgkQYmRes19oaoqzhQ/+LSVzGn/CuOYvfHtcIvb0rLc4mQvIR0e8
JOlOwkqLN6ZiutrJ+A+Ls3TNUy+rz26GH5sevpttM/gPIMyBb+SZGjM2ksgBtWo1
HXq/UTuJh35m9jy91C5H0hFxiiXjuUMpqsm+Ymo/2YkYUOvY429PWxFi7gD/Xq0n
hW41XvkccsZOaGzeeSFLesNB7XyNtX5HK3R6TUv47+JYfpDJxNI0zClPxVbeksEW
uCV4v0ufyZzdBJb0pwek+54BBBYtAQSrrUR6YrvpmchuaLysUiqqIcX7CA10oxwj
MU8G8UbotvD41grq1G/up1hQ1qvl8e8xeWdFYLfjjvhPvMbMAsJr9t6/Jc5HxJt2
GdKoUDm5xyUs18xrLfQoUv1igR2PLdTNEhHpj6ZUNL6W5VLrsj9K+GIWRNrfKL9g
/jWL1klbDne7/YsQd4vjNW3k//6AkQ7czobfsN6JDEVMmfMQNjixD1m6K3mUJCkf
SZxuQ+QXX4D1BNUfXuqk59+2rAX+ZAz1ZeKeEmEUKw57Mm5eWsZe/xmMii/fSso6
R88AoX6fmsAYS1ZXwQG+VC586GUXaAvkdMLI/L2+MuWQFlRyaF0tonP8VYCYjQh0
xgbM60XLMrOolQuO+TW2hUMv0EUpU4x2wUQw1sqh0cB2djj1z3Ed7swiSKd9A8Fr
UcNW2/H47JU=
=2EEZ
-----END PGP SIGNATURE-----
--- End Message ---
