Your message dated Tue, 05 Jan 2021 13:19:57 +0000 with message-id <[email protected]> and subject line Bug#964029: fixed in openvswitch 2.13.0+dfsg1-14 has caused the Debian Bug report #964029, regarding openvswitch-switch: ifupdown.sh logic error causes interfaces to be started whenever script is called to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 964029: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=964029 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: openvswitch-switch Version: 2.10.0+2018.08.28+git.8ca7c82b7d+ds1-12+deb10u2 Severity: important Tags: patch Dear Maintainer, After upgrading from stretch to buster we noticed that our previously-working openvswitch configurations would get stuck when bringing up interfaces. We discovered that attempting to manipulate an interface would cause an inappropriate ifup command to be run and deadlock (since the child process would wait for an interface state lock): 12938 \_ /bin/bash 13262 \_ sudo ifdown ovs1 13263 \_ ifdown ovs1 13293 \_ /bin/sh -c /bin/run-parts /etc/network/if-post-down.d 13294 \_ /bin/run-parts /etc/network/if-post-down.d 13297 \_ /bin/sh /etc/network/if-post-down.d/openvswitch 13318 \_ /bin/sh /etc/init.d/openvswitch-switch start 13365 \_ ifup --allow=ovs ovs1 ovs2 We tracked down the problem to the /usr/share/openvswitch/scripts/ifupdown.sh script, specifically: if [ -f $SERVICE_UNIT ] && [ -x /usr/bin/systemctl ]; then if ! systemctl --quiet is-active openvswitch-nonetwork.service; then systemctl start openvswitch-nonetwork.service fi else if service openvswitch-switch status > /dev/null 2>&1; then service openvswitch-switch start fi fi the corresponding logic in the stretch package has the correct logic for the "service openvswitch-switch start" line: if /etc/init.d/openvswitch-switch status > /dev/null 2>&1; then :; else /etc/init.d/openvswitch-switch start fi With this change, everything functions correctly: --- /usr/share/openvswitch/scripts/ifupdown.sh.orig 2020-06-30 17:51:41.033873946 +0000 +++ /usr/share/openvswitch/scripts/ifupdown.sh 2020-06-30 17:52:43.581180302 +0000 @@ -35,7 +35,7 @@ systemctl start openvswitch-nonetwork.service fi else - if service openvswitch-switch status > /dev/null 2>&1; then + if ! service openvswitch-switch status > /dev/null 2>&1; then service openvswitch-switch start fi fi -- System Information: Debian Release: 10.4 APT prefers stable APT policy: (500, 'stable') Architecture: amd64 (x86_64) Kernel: Linux 4.19.0-9-amd64 (SMP w/8 CPU cores) Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE=C.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: sysvinit (via /sbin/init) Versions of packages openvswitch-switch depends on: ii kmod 26-1 ii lsb-base 10.2019051400 ii netbase 5.6 ii openvswitch-common 2.10.0+2018.08.28+git.8ca7c82b7d+ds1-12+deb10u2 ii procps 2:3.3.15-2 ii python 2.7.16-1 ii uuid-runtime 2.33.1-0.1 openvswitch-switch recommends no packages. openvswitch-switch suggests no packages. -- no debconf information
--- End Message ---
--- Begin Message ---Source: openvswitch Source-Version: 2.13.0+dfsg1-14 Done: Thomas Goirand <[email protected]> We believe that the bug you reported is fixed in the latest version of openvswitch, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Thomas Goirand <[email protected]> (supplier of updated openvswitch package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Tue, 05 Jan 2021 13:49:14 +0100 Source: openvswitch Architecture: source Version: 2.13.0+dfsg1-14 Distribution: unstable Urgency: medium Maintainer: Debian OpenStack <[email protected]> Changed-By: Thomas Goirand <[email protected]> Closes: 961746 964029 968333 Changes: openvswitch (2.13.0+dfsg1-14) unstable; urgency=medium . * Starts openvswitch-nonetwork.service after dpdk.service. Thanks to Adriaan Schmidt from Siemens for the report (Closes: #968333). * Fix ifupdown.sh script (Closes: #964029). * Fix dh_installinit dh_installsystemd calls, and switch to debhelper-compat 12 (Closes: #961746). Checksums-Sha1: 03f166e8ea6a8f51af324d0b5c3235a9cf8b3ebe 3166 openvswitch_2.13.0+dfsg1-14.dsc 08319f0f137fd29c152c13c6e14b68ef7c93bde3 51540 openvswitch_2.13.0+dfsg1-14.debian.tar.xz 1cbb7b4fabb046e6c6c9a2633a0dee818e53f71e 19049 openvswitch_2.13.0+dfsg1-14_amd64.buildinfo Checksums-Sha256: 7058a592cb387906441d5a150e30ae44aa66dcb8c121ac64ad06991a46f325d6 3166 openvswitch_2.13.0+dfsg1-14.dsc a7977bc0b9622c751f618e5799bfacd198dec2d6cec1efd3827baebbb2467b8c 51540 openvswitch_2.13.0+dfsg1-14.debian.tar.xz 7ad160f4b36a08ed9b096895e519d19d0a40b1c5c6eb7bd127978a78de75646c 19049 openvswitch_2.13.0+dfsg1-14_amd64.buildinfo Files: 985d344c8d3c853a6a73a9e25eb5dc97 3166 net optional openvswitch_2.13.0+dfsg1-14.dsc ee7ee98e6a6304ea7847550714ce4b4f 51540 net optional openvswitch_2.13.0+dfsg1-14.debian.tar.xz e0202a2b99bce2d1b310356ddad104a7 19049 net optional openvswitch_2.13.0+dfsg1-14_amd64.buildinfo -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEoLGp81CJVhMOekJc1BatFaxrQ/4FAl/0YoEACgkQ1BatFaxr Q/7ULQ//VBn/2PauzVOdJGe4kGYLc5kOkNkRh06wPIxIDTGHuVItzoHkMb2bHj1u ivOOA6Uvt3iX+tGMfMBZpx+G+kHTkZHuIcgoxjy8KSskxnspGwV5eO69D3E4/eov TvIr23NkMwHCprIqXFi9WAjqU1QXZJsnaMM2nSMx8YZWybASANLUwvbO6bPkbjCO RX7ZVCOgfjoKEENAgm1SSl03/J4tHJf3Z5dPLNN+kOgrB04mjP29h2lx7boEPRF+ dpvUKkDjQGaZ73Sg+/W+maIK2gYlzxGbppyVE9L8X4JyLha3OdiKwBakLuQKvoSv Ef4709QnXfx9qxA3itvGyfXzwxx+9Md/HehN0iw2WLSQbafjPXhV1ttYDKDTSBN0 V5EMHrLiLwRNA1BkLQHGGI81a36/QqG3Y7AO1W60sxFPAGn1TpsHCWf5XP0JMtoy Z2dgv3v9OEXhdVwPUWhAg5aEc1kQUL+mf2p1FtVVoh+GCVdEhA3hKHYPOYzB3P3J uj+aBI8uzumyUu+awDECsvK6C/0RkPuPhe4RrfORNdgYBy4DNIpvwTqgjlnKHhqV s55kNb8OSVOJsCqd3fbKgIXMy6GZMtTzTgjj86dgQRzIPRsLOMSNKwIj11RPlEzS Cd7z0SIGF81t7N8FLILNmcIOUUdoKDt6l/BfWuYta3XguT7Ty5w= =e1Xe -----END PGP SIGNATURE-----
--- End Message ---
