Your message dated Wed, 06 Jan 2021 15:21:16 +0000 with message-id <[email protected]> and subject line Bug#944123: fixed in tig 2.5.1-1 has caused the Debian Bug report #944123, regarding tig: Tig crashes when searching and used as pager with readline 8 to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 944123: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=944123 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: tig Version: 2.4.1-1build1 Severity: normal Dear Maintainer, export GIT_PAGER="tig" git log or just git log | tig Then, write '/' and hit enter, tig will crash. This is the backtrace when launching it as git log | gdb -ex r -ex "set logging on" -ex "bt full" -ex quit --args tig #0 0x00007ffff7f84a20 in _rl_update_final () at ./display.c:2972 full_lines = 0 woff = 0 botline_length = <optimized out> #1 0x00007ffff7f8b695 in rl_newline (count=<optimized out>, key=<optimized out>) at ./text.c:1105 No locals. #2 0x00007ffff7f6d707 in _rl_dispatch_subseq (key=13, map=<optimized out>, got_subseq=<optimized out>) at ./readline.c:852 r = 0 newkey = <optimized out> macro = <optimized out> func = 0x7ffff7f8b5d0 <rl_newline> cxt = <optimized out> #3 0x00007ffff7f6dbf5 in _rl_dispatch (key=<optimized out>, map=<optimized out>) at ./readline.c:798 No locals. #4 0x00007ffff7f6dcc5 in readline_internal_char () at ./readline.c:632 lastc = 13 eof_found = <optimized out> c = <optimized out> code = <optimized out> lk = 0 r = <optimized out> #5 0x00007ffff7f6e4ed in readline_internal_charloop () at ./readline.c:659 eof = 1 #6 readline_internal () at ./readline.c:671 No locals. #7 readline (prompt=prompt@entry=0x5555555928da "/") at ./readline.c:377 value = <optimized out> #8 0x000055555557200d in read_prompt (prompt=prompt@entry=0x5555555928da "/") at src/prompt.c:499 line = 0x0 last_entry = <optimized out> #9 0x000055555557a2f6 in search_view (view=0x5555555ea9e0 <pager_view>, request=REQ_SEARCH) at src/search.c:240 prompt = 0x5555555928da "/" search = <optimized out> #10 0x000055555556134d in view_driver (request=REQ_SEARCH, view=0x5555555ea9e0 <pager_view>) at src/tig.c:296 i = <optimized out> i = <optimized out> line = <optimized out> nviews = <optimized out> next_view = <optimized out> #11 main (argc=<optimized out>, argv=<optimized out>) at src/tig.c:840 codeset = <optimized out> pager_mode = true request = <optimized out> view = <optimized out> Attaching the debdiff that fixes the issue -- System Information: Debian Release: buster/sid APT prefers eoan-updates APT policy: (500, 'eoan-updates'), (500, 'eoan-security'), (500, 'eoan-proposed'), (500, 'eoan') Architecture: amd64 (x86_64) Kernel: Linux 4.18.0-21-generic (SMP w/8 CPU cores) Kernel taint flags: TAINT_WARN, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE Locale: LANG=it_IT.UTF-8, LC_CTYPE=it_IT.UTF-8 (charmap=UTF-8), LANGUAGE=it_IT.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) Versions of packages tig depends on: ii git [git-core] 1:2.20.1-2ubuntu1 ii libc6 2.30-0ubuntu2 ii libncursesw6 6.1+20190803-1ubuntu1 ii libreadline8 8.0-3 ii libtinfo6 6.1+20190803-1ubuntu1 tig recommends no packages. tig suggests no packages. -- no debconf informationdiff -Nru tig-2.4.1/debian/changelog tig-2.4.1/debian/changelog --- tig-2.4.1/debian/changelog 2018-11-08 23:08:23.000000000 +0100 +++ tig-2.4.1/debian/changelog 2019-11-04 16:59:51.000000000 +0100 @@ -1,3 +1,10 @@ +tig (2.4.1-2) UNRELEASED; urgency=medium + + * debian/patches/0001-Fix-segfaults-with-readline-8.0.patch: + - Fix a crash when using readline 8.0 (LP: #1851235) + + -- Marco Trevisan (Treviño) <[email protected]> Mon, 04 Nov 2019 16:59:51 +0100 + tig (2.4.1-1) unstable; urgency=medium * New upstream version. diff -Nru tig-2.4.1/debian/patches/0001-Fix-segfaults-with-readline-8.0.patch tig-2.4.1/debian/patches/0001-Fix-segfaults-with-readline-8.0.patch --- tig-2.4.1/debian/patches/0001-Fix-segfaults-with-readline-8.0.patch 1970-01-01 01:00:00.000000000 +0100 +++ tig-2.4.1/debian/patches/0001-Fix-segfaults-with-readline-8.0.patch 2019-11-04 16:59:51.000000000 +0100 @@ -0,0 +1,53 @@ +From ea43f8be22c7b985c7c752d938579fe14d8e9f08 Mon Sep 17 00:00:00 2001 +From: Thomas Koutcher <[email protected]> +Date: Mon, 22 Apr 2019 18:37:34 +0200 +Subject: [PATCH] Fix segfaults with readline 8.0 + +Closes #893 + +Origin: https://github.com/jonas/tig/commit/ea43f8be22c7b985c7c752d938579fe14d8e9f08 +Applied-Upstream: 2.4.2 +--- + src/prompt.c | 6 ++++++ + 1 file changed, 6 insertions(+) + +diff --git a/src/prompt.c b/src/prompt.c +index c85bc5d..831e4c9 100644 +--- a/src/prompt.c ++++ b/src/prompt.c +@@ -475,11 +475,14 @@ readline_init(void) + /* Let ncurses deal with the LINES and COLUMNS environment variables */ + rl_change_environment = 0; + rl_catch_sigwinch = 0; ++ rl_deprep_term_function = NULL; ++ rl_prep_term_function = NULL; + } + + static void sigint_absorb_handler(int sig) { + signal(SIGINT, SIG_DFL); + prompt_interrupted = true; ++ rl_done = 1; + } + + char * +@@ -496,7 +499,9 @@ read_prompt(const char *prompt) + curs_set(1); + if (signal(SIGINT, sigint_absorb_handler) == SIG_ERR) + die("Failed to setup sigint handler"); ++ cbreak(); + line = readline(prompt); ++ raw(); + if (signal(SIGINT, SIG_DFL) == SIG_ERR) + die("Failed to remove sigint handler"); + curs_set(0); +@@ -507,6 +512,7 @@ read_prompt(const char *prompt) + if (prompt_interrupted) { + free(line); + line = NULL; ++ report_clear(); + } + + prompt_interrupted = false; +-- +2.20.1 + diff -Nru tig-2.4.1/debian/patches/series tig-2.4.1/debian/patches/series --- tig-2.4.1/debian/patches/series 1970-01-01 01:00:00.000000000 +0100 +++ tig-2.4.1/debian/patches/series 2019-11-04 16:59:51.000000000 +0100 @@ -0,0 +1 @@ +0001-Fix-segfaults-with-readline-8.0.patch
--- End Message ---
--- Begin Message ---Source: tig Source-Version: 2.5.1-1 Done: Sebastian Harl <[email protected]> We believe that the bug you reported is fixed in the latest version of tig, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Sebastian Harl <[email protected]> (supplier of updated tig package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Tue, 05 Jan 2021 23:30:32 +0100 Source: tig Architecture: source Version: 2.5.1-1 Distribution: unstable Urgency: medium Maintainer: Sebastian Harl <[email protected]> Changed-By: Sebastian Harl <[email protected]> Closes: 944123 963005 Changes: tig (2.5.1-1) unstable; urgency=medium . * New upstream release (Closes: #963005). - Fixes segfault with readline 8; thanks to Marco Trevisan for reporting this (Closes: #944123). * Update standards-version to 4.5.1 and compat to 12; no changes. Checksums-Sha1: 4f328efec214b0e497326b89385e90e02dbd8f5b 1857 tig_2.5.1-1.dsc fd1b28bba7dff24ed112b869bb95a847c4e7ed3b 1144666 tig_2.5.1.orig.tar.gz 20e2f31610e28250c176b59ac8b1ae521dd88468 8644 tig_2.5.1-1.debian.tar.xz 69d6df66f1fa9d96c5c73da1c7d4aada3c30fd28 9102 tig_2.5.1-1_amd64.buildinfo Checksums-Sha256: 9a6a49e55c136d7f1ac557331effbc80f71dd0bd1f732160965ac9a313347d6b 1857 tig_2.5.1-1.dsc 500d5d34524f6b856edd5cae01f1404d14f3b51a9a53fd7357f4cebb3d4c9e64 1144666 tig_2.5.1.orig.tar.gz 7e23b4772f27fea78b83a3046948604d807b5d0497354d70c50513ab13902356 8644 tig_2.5.1-1.debian.tar.xz 9a6f29ded1ae9f5a3224f4251e6654b042611537f0db3c68673057382a6faaf5 9102 tig_2.5.1-1_amd64.buildinfo Files: a1386181c2053a4adf9493c4662dee72 1857 vcs optional tig_2.5.1-1.dsc 4d810b7de2dfc842ceeb8b8d88740f2c 1144666 vcs optional tig_2.5.1.orig.tar.gz a745a2b3963ca81ce0fb49ac95cc249d 8644 vcs optional tig_2.5.1-1.debian.tar.xz 221c8087e2b27df9caa554da838fb3b5 9102 vcs optional tig_2.5.1-1_amd64.buildinfo -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE0SB09zJN4Zng3RwbzAV+ci8f/McFAl/1yr4ACgkQzAV+ci8f /Mc2mA/9Fr1k8akVnj0h9cCDQ3Ly8hkd/MVevy1Gu8TbBcwG18UQOaAiscVJ9krs Q5R0JsieRm/BZazsiV3jCwed5qNqBWzIFrD8AnYsWXAa6DeVjtgbQib1VIkKpSsc x+LpZIm/zWNUrMZuDJ24suA1ARKlRStHSUqVHzrSoDi2exbtum7H7BHXJu0+j+LN iuiYGlYn6IDlyhzNp3DDQlzel62OpW9u+dyZ5tsEMlxb4BGFByHIL/ovYGAQfCfC tVw/BBJ5drlN3jCBkUytaf1BvF304KAvzWZyb3D3BfAZq8Xv8BNjPQ3QjlrR7ETX 67ljCOzsbY6V/ey4oFqGHO8yfNGfZT1Q/37gNKSIfl7MkNIu40CTwHUVBl72kDII NdPxB4Lp+WYE5n70vaMZO4UZ9TwJM+/b47+JTZqzrFNopyDCksFOPt3HPz0Rgs+H PKxo1Gr5FZXYvEYOta90KyDY1P2Ti5M1ECUqkoP9x67earrPaH0B3nAxrZouNTwb aSWBoH1lw4Z8LaIvWHD3tr7RNW33lQg7hywu9imv/hB0ob1hxQi5ZkbzVlVJ6YXQ Unfep5hkL//de7E4St+qDmAxamnJwd3DEg/voQdHvqCTb1lG+8fPATNks0QDlenj 8KQBswUNoaMcedC4MlHVMLM/JjWdfE5GOKJ8ynaKIGPIE59lSb8= =6ynf -----END PGP SIGNATURE-----
--- End Message ---
