Your message dated Sat, 16 Jan 2021 15:03:59 +0000
with message-id <[email protected]>
and subject line Bug#978485: fixed in libpff 20180714-3
has caused the Debian Bug report #978485,
regarding libpff: memory tests fundamentally broken, please disable them on
riscv64
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
978485: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=978485
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: libpff
Version: 20180714-2
Severity: normal
Tags: ftbfs patch upstream
User: [email protected]
Usertags: riscv64
Hi,
libpff fails to build on riscv64:
https://buildd.debian.org/status/fetch.php?pkg=libpff&arch=riscv64&ver=20180714-2&stamp=1580068149&raw=0
This is due to fundamentally broken tests assuming that memcpy and
memset can fail returning NULL, and interposing these libc functions in
the tests with functions that sometimes return NULL. This tests should
be simply removed as they do not make sense. See bug #978433 for more
details as the same code is basically replicated in dozen of packages.
A simpler way to fix the issue for riscv64 is to disable all memory
tests on this architecture, as it is already done for a long list of
cases. This is what the patch below does:
--- libpff-20180714/debian/patches/04-disable-memory-tests-on-riscv64.patch
1970-01-01 01:00:00.000000000 +0100
+++ libpff-20180714/debian/patches/04-disable-memory-tests-on-riscv64.patch
2020-12-27 15:08:04.000000000 +0100
@@ -0,0 +1,11 @@
+--- libpff-20180714.orig/tests/pff_test_memory.h
++++ libpff-20180714/tests/pff_test_memory.h
+@@ -28,7 +28,7 @@
+ extern "C" {
+ #endif
+
+-#if defined( HAVE_GNU_DL_DLSYM ) && defined( __GNUC__ ) && !defined(
LIBPFF_DLL_IMPORT ) && !defined( __arm__ ) && !defined( __clang__ ) &&
!defined( __CYGWIN__ ) && !defined( __hppa__ ) && !defined( __mips__ ) &&
!defined( __sparc__ ) && !defined( HAVE_ASAN )
++#if defined( HAVE_GNU_DL_DLSYM ) && defined( __GNUC__ ) && !defined(
LIBPFF_DLL_IMPORT ) && !defined( __arm__ ) && !defined( __clang__ ) &&
!defined( __CYGWIN__ ) && !defined( __hppa__ ) && !defined( __mips__ ) &&
!defined( __sparc__ ) && !defined( __riscv ) && !defined( HAVE_ASAN )
+ #define HAVE_PFF_TEST_MEMORY 1
+ #endif
+
--- libpff-20180714/debian/patches/series 2020-01-19 22:36:49.000000000
+0100
+++ libpff-20180714/debian/patches/series 2020-12-27 15:08:04.000000000
+0100
@@ -1,3 +1,4 @@
01-fix-spelling-binary.patch
02-fix-man-pages-pffexport-and-pffinfo.patch
03-fixes-for-libpff-manpage.patch
+04-disable-memory-tests-on-riscv64.patch
Regards,
Aurelien
--- End Message ---
--- Begin Message ---
Source: libpff
Source-Version: 20180714-3
Done: Aleksey Kravchenko <[email protected]>
We believe that the bug you reported is fixed in the latest version of
libpff, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Aleksey Kravchenko <[email protected]> (supplier of updated libpff package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sun, 10 Jan 2021 16:17:11 +0300
Source: libpff
Architecture: source
Version: 20180714-3
Distribution: unstable
Urgency: medium
Maintainer: Debian Security Tools <[email protected]>
Changed-By: Aleksey Kravchenko <[email protected]>
Closes: 978485
Changes:
libpff (20180714-3) unstable; urgency=medium
.
[ Balint Reczey ]
* d/tests/pfftools: Update sample URL to fix autopkgtest (LP: #1910396)
.
[ Aleksey Kravchenko ]
* d/patches/04-disable-memory-tests-on-riscv64.patch: Import BTS patch to
fix FTBFS by disabling broken memory tests on riscv64 (Closes: #978485)
* upstream/metadata:
- Fix YAML format by removing hyphens
- Add Bug-Submit field
* d/control:
- Bump debhelper-compat to 13
- Bump Standards-Version to 4.5.1
- Add Aleksey Kravchenko to Uploaders
* d/rules: Remove the -Wl,--as-needed linker flag as it is already set
by toolchain by default
Checksums-Sha1:
c2c5417232003ab69470ab2703ce794cb64a6e01 2254 libpff_20180714-3.dsc
4f2bdd49e4dff641195a18f11d618ff0e059303c 16008 libpff_20180714-3.debian.tar.xz
7e77a5b8ca112a8b6dffb9dee7b1f136d67e8ba0 8395 libpff_20180714-3_amd64.buildinfo
Checksums-Sha256:
171909538efd6cbd4b7ea42adf3ad9bddb77ec9ca1c56108bc7816af5d5ea31f 2254
libpff_20180714-3.dsc
57154647dab276be7b2a1c2f7a3d38fece061b7205d0e28e438e1abd6b57025d 16008
libpff_20180714-3.debian.tar.xz
f6202ee99dd918102749d4e37c0643b3d321e4f8bfe338822190836bca63b9f2 8395
libpff_20180714-3_amd64.buildinfo
Files:
d36204b8c68cc699c8a3d4707231f70c 2254 libs optional libpff_20180714-3.dsc
f983995e47d41221d2ece725e8e31a8b 16008 libs optional
libpff_20180714-3.debian.tar.xz
4a23231ac9bffe0a4520970d224ca6d9 8395 libs optional
libpff_20180714-3_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEBdtqg34QX0sdAsVfu6n6rcz7RwcFAmAC/MMACgkQu6n6rcz7
Rwd1rxAAxA0xTqsWiJKyULFyRoH/2JWjNoJlPfk7BLDcnY74qoBaLhQWwfFvG7md
3TdIa8kFbYGpUZ5PvUHgcffPtTFmCg7fnxSQkzp65eJ+8pL0t9lC4EM3H4kDZFds
MrJJuU6pVL54wgJL/QqaUsI1I5zoBAlwlo+aCkDOqoYW0zqJ+t0fgmnX01/Z4S+a
gMh8s3MLQxPy2CVukYWfeaiXHe/zxKjiqouLBbpVmJudAIKEscBgo8W5gqWke05D
YCn6ulIe1gvqNieV+MTOdnJqWCnwEEgp1b0Eq+DEtphTsNgj1bZ0VX0VRO2ifzjT
4I0KcQuq7cqIPauGN6eFkQP7IXycWqWn5fQy8VT6fv5/V20quOtCQBmXGETRgjcl
1W8nsFq1j6FzoCOztS933WM8TIjHt1DMkJSryrhZmQ9RaTr5DKn25Bbd+lfbkPjM
NnZbnPHqa4yMs4oLUQT8mzSjLxyfOxYS4ENNbigGCzU5/11b8hZ4pC4TEhskyVKa
vDnj4nGggRP4NpHgSYNEWgymjHnVm3TY2ytnGMRGdwtkVhaPfUkMJOTKD5iu9TIP
13QPVlq80+lVO8aCf/fewwkXpYw8GWF1q1J1pLMKebKcwFOMFXBTvnWMer0B6keE
vDGQAxbzdrz8PFae56cKzNgyCgyYQF2XC8QJGpjosWMPTzFpNZY=
=QD1c
-----END PGP SIGNATURE-----
--- End Message ---
